refactor(DataTypeNamespace): Replace sniff with Slevomat sniff

Author: klausi

coder_sniffer/Drupal/Sniffs/Commenting/DataTypeNamespaceSniff.php

@@ -136,6 +136,7 @@
   </rule>
   <rule ref="SlevomatCodingStandard.ControlStructures.NewWithParentheses"/>
   <rule ref="SlevomatCodingStandard.ControlStructures.RequireNullCoalesceOperator"/>
+  <rule ref="SlevomatCodingStandard.Namespaces.FullyQualifiedClassNameInAnnotation"/>
   <rule ref="SlevomatCodingStandard.Namespaces.UnusedUses"/>
   <rule ref="SlevomatCodingStandard.Namespaces.UseDoesNotStartWithBackslash"/>
   <rule ref="SlevomatCodingStandard.Namespaces.UseFromSameNamespace"/>

coder_sniffer/Drupal/ruleset.xml

@@ -14,7 +14,7 @@
  * @return bool
  *   Returns FALSE.
  *
- * @throws Exception
+ * @throws \Exception
  *   Thrown when $param is TRUE.
  *
  * @ingroup sniffer
@@ -97,7 +97,7 @@ function test12() {
  * | Unseen University | Mustrum Ridcully | Alberto Malich the Wise | 1281 AM       | Nvnc Id Vides, Nvnc Ne Vides           |
  * phpcs:enable
  *
- * @param TableNode $organisation_table
+ * @param \TableNode $organisation_table
  *   The organisation data.
  *
  * @Given (the following )organisations:

tests/Drupal/Commenting/DataTypeNamespaceUnitTest.php

@@ -309,9 +309,9 @@ protected function getErrorList(string $testFile): array
                 638 => 1,
                 646 => 2,
                 648 => 1,
-                656 => 1,
+                656 => 2,
                 658 => 1,
-                661 => 1,
+                661 => 2,
                 671 => 1,
                 678 => 1,
                 685 => 1,
@@ -389,6 +389,13 @@ protected function getErrorList(string $testFile): array
                 16 => 1,
                 31 => 1,
             ];
+        case 'DataTypeNamespaceUnitTest.inc':
+            return [
+                15 => 1,
+                18 => 1,
+                21 => 1,
+                31 => 1,
+            ];
         case 'FinallySpacingUnitTest.inc':
             return [
                 1 => 1,
@@ -421,8 +428,10 @@ protected function getErrorList(string $testFile): array
                 22 => 1,
                 23 => 1,
                 35 => 1,
+                42 => 1,
                 56 => 1,
                 85 => 1,
+                87 => 1,
                 98 => 1,
             ];
         case 'UseLeadingBackslashUnitTest.inc':

tests/Drupal/Commenting/DocCommentUnitTest.inc.fixed

@@ -26,7 +26,7 @@ class UnusedUseStatementUnitTest {
   /**
    * Aliased type that is otherwise unused.
    *
-   * @var AliasVarName2
+   * @var \Some\Data\VarName2
    */
   protected $y;
 
@@ -71,7 +71,7 @@ class UnusedUseStatementUnitTest {
   protected function test6($x) {
     /** @var \Some\Data\VarName $y */
     $y = $x['test'];
-    /** @var AliasVarName2 $z */
+    /** @var \Some\Data\VarName2 $z */
     $z = $x['test2'];
     return $y;
   }

tests/Drupal/bad/BadUnitTest.php

@@ -672,7 +672,7 @@ function test14() {
 /**
  * Return data type documentation must not be the variable name.
  *
- * @return foo
+ * @return \foo
  *   Description bla.
  */
 function test15() {
@@ -690,12 +690,12 @@ function test16() {
 /**
  * Invalid data types.
  *
- * @param mixed $x
+ * @param \type $x
  *   Description here.
  * @param bool $y
  *   Description here.
  *
- * @return unknown_type
+ * @return \unknown_type
  *   Description here.
  */
 function test17($x, $y) {

tests/Drupal/Commenting/DataTypeNamespaceUnitTest.inc renamed to tests/Drupal/bad/DataTypeNamespaceUnitTest.inc

@@ -105,7 +105,7 @@ public function getConfiguration() {
    * The second version of this test with error name with underscores
    * is added below.
    *
-   * @throws Exception
+   * @throws \Exception
    */
   public function test6() {
     throw new Exception();