refactor(ClassFileName): Use upstream Squiz ClassFileName sniff directly (pfrenssen#276)

Author: klausi

.github/workflows/testing.yml

@@ -86,6 +86,7 @@ jobs:
           sed -i 's/Drupal.Classes.ClassCreateInstance/SlevomatCodingStandard.ControlStructures.NewWithParentheses/g' phpcs.xml.dist
           sed -i 's/Drupal.Classes.UnusedUseStatement/SlevomatCodingStandard.Namespaces.UnusedUses/g' phpcs.xml.dist
           sed -i '/<rule ref="SlevomatCodingStandard.Exceptions.RequireNonCapturingCatch" \/>/a \  <rule ref="SlevomatCodingStandard.Namespaces.UseFromSameNamespace"/>' phpcs.xml.dist
+          sed -i 's@<rule ref="Drupal.Classes.ClassFileName"/>@<rule ref="Squiz.Classes.ClassFileName">\n    <!-- Disable class name to file name matching for *Test.php files. -->\n    <exclude-pattern>*/tests/*/*(Test|TestBase).php</exclude-pattern>\n  </rule>@' phpcs.xml.dist
           find . -type f -name "*.php" -exec sed -i 's#// phpcs:ignore Drupal.Classes.PropertyDeclaration, Drupal.NamingConventions.ValidVariableName.LowerCamelName, Drupal.Commenting.VariableComment.Missing#// phpcs:ignore Drupal.NamingConventions.ValidVariableName.LowerCamelName,PSR2.Classes.PropertyDeclaration.Underscore#g' {} +
           find . -type f -name "*.php" -exec sed -i 's#// @codingStandardsIgnoreLine#// phpcs:ignore#g' {} +
           find . -type f -name "*.php" -exec sed -i 's#// @codingStandardsIgnoreFile#// phpcs:ignoreFile#g' {} +
@@ -95,4 +96,4 @@ jobs:
           sed -i '/<rule ref="Drupal.Functions.FunctionDeclaration"\/>/d' phpcs.xml.dist
           sed -i 's/DrupalPractice.CodeAnalysis.VariableAnalysis/VariableAnalysis.CodeAnalysis.VariableAnalysis/g' phpcs.xml.dist
           find .. -type f -name "*.php" -exec sed -i 's#// phpcs:ignore DrupalPractice.CodeAnalysis.VariableAnalysis#// phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis#g' {} +
-          ../../vendor/bin/phpcs -p -s --parallel=$(nproc) --ignore=lib/Drupal/Core/Command/GenerateTheme.php,modules/mysql/tests/src/Kernel/mysql/Console/DbDumpCommandTest.php
+          ../../vendor/bin/phpcs -p -s --parallel=$(nproc) --ignore=lib/Drupal/Core/Command/GenerateTheme.php,modules/mysql/tests/src/Kernel/mysql/Console/DbDumpCommandTest.php,modules/big_pipe/tests/modules/big_pipe_test/src/BigPipePlaceholderTestCases.php,tests/fixtures/plugins/CustomPlugin.php,modules/package_manager/tests/modules/package_manager_test_api/src/ApiController.php

coder_sniffer/Drupal/Sniffs/Classes/ClassFileNameSniff.php

@@ -186,6 +186,10 @@
 
   <rule ref="Squiz.Arrays.ArrayBracketSpacing"/>
 
+  <rule ref="Squiz.Classes.ClassFileName">
+    <!-- Disable class name to file name matching in Test files. -->
+    <exclude-pattern>*/tests/*/*(Test|TestBase).php</exclude-pattern>
+  </rule>
   <rule ref="Squiz.ControlStructures.ForEachLoopDeclaration"/>
   <!-- Disable some error messages that we already cover. -->
   <rule ref="Squiz.ControlStructures.ForEachLoopDeclaration.AsNotLower">

coder_sniffer/Drupal/ruleset.xml

@@ -7,7 +7,7 @@
 
     <!-- Test files that should not be checked. -->
     <exclude-pattern>tests/*\.(inc|api\.php|tpl\.php)$</exclude-pattern>
-    <exclude-pattern>tests/*/(good|bad)\.php$</exclude-pattern>
+    <exclude-pattern>tests/*/(good|bad)/*\.php$</exclude-pattern>
     <exclude-pattern>tests/*/drupal(6|7|8)/*\.php$</exclude-pattern>
 
     <!-- The following comes from the 3.4.2 PHPCS ruleset.xml { -->

phpcs.xml.dist

@@ -7,8 +7,8 @@ parameters:
         # Test files that should not be checked.
         - 'tests/*/*.tpl.php'
         - 'tests/*/*.api.php'
-        - 'tests/*/good.php'
-        - 'tests/*/bad.php'
+        - 'tests/*/good/*.php'
+        - 'tests/*/bad/*.php'
         - 'tests/*/drupal[678]/*.php'
     bootstrapFiles:
         - tests/Drupal/phpunit-bootstrap.php