refactor(FullyQualifiedNamespace): Replace sniff in favor of a sniff from Slevomat

Author: klausi

coder_sniffer/Drupal/ruleset.xml

@@ -122,6 +122,22 @@
 
  <rule ref="SlevomatCodingStandard.ControlStructures.RequireNullCoalesceOperator" />
  <rule ref="SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses" />
+ <!-- Allow global names with backslash like \Drupal. -->
+ <rule ref="SlevomatCodingStandard.Namespaces.ReferenceUsedNamesOnly">
+  <properties>
+   <property name="allowFullyQualifiedGlobalClasses" value="true" />
+   <property name="allowFullyQualifiedGlobalFunctions" value="true" />
+   <property name="allowFullyQualifiedGlobalConstants" value="true" />
+   <property name="allowFallbackGlobalFunctions" value="true" />
+   <property name="allowFallbackGlobalConstants" value="true" />
+  </properties>
+ </rule>
+ <rule ref="SlevomatCodingStandard.Namespaces.ReferenceUsedNamesOnly.ReferenceViaFullyQualifiedName">
+  <exclude-pattern>*.api.php</exclude-pattern>
+ </rule>
+ <rule ref="SlevomatCodingStandard.Namespaces.ReferenceUsedNamesOnly.ReferenceViaFullyQualifiedNameWithoutNamespace">
+  <severity>0</severity>
+ </rule>
  <rule ref="SlevomatCodingStandard.PHP.ShortList" />
 
  <rule ref="Squiz.Arrays.ArrayDeclaration" />
@@ -298,7 +314,7 @@
  <exclude-pattern>*/\.svn/*</exclude-pattern>
  <exclude-pattern>*/\.hg/*</exclude-pattern>
  <exclude-pattern>*/\.bzr/*</exclude-pattern>
- 
+
  <!-- Ignore minified CSS files.-->
  <exclude-pattern>*\.min\.css$</exclude-pattern>
 </ruleset>

tests/Drupal/Classes/FullyQualifiedNamespaceUnitTest.1.inc.fixed

@@ -8,7 +8,6 @@
  * without them.
  * phpcs:disable Drupal.Commenting
  */
-
 use Foo\Bar;
 
 /**

tests/Drupal/good/GoodNamespace.php

@@ -0,0 +1,17 @@
+<?php
+
+namespace Drupal\mymodule;
+
+/**
+ * Some fluffy comment about the class.
+ */
+class GoodNamespace {
+
+  /**
+   * Using \Drupal without a use statement is fine.
+   */
+  public static function version(): string {
+    return \Drupal::VERSION . phpversion() . \phpversion();
+  }
+
+}

tests/Drupal/good/good.php

@@ -1397,17 +1397,6 @@ public function test() {
 
 }
 
-// Namespaced function call is allowed because PHP 5.5 and lower do not support
-// use statements for functions.
-$default_config = [
-  'verify' => TRUE,
-  'timeout' => 30,
-  'headers' => [
-    'User-Agent' => 'Drupal/' . \Drupal::VERSION . ' (+https://www.drupal.org/) ' . \GuzzleHttp\default_user_agent(),
-  ],
-  'handler' => $stack,
-];
-
 // camelCase and snake_case variables are allowed.
 $snake_case = 1;
 $camelCase = 1;
@@ -1819,3 +1808,5 @@ public function attributes(): void {
   }
 
 }
+
+$version = \Drupal::VERSION;