lint(ng-pixijs,example-ng-pixijs): fix lint

klerick · klerick · commit 8a9bb9dc10f8 · 2024-12-18T16:51:49.000+01:00
diff --git a/apps/example-ng-pixijs/eslint.config.js b/apps/example-ng-pixijs/eslint.config.js
@@ -12,15 +12,15 @@ module.exports = [
         'error',
         {
           type: 'attribute',
-          prefix: 'app',
+          // prefix: 'app',
           style: 'camelCase',
         },
       ],
       '@angular-eslint/component-selector': [
         'error',
         {
           type: 'element',
-          prefix: 'app',
+          // prefix: 'app',
           style: 'kebab-case',
         },
       ],
diff --git a/apps/example-ng-pixijs/src/app/empty/empty.component.ts b/apps/example-ng-pixijs/src/app/empty/empty.component.ts
@@ -1,5 +1,4 @@
-import { Component, Input } from '@angular/core';
-import { CommonModule } from '@angular/common';
+import { Component } from '@angular/core';
 import { NgDocButtonComponent, NgDocColor, NgDocNotifyService } from '@ng-doc/ui-kit';
 
 @Component({
diff --git a/apps/example-ng-pixijs/src/app/example/example.component.ts b/apps/example-ng-pixijs/src/app/example/example.component.ts
@@ -95,18 +95,16 @@ export class ExampleComponent {
   }
 
   resetGame() {
-    this.config.update((r) => {
-      return {
-        isRunning: false,
-        prevDirection: 'right',
-        direction: 'right',
-        isStarted: false,
-        count: 0,
-        speed: 0.5,
-        positionX: 0,
-        positionY: 0,
-        isWin: undefined,
-      };
+    this.config.set({
+      isRunning: false,
+      prevDirection: 'right',
+      direction: 'right',
+      isStarted: false,
+      count: 0,
+      speed: 0.5,
+      positionX: 0,
+      positionY: 0,
+      isWin: undefined,
     });
   }
 
diff --git a/apps/example-ng-pixijs/src/app/main/main.component.html b/apps/example-ng-pixijs/src/app/main/main.component.html
@@ -16,15 +16,16 @@ <h1 ng-doc-text>
         </div>
         <div class="greeting-shields">
           <a href="https://www.npmjs.com/package/@klerick/ng-pixijs" target="_blank">
-            <img src="https://img.shields.io/npm/v/@klerick/ng-pixijs.svg?style=for-the-badge" />
+            <img alt="NPM" src="https://img.shields.io/npm/v/@klerick/ng-pixijs.svg?style=for-the-badge" />
           </a>
 
           <a href="https://github.com/klerick/ng-pixijs/stargazers" target="_blank">
-            <img src="https://img.shields.io/github/stars/klerick/ng-pixijs?style=for-the-badge" />
+            <img alt="STARS" src="https://img.shields.io/github/stars/klerick/ng-pixijs?style=for-the-badge" />
           </a>
 
           <a href="https://github.com/klerick/ng-pixijs/blob/main/LICENSE" target="_blank">
             <img
+              alt="LICENSE"
               src="https://img.shields.io/github/license/klerick/ng-pixijs.svg?style=for-the-badge" />
           </a>
         </div>
diff --git a/apps/example-ng-pixijs/src/app/main/main.component.ts b/apps/example-ng-pixijs/src/app/main/main.component.ts
@@ -1,4 +1,4 @@
-import { ChangeDetectionStrategy, Component, inject, input, PLATFORM_ID } from '@angular/core';
+import { ChangeDetectionStrategy, Component, inject, PLATFORM_ID } from '@angular/core';
 import { CommonModule, isPlatformBrowser } from '@angular/common';
 import { NgDocButtonComponent, NgDocTextComponent } from '@ng-doc/ui-kit';
 import { RouterLink } from '@angular/router';
diff --git a/apps/example-ng-pixijs/src/app/pixijs-elements/bg-stage/bg-stage.component.ts b/apps/example-ng-pixijs/src/app/pixijs-elements/bg-stage/bg-stage.component.ts
@@ -1,4 +1,4 @@
-import { ChangeDetectionStrategy, Component, CUSTOM_ELEMENTS_SCHEMA, inject } from '@angular/core';
+import { ChangeDetectionStrategy, Component, CUSTOM_ELEMENTS_SCHEMA } from '@angular/core';
 import { CommonModule } from '@angular/common';
 import { PixiComponent, PixiContainer } from '@klerick/ng-pixijs';
 import { Container } from 'pixi.js';
diff --git a/apps/example-ng-pixijs/src/app/pixijs-elements/main-bg/main-bg.directive.ts b/apps/example-ng-pixijs/src/app/pixijs-elements/main-bg/main-bg.directive.ts
@@ -1,6 +1,6 @@
 import { Directive, inject } from '@angular/core';
 import { injectAutoEffect, OnPixiInit, PixiComponent, PixiElement } from '@klerick/ng-pixijs';
-import { Application, TilingSprite } from 'pixi.js';
+import { TilingSprite } from 'pixi.js';
 import { TEXTURE_BG } from '../../utils/providers';
 
 @PixiElement(TilingSprite)
diff --git a/apps/example-ng-pixijs/src/app/utils/providers/draw-rect.ts b/apps/example-ng-pixijs/src/app/utils/providers/draw-rect.ts
@@ -1,5 +1,5 @@
-import { Application, Graphics, GraphicsContext } from 'pixi.js';
-import { inject, InjectionToken } from '@angular/core';
+import { Graphics, GraphicsContext } from 'pixi.js';
+import { InjectionToken } from '@angular/core';
 
 
 function rectContextFactory(
diff --git a/eslint.config.js b/eslint.config.js
@@ -28,7 +28,18 @@ module.exports = [
   {
     files: ['**/*.ts', '**/*.tsx', '**/*.js', '**/*.jsx'],
     // Override or add rules here
-    rules: {},
+    rules: {
+      '@typescript-eslint/no-unused-expressions': [
+        'warn',
+        { "allowShortCircuit": true, "allowTernary": true }
+      ],
+      '@typescript-eslint/no-empty-function': [
+        'warn',
+        {
+          "allow": ["arrowFunctions"]
+        }
+      ]
+    },
   },
   {
     files: ['**/*.json'],
diff --git a/libs/ng-pixijs/eslint.config.js b/libs/ng-pixijs/eslint.config.js
@@ -26,15 +26,15 @@ module.exports = [
         'error',
         {
           type: 'attribute',
-          prefix: 'lib',
+          // prefix: 'lib',
           style: 'camelCase',
         },
       ],
       '@angular-eslint/component-selector': [
         'error',
         {
           type: 'element',
-          prefix: 'lib',
+          // prefix: 'lib',
           style: 'kebab-case',
         },
       ],
@@ -43,6 +43,17 @@ module.exports = [
   {
     files: ['**/*.html'],
     // Override or add rules here
-    rules: {},
+    rules: {
+      '@typescript-eslint/no-unused-expressions': [
+        'warn',
+        { "allowShortCircuit": true, "allowTernary": true }
+      ],
+      '@typescript-eslint/no-empty-function': [
+        'warn',
+        {
+          "allow": ["arrowFunctions"]
+        }
+      ]
+    },
   },
 ];
diff --git a/libs/ng-pixijs/package.json b/libs/ng-pixijs/package.json
@@ -5,7 +5,9 @@
 
   "peerDependencies": {
     "@angular/common": "^19.0.0",
-    "@angular/core": "^19.0.0"
+    "@angular/core": "^19.0.0",
+    "pixi.js": "^8.0.0",
+    "rxjs": "~7.8.0"
   },
   "files": [
     "**/*"
diff --git a/libs/ng-pixijs/src/lib/constants.ts b/libs/ng-pixijs/src/lib/constants.ts
@@ -7,7 +7,7 @@ import {
   Graphics,
   Application,
 } from 'pixi.js';
-import { InjectionToken, signal, Type, WritableSignal } from '@angular/core';
+import { InjectionToken, Type, WritableSignal } from '@angular/core';
 
 export const prefix = 'pixi' as const;
 
diff --git a/libs/ng-pixijs/src/lib/directive/index.ts b/libs/ng-pixijs/src/lib/directive/index.ts
@@ -1,4 +1,4 @@
-import { ElementRef, inject, Type } from '@angular/core';
+import { Type } from '@angular/core';
 import { getSelectorFrom, setCustomProps, setDefaultProps } from '../utils';
 import {
   CanvasElementStorage,
@@ -13,21 +13,16 @@ import { Container } from 'pixi.js';
 export function PixiContainer<
   T extends Type<PixiComponent<C>>,
   C extends Container = Container
->(isStage: boolean = false, element?: Type<C>): (target: T) => T {
+>(isStage = false, element?: Type<C>): (target: T) => T {
   return function (target: T): T {
     const selectors = getSelectorFrom(target, 'ɵcmp');
 
     for (const selector of selectors) {
       CanvasElementStorage.set(selector, element || Container);
       if (isStage) {
-        // const selectorArray = (
-        //   Array.isArray(target['ɵcmp']['selectors'])
-        //     ? target['ɵcmp']['selectors']
-        //     : [target['ɵcmp']['selectors']]
-        // )
-        // @ts-ignore
+        // @ts-expect-error patch Angular component
         target['ɵcmp']['selectors'] = target['ɵcmp']['selectors'].map((i) =>
-          // @ts-ignore
+          // @ts-expect-errore patch Angular component
           i.map((a) => 'stage-' + a)
         );
         CanvasElementStorage.set('stage-' + selector, target);
diff --git a/libs/ng-pixijs/src/lib/pixi-scene.component.ts b/libs/ng-pixijs/src/lib/pixi-scene.component.ts
@@ -6,11 +6,11 @@ import {
   HostListener,
   inject,
   input,
-  OnDestroy, PLATFORM_ID,
+  OnDestroy,
   signal,
   viewChild
 } from '@angular/core';
-import { CommonModule, DOCUMENT, isPlatformServer } from '@angular/common';
+import { CommonModule, DOCUMENT } from '@angular/common';
 import { Application, ApplicationOptions } from 'pixi.js';
 
 import {
@@ -76,10 +76,7 @@ export class PixiSceneComponent implements OnDestroy {
       })
       .then(() => {
         this.pixiJsInit.set(true);
-        this.application.ticker.add((time) => {
-          // console.log(time.deltaTime);
-          this.application.render()
-        });
+        this.application.ticker.add(() => this.application.render());
       });
   }
 
diff --git a/libs/ng-pixijs/src/lib/pixi-stage.directive.ts b/libs/ng-pixijs/src/lib/pixi-stage.directive.ts
@@ -26,7 +26,6 @@ import {
   CanvasElementStorage,
   IS_PIXIJS,
   PIXI_APPLICATION_INIT,
-  PIXI_ELEMENT_PROPS_NAME,
   PixiComponent,
 } from './constants';
 
diff --git a/libs/ng-pixijs/src/lib/service/pixijs.renderer.ts b/libs/ng-pixijs/src/lib/service/pixijs.renderer.ts
@@ -7,7 +7,7 @@ export class PixijsRenderer implements Renderer2 {
   constructor(
     private delegate: Renderer2,
     private canvasElementStorage: Map<string, Type<Container<ContainerChild>>>,
-    private debug: boolean = false
+    private debug = false
   ) {}
 
   destroyNode(node: any): void {
@@ -89,7 +89,6 @@ export class PixijsRenderer implements Renderer2 {
     parent: Container,
     newChild: Container,
     refChild: Container,
-    isMove?: boolean
   ): void {
     this.debug && console.log('insertBefore', parent, newChild, refChild);
     const index = parent.children.findIndex((i) => i.uid === refChild.uid);
diff --git a/libs/ng-pixijs/src/lib/signals.ts b/libs/ng-pixijs/src/lib/signals.ts
@@ -8,7 +8,7 @@ import {
 } from '@angular/core';
 
 export function assertInjector(
-  fn: Function,
+  fn: () => unknown,
   injector: Injector | undefined | null,
   runner?: () => any
 ) {
diff --git a/libs/ng-pixijs/src/lib/types.ts b/libs/ng-pixijs/src/lib/types.ts
@@ -1,4 +1,3 @@
-import { Container, Graphics, Sprite, Text, TilingSprite } from 'pixi.js';
 
 import {
   OnPixiInit,
diff --git a/libs/ng-pixijs/src/lib/utils.ts b/libs/ng-pixijs/src/lib/utils.ts
@@ -63,7 +63,7 @@ export function setDefaultProps(target: any): any | null {
       const destroyRef = inject(DestroyRef);
       const appInitSubscription = toObservable(appInit)
         .pipe(distinctUntilChanged(), filter(Boolean))
-        .subscribe((r) => instance[PIXI_ON_INIT_PROPS_NAME]());
+        .subscribe(() => instance[PIXI_ON_INIT_PROPS_NAME]());
       destroyRef.onDestroy(() => appInitSubscription.unsubscribe());
     }
     return instance;

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { ChangeDetectionStrategy, Component, inject, input, PLATFORM_ID } from '@angular/core';`
	`1`	`+import { ChangeDetectionStrategy, Component, inject, PLATFORM_ID } from '@angular/core';`
`2`	`2`	`import { CommonModule, isPlatformBrowser } from '@angular/common';`
`3`	`3`	`import { NgDocButtonComponent, NgDocTextComponent } from '@ng-doc/ui-kit';`
`4`	`4`	`import { RouterLink } from '@angular/router';`