Skip to content

Commit be1e73c

Browse files
committed
Fix linter warning
Signed-off-by: Tamal Saha <tamal@appscode.com>
1 parent e131082 commit be1e73c

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -402,7 +402,7 @@ lint: $(BUILD_DIRS)
402402
--env HTTPS_PROXY=$(HTTPS_PROXY) \
403403
--env GOFLAGS="-mod=vendor" \
404404
$(BUILD_IMAGE) \
405-
golangci-lint run --enable $(ADDTL_LINTERS) --timeout=10m --skip-files="generated.*\.go$\" --skip-dirs-use-default --skip-dirs=client,vendor
405+
golangci-lint run --enable $(ADDTL_LINTERS) --max-same-issues=100 --timeout=10m --skip-files="generated.*\.go$\" --skip-dirs-use-default --skip-dirs=client,vendor
406406

407407
$(BUILD_DIRS):
408408
@mkdir -p $@

pkg/manager/manager.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ func runManagerController(ctx context.Context, kubeConfig *rest.Config) error {
9797
WithCreateAgentInstallNamespace().
9898
BuildHelmAgentAddon()
9999
if err != nil {
100-
klog.Error("Failed to build agent: `%v`", err)
100+
klog.Errorf("Failed to build agent: `%v`", err)
101101
return err
102102
}
103103

@@ -106,7 +106,10 @@ func runManagerController(ctx context.Context, kubeConfig *rest.Config) error {
106106
return err
107107
}
108108

109-
go mgr.Start(ctx)
109+
err = mgr.Start(ctx)
110+
if err != nil {
111+
return err
112+
}
110113
<-ctx.Done()
111114

112115
return nil

0 commit comments

Comments
 (0)