Merge pull request #144 from kmatzen/fix/issue-94-sip-precheck

fix(#94): SIP pre-check before paid calls

Author: kmatzen

host/plugins/classic_phone.c

@@ -323,6 +323,18 @@ static void classic_phone_check_and_call(void) {
 
 static void classic_phone_start_call(void) {
     char log_msg[256];
+    int sip_registered = 0;
+
+    /* #94: For paid calls, check SIP registration before attempting */
+    if (!classic_phone_data.is_emergency_call && !classic_phone_data.is_card_call) {
+        millennium_sdk_get_sip_status(&sip_registered, NULL, 0);
+        if (sip_registered != 1) {
+            display_manager_set_text("SIP unavailable", "Check connection");
+            logger_warn_with_category("ClassicPhone", "Call refused - SIP not registered");
+            return;
+        }
+    }
+
     classic_phone_data.is_dialing = 1;
     strncpy(classic_phone_data.current_number, classic_phone_data.keypad_buffer, sizeof(classic_phone_data.current_number) - 1);
     classic_phone_data.current_number[sizeof(classic_phone_data.current_number) - 1] = '\0';

host/simulator.c

@@ -91,6 +91,7 @@ static void sim_parse_display(const char *message) {
 static int sim_call_pending  = 0;
 static int sim_call_active   = 0;
 static int sim_hangup_called = 0;
+static int sim_sip_registered = 1;  /* 1=registered (default), 0=unavailable */
 
 /* ── Millennium SDK stubs ──────────────────────────────────────────── */
 
@@ -242,6 +243,13 @@ void millennium_client_write_to_display(millennium_client_t *c, const char *m) {
     (void)c; (void)m;
 }
 
+/* SIP status stub: controlled by sip_registered scenario command (#94) */
+void millennium_sdk_get_sip_status(int *registered, char *last_error, size_t last_error_size) {
+    if (registered) *registered = sim_sip_registered;
+    if (last_error && last_error_size > 0) last_error[0] = '\0';
+    (void)last_error_size;
+}
+
 logger_level_t millennium_logger_parse_level(const char *s) { (void)s; return LOGGER_INFO; }
 void millennium_logger_set_level(logger_level_t l) { (void)l; }
 void millennium_logger_log(logger_level_t l, const char *m) { (void)l; (void)m; }
@@ -448,6 +456,8 @@ static int run_scenario(const char *path) {
         return 1;
     }
 
+    sim_sip_registered = 1;  /* default: SIP registered for each scenario */
+
     while (fgets(line, sizeof(line), f)) {
         line_num++;
         cmd = trim(line);
@@ -674,6 +684,14 @@ static int run_scenario(const char *path) {
             sim_drain_events();
         }
 
+        /* ── sip_registered <0|1> (#94) ──────────────────────────── */
+        else if (strncmp(cmd, "sip_registered ", 15) == 0) {
+            const char *p = cmd + 15;
+            while (*p == ' ') p++;
+            sim_sip_registered = (*p == '1') ? 1 : 0;
+            fprintf(stderr, "  sip_registered = %d\n", sim_sip_registered);
+        }
+
         /* ── config <key> <value> ──────────────────────────────── */
         else if (strncmp(cmd, "config ", 7) == 0) {
             char cfg_key[256];

host/tests/test_sip_unavailable.scenario

@@ -0,0 +1,21 @@
+# Test: #94 SIP pre-check — paid call refused when SIP not registered
+# sip_registered 0 simulates SIP unavailable
+
+sip_registered 0
+hook_up
+assert_state IDLE_UP
+assert_display Insert 50c
+
+# Insert coins and dial; call should be refused with "SIP unavailable"
+coin 25
+coin 25
+assert_display Have: 50c
+keys 5551234567
+assert_display SIP unavailable
+assert_display Check connection
+assert_state IDLE_UP
+
+# Coins and number remain in plugin state; display shows error until next update
+
+hook_down
+assert_state IDLE_DOWN

host/tests/unit_tests.c

@@ -41,6 +41,13 @@ void millennium_client_check_serial(millennium_client_t *c) { (void)c; }
 void millennium_client_serial_activity(millennium_client_t *c) { (void)c; }
 void list_audio_devices(void) {}
 
+/* SIP status stub (classic_phone calls this for paid-call pre-check) */
+void millennium_sdk_get_sip_status(int *registered, char *last_error, size_t last_error_size) {
+    if (registered) *registered = 1;
+    if (last_error && last_error_size > 0) last_error[0] = '\0';
+    (void)last_error_size;
+}
+
 /* Audio tone stubs */
 void audio_tones_init(void) {}
 void audio_tones_cleanup(void) {}