Skip to content

Commit 9312aee

Browse files
committed
Remove unnecessary test info
Signed-off-by: Ali Ok <aliok@redhat.com>
1 parent d640901 commit 9312aee

File tree

1 file changed

+11
-61
lines changed

1 file changed

+11
-61
lines changed

backends/pkg/eventmesh/v1/builder_test.go

Lines changed: 11 additions & 61 deletions
Original file line numberDiff line numberDiff line change
@@ -595,16 +595,6 @@ func TestBuildEventMesh(t *testing.T) {
595595
testingv1beta2.NewEventType("test-eventtype", "test-ns",
596596
testingv1beta2.WithEventTypeType("test-eventtype-type"),
597597
testingv1beta2.WithEventTypeReference(reference("messaging.knative.dev/v1", "InMemoryChannel", "test-ns", "test-imc")),
598-
// following fields are not used in any logic and simply returned
599-
testingv1beta2.WithEventTypeDescription("test-eventtype-description"),
600-
WithEventTypeUID("test-eventtype-uid"),
601-
WithEventTypeSchema(&apis.URL{
602-
Scheme: "http",
603-
Host: "test-eventtype-schema",
604-
}),
605-
WithEventTypeSchemaData("test-eventtype-schema-data"),
606-
testingv1beta2.WithEventTypeLabels(map[string]string{"test-eventtype-label": "foo"}),
607-
WithEventTypeAnnotations(map[string]string{"test-eventtype-annotation": "foo"}),
608598
),
609599
},
610600
triggers: []*eventingv1.Trigger{},
@@ -643,15 +633,9 @@ func TestBuildEventMesh(t *testing.T) {
643633
Brokers: []Broker{},
644634
EventTypes: []EventType{
645635
{
646-
Name: "test-eventtype",
647-
Namespace: "test-ns",
648-
Type: "test-eventtype-type",
649-
Uid: "test-eventtype-uid",
650-
Description: ptr.To("test-eventtype-description"),
651-
SchemaData: ptr.To("test-eventtype-schema-data"),
652-
SchemaURL: ptr.To("http://test-eventtype-schema"),
653-
Labels: map[string]string{"test-eventtype-label": "foo"},
654-
Annotations: map[string]string{"test-eventtype-annotation": "foo"},
636+
Name: "test-eventtype",
637+
Namespace: "test-ns",
638+
Type: "test-eventtype-type",
655639
Reference: &GroupKindNamespacedName{
656640
Group: "messaging.knative.dev",
657641
Kind: "InMemoryChannel",
@@ -678,30 +662,9 @@ func TestBuildEventMesh(t *testing.T) {
678662
eventTypes: []*eventingv1beta2.EventType{
679663
testingv1beta2.NewEventType("test-eventtype", "test-ns",
680664
testingv1beta2.WithEventTypeType("test-eventtype-type"),
681-
// following fields are not used in any logic and simply returned
682-
testingv1beta2.WithEventTypeDescription("test-eventtype-description"),
683-
WithEventTypeUID("test-eventtype-uid"),
684-
WithEventTypeSchema(&apis.URL{
685-
Scheme: "http",
686-
Host: "test-eventtype-schema",
687-
}),
688-
WithEventTypeSchemaData("test-eventtype-schema-data"),
689-
testingv1beta2.WithEventTypeLabels(map[string]string{"test-eventtype-label": "foo"}),
690-
WithEventTypeAnnotations(map[string]string{"test-eventtype-annotation": "foo"}),
691665
),
692666
testingv1beta2.NewEventType("test-eventtype-used-in-source", "test-ns",
693667
testingv1beta2.WithEventTypeType("dev.knative.apiserver.resource.add"),
694-
// TODO: remove these props
695-
// following fields are not used in any logic and simply returned
696-
testingv1beta2.WithEventTypeDescription("test-eventtype-description"),
697-
WithEventTypeUID("test-eventtype-used-in-source-uid"),
698-
WithEventTypeSchema(&apis.URL{
699-
Scheme: "http",
700-
Host: "test-eventtype-schema",
701-
}),
702-
WithEventTypeSchemaData("test-eventtype-schema-data"),
703-
testingv1beta2.WithEventTypeLabels(map[string]string{"test-eventtype-label": "foo"}),
704-
WithEventTypeAnnotations(map[string]string{"test-eventtype-annotation": "foo"}),
705668
),
706669
},
707670
triggers: []*eventingv1.Trigger{},
@@ -750,29 +713,16 @@ func TestBuildEventMesh(t *testing.T) {
750713
Brokers: []Broker{},
751714
EventTypes: []EventType{
752715
{
753-
Name: "test-eventtype",
754-
Namespace: "test-ns",
755-
Type: "test-eventtype-type",
756-
Uid: "test-eventtype-uid",
757-
Description: ptr.To("test-eventtype-description"),
758-
SchemaData: ptr.To("test-eventtype-schema-data"),
759-
SchemaURL: ptr.To("http://test-eventtype-schema"),
760-
Labels: map[string]string{"test-eventtype-label": "foo"},
761-
Annotations: map[string]string{"test-eventtype-annotation": "foo"},
762-
Reference: nil,
763-
ConsumedBy: []string{},
716+
Name: "test-eventtype",
717+
Namespace: "test-ns",
718+
Type: "test-eventtype-type",
719+
ConsumedBy: []string{},
764720
},
765721
{
766-
Name: "test-eventtype-used-in-source",
767-
Namespace: "test-ns",
768-
Type: "dev.knative.apiserver.resource.add",
769-
Uid: "test-eventtype-used-in-source-uid",
770-
Description: ptr.To("test-eventtype-description"),
771-
SchemaData: ptr.To("test-eventtype-schema-data"),
772-
SchemaURL: ptr.To("http://test-eventtype-schema"),
773-
Labels: map[string]string{"test-eventtype-label": "foo"},
774-
Annotations: map[string]string{"test-eventtype-annotation": "foo"},
775-
ConsumedBy: []string{},
722+
Name: "test-eventtype-used-in-source",
723+
Namespace: "test-ns",
724+
Type: "dev.knative.apiserver.resource.add",
725+
ConsumedBy: []string{},
776726
},
777727
},
778728
Subscribables: make([]Subscribable, 0),

0 commit comments

Comments
 (0)