Skip to content

Commit 10995fd

Browse files
upgrade to latest dependencies (#114)
Signed-off-by: Knative Automation <automation@knative.team>
1 parent 668a374 commit 10995fd

File tree

6 files changed

+27
-14
lines changed

6 files changed

+27
-14
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ require (
1616
k8s.io/client-go v11.0.1-0.20190805182717-6502b5e7b1b5+incompatible
1717
k8s.io/code-generator v0.18.8
1818
k8s.io/kube-openapi v0.0.0-20200410145947-bcb3869e6f29
19-
knative.dev/pkg v0.0.0-20200922164940-4bf40ad82aab
19+
knative.dev/pkg v0.0.0-20201026165741-2f75016c1368
2020
knative.dev/test-infra v0.0.0-20200921012245-37f1a12adbd3
2121
)
2222

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1818,8 +1818,8 @@ knative.dev/pkg v0.0.0-20200515002500-16d7b963416f/go.mod h1:tMOHGbxtRz8zYFGEGpV
18181818
knative.dev/pkg v0.0.0-20200528142800-1c6815d7e4c9/go.mod h1:QgNZTxnwpB/oSpNcfnLVlw+WpEwwyKAvJlvR3hgeltA=
18191819
knative.dev/pkg v0.0.0-20200711004937-22502028e31a/go.mod h1:AqAJV6rYi8IGikDjJ/9ZQd9qKdkXVlesVnVjwx62YB8=
18201820
knative.dev/pkg v0.0.0-20200909174550-69fcf75ee47d/go.mod h1:q+4+Cm768P6vsAvsD9J+cZ1hoy4aHyHSfRTvaFyPd3g=
1821-
knative.dev/pkg v0.0.0-20200922164940-4bf40ad82aab h1:4Q+sGqdN4ecLPZnIJcLDdQArEE9oOtRYiU2J6NPCCjU=
1822-
knative.dev/pkg v0.0.0-20200922164940-4bf40ad82aab/go.mod h1:MCyt5KqLaai6ENUitOgRAQsu7Gw7cAIIiXQ2IS+O0NI=
1821+
knative.dev/pkg v0.0.0-20201026165741-2f75016c1368 h1:KzDx2IerB4km4TG4PunacQvuSeWv4TJXTzjZ3ryKZ9o=
1822+
knative.dev/pkg v0.0.0-20201026165741-2f75016c1368/go.mod h1:MCyt5KqLaai6ENUitOgRAQsu7Gw7cAIIiXQ2IS+O0NI=
18231823
knative.dev/test-infra v0.0.0-20200407185800-1b88cb3b45a5/go.mod h1:xcdUkMJrLlBswIZqL5zCuBFOC22WIPMQoVX1L35i0vQ=
18241824
knative.dev/test-infra v0.0.0-20200505052144-5ea2f705bb55/go.mod h1:WqF1Azka+FxPZ20keR2zCNtiQA1MP9ZB4BH4HuI+SIU=
18251825
knative.dev/test-infra v0.0.0-20200513011557-d03429a76034/go.mod h1:aMif0KXL4g19YCYwsy4Ocjjz5xgPlseYV+B95Oo4JGE=

pkg/client/injection/reconciler/discovery/v1alpha1/clusterducktype/reconciler.go

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/knative.dev/pkg/codegen/cmd/injection-gen/generators/reconciler_reconciler.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -603,15 +603,15 @@ func (r *reconcilerImpl) updateFinalizersFiltered(ctx {{.contextContext|raw}}, r
603603
patcher := r.Client.{{.group}}{{.version}}().{{.type|apiGroup}}(resource.Namespace)
604604
{{end}}
605605
resourceName := resource.Name
606-
resource, err = patcher.Patch(ctx, resourceName, {{.typesMergePatchType|raw}}, patch, {{.metav1PatchOptions|raw}}{})
606+
updated, err := patcher.Patch(ctx, resourceName, {{.typesMergePatchType|raw}}, patch, {{.metav1PatchOptions|raw}}{})
607607
if err != nil {
608-
r.Recorder.Eventf(resource, {{.corev1EventTypeWarning|raw}}, "FinalizerUpdateFailed",
608+
r.Recorder.Eventf(existing, {{.corev1EventTypeWarning|raw}}, "FinalizerUpdateFailed",
609609
"Failed to update finalizers for %q: %v", resourceName, err)
610610
} else {
611-
r.Recorder.Eventf(resource, {{.corev1EventTypeNormal|raw}}, "FinalizerUpdate",
611+
r.Recorder.Eventf(updated, {{.corev1EventTypeNormal|raw}}, "FinalizerUpdate",
612612
"Updated %q finalizers", resource.GetName())
613613
}
614-
return resource, err
614+
return updated, err
615615
}
616616
617617
func (r *reconcilerImpl) setFinalizerIfFinalizer(ctx {{.contextContext|raw}}, resource *{{.type|raw}}) (*{{.type|raw}}, error) {

vendor/knative.dev/pkg/injection/sharedmain/main.go

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,16 @@ func MainWithConfig(ctx context.Context, component string, cfg *rest.Config, cto
225225
cfg.Burst = len(ctors) * rest.DefaultBurst
226226
}
227227

228-
ctx = EnableInjectionOrDie(ctx, cfg)
228+
// Respect user provided settings, but if omitted customize the default behavior.
229+
if cfg.QPS == 0 {
230+
cfg.QPS = rest.DefaultQPS
231+
}
232+
if cfg.Burst == 0 {
233+
cfg.Burst = rest.DefaultBurst
234+
}
235+
ctx = injection.WithConfig(ctx, cfg)
236+
237+
ctx, informers := injection.Default.SetupInformers(ctx, cfg)
229238

230239
logger, atomicLevel := SetupLoggerOrDie(ctx, component)
231240
defer flush(logger)
@@ -278,7 +287,11 @@ func MainWithConfig(ctx context.Context, component string, cfg *rest.Config, cto
278287
return wh.Run(ctx.Done())
279288
})
280289
}
281-
290+
// Start the injection clients and informers.
291+
logging.FromContext(ctx).Info("Starting informers...")
292+
if err := controller.StartInformers(ctx.Done(), informers...); err != nil {
293+
logging.FromContext(ctx).Fatalw("Failed to start informers", zap.Error(err))
294+
}
282295
// Wait for webhook informers to sync.
283296
if wh != nil {
284297
wh.InformersHaveSynced()

vendor/modules.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -884,7 +884,7 @@ k8s.io/utils/buffer
884884
k8s.io/utils/integer
885885
k8s.io/utils/pointer
886886
k8s.io/utils/trace
887-
# knative.dev/pkg v0.0.0-20200922164940-4bf40ad82aab
887+
# knative.dev/pkg v0.0.0-20201026165741-2f75016c1368
888888
## explicit
889889
knative.dev/pkg/apis
890890
knative.dev/pkg/apis/duck

0 commit comments

Comments
 (0)