Skip to content

Commit 3af2327

Browse files
committed
Run binfmt installation
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
1 parent bcf4237 commit 3af2327

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

hack/build.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,5 @@ trap 'err_report $LINENO' ERR
1818

1919
build_transform_jsonata_image || exit $?
2020

21-
build_integration_images || exit $?
21+
# TODO: To enable the builds in build-tests we need to disable the "push"
22+
# build_integration_images || exit $?

hack/common.sh

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,20 @@ set -euo pipefail
44

55
export TAG=${TAG:-$(git rev-parse HEAD)}
66

7-
export KO_DOCKER_REPO="${KO_DOCKER_REPO:-kind.local}"
8-
export TRANSFORM_JSONATA_IMAGE_WITH_TAG="${KO_DOCKER_REPO}/transform-jsonata:${TAG}"
7+
export TRANSFORM_JSONATA_IMAGE_WITH_TAG="${KO_DOCKER_REPO:-kind.local}/transform-jsonata:${TAG}"
98

109
[[ ! -v REPO_ROOT_DIR ]] && REPO_ROOT_DIR="$(git rev-parse --show-toplevel)"
1110
readonly REPO_ROOT_DIR
1211

1312
export TRANSFORM_JSONATA_DIR="${REPO_ROOT_DIR}/transform-jsonata"
1413

14+
1515
function build_transform_jsonata_image() {
1616

17+
if (( ${IS_PROW:-0} )); then
18+
docker run --privileged --rm tonistiigi/binfmt --install all binfmt
19+
fi
20+
1721
docker info
1822
docker buildx ls
1923

test/presubmit-tests.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22

33
# shellcheck disable=SC1090
44
source "$(go run knative.dev/hack/cmd/script presubmit-tests.sh)"
5-
source "$(go run knative.dev/hack/cmd/script infra-library.sh)"
65

76
function build_tests() {
87
header "Running build tests"
8+
export IS_PROW
99
./hack/build.sh || fail_test "build tests failed"
1010
}
1111

0 commit comments

Comments
 (0)