Skip to content

Commit 32ac055

Browse files
authored
fix: update minimum k8 version to fix timeouts (#602)
The default minimum k8 version for knative changed and is listed here: https://github.com/knative/pkg/blob/main/version/version.go#L36 Bump up k8, kind, and minikube versions and a comment with the link above. Add versions to the main `README.md` and fix a broken link. Issues #601 #600. Signed-off-by: Stanislav Jakuschevskij <[email protected]>
1 parent 9938885 commit 32ac055

File tree

3 files changed

+29
-15
lines changed

3 files changed

+29
-15
lines changed

README.md

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,11 @@
66

77
## Getting Started
88

9-
Note: In order to use the `quickstart` plugin, you must install the [Kubernetes CLI `kubectl`](https://kubernetes.io/docs/tasks/tools/install-kubectl) and either [`kind`](https://kind.sigs.k8s.io/docs/user/quick-start) or [`minikube`](https://minikube.sigs.k8s.io/docs/start/).
9+
In order to use the `quickstart` plugin, you must install:
10+
11+
* [Kubernetes CLI `kubectl`](https://kubernetes.io/docs/tasks/tools/install-kubectl) (1.32.0 or later).
12+
* [`kind`](https://kind.sigs.k8s.io/docs/user/quick-start) (0.26 or later).
13+
* Or [`minikube`](https://minikube.sigs.k8s.io/docs/start/) (1.35 or later).
1014

1115
### Installation
1216

@@ -16,15 +20,15 @@ There are two ways to run `kn quickstart`:
1620

1721
1. You can run it standalone, just put it on your system path and make sure it is executable.
1822
2. You can install it as a plugin of the `kn` client to run:
19-
* Follow the [documentation](https://github.com/knative/client/blob/main/docs/README.md#installing-kn) to install `kn client` if you don't have it
20-
* Copy the `kn-quickstart` binary to a directory on your `PATH` (for example, `/usr/local/bin`) and make sure its filename is `kn-quickstart`
21-
* Run `kn plugin list` to verify that the `kn-quickstart` plugin is installed successfully
23+
* Follow the [documentation](https://github.com/knative/client/blob/main/docs/README.md#installing-kn) to install `kn client` if you don't have it.
24+
* Copy the `kn-quickstart` binary to a directory on your `PATH` (for example, `/usr/local/bin`) and make sure its filename is `kn-quickstart`.
25+
* Run `kn plugin list` to verify that the `kn-quickstart` plugin is installed successfully.
2226

2327
After the plugin is installed, you can use `kn quickstart` to run its related subcommands.
2428

2529
## Usage
2630

27-
```
31+
```txt
2832
Get up and running with a local Knative environment
2933
3034
Usage:
@@ -47,7 +51,7 @@ Use "kn-quickstart [command] --help" for more information about a command.
4751

4852
Set up a local Knative cluster using [KinD](https://kind.sigs.k8s.io/):
4953

50-
``` bash
54+
```bash
5155
kn quickstart kind
5256
```
5357

@@ -59,7 +63,6 @@ Kind can also be configured with an [extra mount](https://kind.sigs.k8s.io/docs/
5963
kn quickstart kind --extraMountHostPath /home/myname/foo --extraMountContainerPath /foo
6064
```
6165

62-
6366
### Quickstart with Minikube
6467

6568
Set up a local Knative cluster using [Minikube](https://minikube.sigs.k8s.io/):
@@ -76,7 +79,7 @@ minikube tunnel --profile minikube-knative
7679

7780
## Building from Source
7881

79-
You must [set up your development environment](https://github.com/knative/client/blob/master/docs/DEVELOPMENT.md#prerequisites) before you build `kn-plugin-quickstart`.
82+
You must [set up your development environment](https://github.com/knative/client/blob/main/DEVELOPMENT.md#prerequisites) before you build `kn-plugin-quickstart`.
8083

8184
Once you've set up your development environment, you can build the plugin by running the following commands:
8285

@@ -112,9 +115,8 @@ docker push localhost:5001/helloworld-go:latest
112115

113116
You can grab the latest nightly binary executable for:
114117

115-
- [macOS](https://storage.googleapis.com/knative-nightly/kn-plugin-quickstart/latest/kn-quickstart-darwin-amd64)
116-
- [Linux](https://storage.googleapis.com/knative-nightly/kn-plugin-quickstart/latest/kn-quickstart-linux-amd64)
117-
- [Windows](https://storage.googleapis.com/knative-nightly/kn-plugin-quickstart/latest/kn-quickstart-windows-amd64.exe)
118+
* [macOS](https://storage.googleapis.com/knative-nightly/kn-plugin-quickstart/latest/kn-quickstart-darwin-amd64)
119+
* [Linux](https://storage.googleapis.com/knative-nightly/kn-plugin-quickstart/latest/kn-quickstart-linux-amd64)
120+
* [Windows](https://storage.googleapis.com/knative-nightly/kn-plugin-quickstart/latest/kn-quickstart-windows-amd64.exe)
118121

119122
Add the binary to the system PATH and ensure that it is executable.
120-

pkg/kind/kind.go

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,13 @@ import (
3333
"knative.dev/kn-plugin-quickstart/pkg/install"
3434
)
3535

36-
var kubernetesVersion = "kindest/node:v1.31.6"
36+
// NOTE: If you are changing kubernetesVersion and kindVersion, please also
37+
// update the kubectl and kind versions listed here:
38+
// https://github.com/knative-extensions/kn-plugin-quickstart/blob/main/README.md
39+
//
40+
// NOTE: Latest minimum k8 version needed for knative can be found here:
41+
// https://github.com/knative/pkg/blob/main/version/version.go#L36
42+
var kubernetesVersion = "kindest/node:v1.32.0"
3743
var clusterName string
3844
var kindVersion = 0.26
3945
var container_reg_name = "kind-registry"

pkg/minikube/minikube.go

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,16 @@ import (
2626
"knative.dev/kn-plugin-quickstart/pkg/install"
2727
)
2828

29+
// NOTE: If you are changing kubernetesVersion and kindVersion, please also
30+
// update the kubectl and kind versions listed here:
31+
// https://github.com/knative-extensions/kn-plugin-quickstart/blob/main/README.md
32+
//
33+
// NOTE: Latest minimum k8 version needed for knative can be found here:
34+
// https://github.com/knative/pkg/blob/main/version/version.go#L36
35+
var kubernetesVersion = "1.32.0"
2936
var clusterName string
30-
var kubernetesVersion = "1.31.6"
3137
var clusterVersionOverride bool
32-
var minikubeVersion = 1.34
38+
var minikubeVersion = 1.35
3339
var cpus = "3"
3440
var memory = "3072"
3541
var installKnative = true

0 commit comments

Comments
 (0)