fixing version info (#115)

Author: psschwei

hack/build-flags.sh

@@ -21,7 +21,7 @@ function build_flags() {
   if [[ -z "${version}" ]]; then
     # Get the commit, excluding any tags but keeping the "dirty" flag
     local commit="$(git describe --always --dirty --match '^$')"
-    [[ -n "${commit}" ]] || abort "error getting the current commit"
+    [[ -n "${commit}" ]] || (echo "error getting the current commit" && exit 1)
     version="v$(date +%Y%m%d)-local-${commit}"
   fi
 

hack/release.sh

@@ -17,26 +17,35 @@
 # Documentation about this script and how to use it can be found
 # at https://github.com/knative/hack
 
-source $(dirname $0)/../vendor/knative.dev/hack/release.sh
-
 PLUGIN="kn-quickstart"
+VERSION_PACKAGE="knative.dev/kn-plugin-quickstart/internal/command"
+
+source $(dirname $0)/../vendor/knative.dev/hack/release.sh
+source $(dirname $0)/build-flags.sh
 
 function build_release() {
+  local ld_flags="$(build_flags $(dirname $0)/..)"
+  local version="${TAG}"
+  # Use vYYYYMMDD-<hash>-local for the version string, if not passed.
+  [[ -z "${version}" ]] && version="v${BUILD_TAG}-local"
+
   export GO111MODULE=on
   export CGO_ENABLED=0
   echo "🚧 🐧 Building for Linux (amd64)"
-  GOOS=linux GOARCH=amd64 go build -mod=vendor -o ./${PLUGIN}-linux-amd64 ./cmd/...
+  GOOS=linux GOARCH=amd64 go build -mod=vendor -ldflags "${ld_flags}" -o ./${PLUGIN}-linux-amd64 ./cmd/...
   echo "🚧 💪 Building for Linux (arm64)"
-  GOOS=linux GOARCH=arm64 go build -mod=vendor -o ./${PLUGIN}-linux-arm64 ./cmd/...
+  GOOS=linux GOARCH=arm64 go build -mod=vendor -ldflags "${ld_flags}" -o ./${PLUGIN}-linux-arm64 ./cmd/...
   echo "🚧 🍏 Building for macOS"
-  GOOS=darwin GOARCH=amd64 go build -mod=vendor -o ./${PLUGIN}-darwin-amd64 ./cmd/...
+  GOOS=darwin GOARCH=amd64 go build -mod=vendor -ldflags "${ld_flags}" -o ./${PLUGIN}-darwin-amd64 ./cmd/...
+  echo "🚧 🍎 Building for macOS (arm64)"
+  GOOS=darwin GOARCH=arm64 go build -mod=vendor -ldflags "${ld_flags}" -o ./${PLUGIN}-darwin-arm64 ./cmd/...
   echo "🚧 🎠 Building for Windows"
-  GOOS=windows GOARCH=amd64 go build -mod=vendor -o ./${PLUGIN}-windows-amd64.exe ./cmd/...
+  GOOS=windows GOARCH=amd64 go build -mod=vendor -ldflags "${ld_flags}" -o ./${PLUGIN}-windows-amd64.exe ./cmd/...
   echo "🚧 Z  Building for Linux(s390x)"
-  GOOS=linux GOARCH=s390x go build -mod=vendor -o ./${PLUGIN}-linux-s390x ./cmd/...
+  GOOS=linux GOARCH=s390x go build -mod=vendor -ldflags "${ld_flags}" -o ./${PLUGIN}-linux-s390x ./cmd/...
   echo "🚧 P  Building for Linux (ppc64le)"
-  GOOS=linux GOARCH=ppc64le go build -mod=vendor -o ./${PLUGIN}-linux-ppc64le ./cmd/...
-  ARTIFACTS_TO_PUBLISH="${PLUGIN}-darwin-amd64 ${PLUGIN}-linux-amd64 ${PLUGIN}-linux-arm64 ${PLUGIN}-windows-amd64.exe ${PLUGIN}-linux-s390x ${PLUGIN}-linux-ppc64le"
+  GOOS=linux GOARCH=ppc64le go build -mod=vendor -ldflags "${ld_flags}" -o ./${PLUGIN}-linux-ppc64le ./cmd/...
+  ARTIFACTS_TO_PUBLISH="${PLUGIN}-darwin-amd64 ${PLUGIN}-darwin-arm64 ${PLUGIN}-linux-amd64 ${PLUGIN}-linux-arm64 ${PLUGIN}-windows-amd64.exe ${PLUGIN}-linux-s390x ${PLUGIN}-linux-ppc64le"
   sha256sum ${ARTIFACTS_TO_PUBLISH} > checksums.txt
   ARTIFACTS_TO_PUBLISH="${ARTIFACTS_TO_PUBLISH} checksums.txt"
   echo "🧮     Checksum:"