Skip to content

Commit e9a3897

Browse files
require manual minikube tunnel on linux too (#302)
Signed-off-by: Paul S. Schweigert <[email protected]> Co-authored-by: Paul S. Schweigert <[email protected]>
1 parent a30fe81 commit e9a3897

File tree

2 files changed

+6
-21
lines changed

2 files changed

+6
-21
lines changed

pkg/install/install.go

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ package install
1717
import (
1818
"fmt"
1919
"os/exec"
20-
"runtime"
2120
"strings"
2221
"time"
2322
)
@@ -104,17 +103,6 @@ func KourierMinikube() error {
104103

105104
fmt.Println(" Domain DNS set up...")
106105

107-
// For windows and mac users, do not automatically spawn a tunnel
108-
// Instead, they will be directed to create one manually after
109-
// the plugin finishes
110-
if runtime.GOOS != "window" && runtime.GOOS != "darwin" {
111-
tunnel := exec.Command("minikube", "tunnel", "--profile", "knative")
112-
if err := tunnel.Start(); err != nil {
113-
return fmt.Errorf("tunnel: %w", err)
114-
}
115-
fmt.Println(" Minikube tunnel...")
116-
}
117-
118106
fmt.Println(" Finished configuring Kourier")
119107
return nil
120108
}

pkg/minikube/minikube.go

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ import (
1919
"os"
2020
"os/exec"
2121
"regexp"
22-
"runtime"
2322
"strconv"
2423
"strings"
2524
"time"
@@ -61,14 +60,12 @@ func SetUp(name, kVersion string, installServing, installEventing bool) error {
6160
if err := createMinikubeCluster(); err != nil {
6261
return fmt.Errorf("creating cluster: %w", err)
6362
}
64-
if runtime.GOOS == "darwin" || runtime.GOOS == "windows" {
65-
fmt.Print("\n")
66-
fmt.Println("To finish setting up networking for minikube, run the following command in a separate terminal window:")
67-
fmt.Println(" minikube tunnel --profile knative")
68-
fmt.Println("The tunnel command must be running in a terminal window any time when using the knative quickstart environment.")
69-
fmt.Println("\nPress the Enter key to continue")
70-
fmt.Scanln()
71-
}
63+
fmt.Print("\n")
64+
fmt.Println("To finish setting up networking for minikube, run the following command in a separate terminal window:")
65+
fmt.Println(" minikube tunnel --profile knative")
66+
fmt.Println("The tunnel command must be running in a terminal window any time when using the knative quickstart environment.")
67+
fmt.Println("\nPress the Enter key to continue")
68+
fmt.Scanln()
7269

7370
if installServing {
7471
if err := install.Serving(); err != nil {

0 commit comments

Comments
 (0)