Skip to content

Elide endpoint probes when the set of services does not change #410

@mattmoor

Description

@mattmoor

A good example of this would be updating traffic: to change percentages (or @vagababov new gradual rollouts) where the set of services in generation: X and generation: X+1 are identical.

We get the former from oldGeneration and the latter from ing here: https://github.com/knative-sandbox/net-contour/blob/7bff03576e1c01114d47c0fdc58dac74a98115db/pkg/reconciler/contour/contour.go#L119

The simplest correct solution is that when the set of services is identical per visibility to elide the endpoint probe, but we could perhaps optimize more generally by excluding services present in both sets and simply eliding when that leaves the empty set 🤔

Metadata

Metadata

Assignees

No one assigned

    Labels

    lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.triage/acceptedIssues which should be fixed (post-triage)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions