Skip to content

Commit 31ec1a3

Browse files
evankandersonknative-prow-robot
authored andcommitted
Fix Dart service.yaml (indentation) and indicate that local dart is only needed for local development. (#477)
1 parent 6dc822e commit 31ec1a3

File tree

2 files changed

+20
-18
lines changed

2 files changed

+20
-18
lines changed

serving/samples/helloworld-dart/README.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,12 @@ that you can use for testing. It reads in the env variable `TARGET` and prints
77
## Prerequisites
88

99
* A Kubernetes cluster with Knative installed. Follow the
10-
[installation instructions](https://github.com/knative/docs/blob/master/install/README.md) if you need
11-
to create one.
10+
[installation instructions](https://github.com/knative/docs/blob/master/install/README.md)
11+
if you need to create one.
1212
* [Docker](https://www.docker.com) installed and running on your local machine,
1313
and a Docker Hub account configured (we'll use it for a container registry).
14-
* [dart-sdk](https://www.dartlang.org/tools/sdk#install) installed and configured.
14+
* [dart-sdk](https://www.dartlang.org/tools/sdk#install) installed and configured
15+
if you want to run the program locally.
1516

1617
## Recreating the sample code
1718

@@ -32,7 +33,8 @@ created using the following instructions.
3233
sdk: '>=2.0.0 <3.0.0'
3334
```
3435
35-
2. Install dependencies
36+
2. If you want to run locally, install dependencies. If you only want to run in
37+
Docker or Knative, you can skip this step.
3638
3739
```shell
3840
pub get
Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
apiVersion: serving.knative.dev/v1alpha1
2-
kind: Service
3-
metadata:
4-
name: helloworld-dart
5-
namespace: default
6-
spec:
7-
runLatest:
8-
configuration:
9-
revisionTemplate:
10-
spec:
11-
container:
12-
image: docker.io/{username}/helloworld-dart
13-
env:
14-
- name: TARGET
15-
value: "Dart Sample v1"
2+
kind: Service
3+
metadata:
4+
name: helloworld-dart
5+
namespace: default
6+
spec:
7+
runLatest:
8+
configuration:
9+
revisionTemplate:
10+
spec:
11+
container:
12+
image: docker.io/{username}/helloworld-dart
13+
env:
14+
- name: TARGET
15+
value: "Dart Sample v1"

0 commit comments

Comments
 (0)