Skip to content

Commit a78407d

Browse files
powellquiringknative-prow-robot
authored andcommitted
directory confusion missing readinessProbe config (#1733)
* typo * directory confusion missing readinessProbe config readinessProbe requires timeoutSeconds and failureThreshold are required close #1731 * fix indentation and remove duplicate codeblock * Consolidate 1 and 2
1 parent 82ba0af commit a78407d

File tree

3 files changed

+19
-23
lines changed

3 files changed

+19
-23
lines changed

docs/serving/knative-kubernetes-services.md

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ that are active when running Knative Serving.
3131
webhook ClusterIP 10.107.144.50 <none> 443/TCP 1h
3232
```
3333

34-
````
3534
3. To view the deployments in your cluster, use the following command:
3635

3736
```sh
@@ -41,14 +40,14 @@ that are active when running Knative Serving.
4140
This should return the following output:
4241

4342
```sh
44-
NAME DESIRED CURRENT UP-TO-DATE AVAILABLE AGE
45-
activator 1 1 1 1 1h
46-
autoscaler 1 1 1 1 1h
47-
controller 1 1 1 1 1h
48-
networking-certmanager 1 1 1 1 1h
49-
networking-istio 1 1 1 1 1h
50-
webhook 1 1 1 1 1h
51-
````
43+
NAME DESIRED CURRENT UP-TO-DATE AVAILABLE AGE
44+
activator 1 1 1 1 1h
45+
autoscaler 1 1 1 1 1h
46+
controller 1 1 1 1 1h
47+
networking-certmanager 1 1 1 1 1h
48+
networking-istio 1 1 1 1 1h
49+
webhook 1 1 1 1 1h
50+
```
5251

5352
These services and deployments are installed by the `serving.yaml` file during
5453
install. The next section describes their function.

docs/serving/samples/rest-api-go/README.md

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ like `AAPL`,`AMZN`, `GOOG`, `MSFT`, etc.
2525

2626
```shell
2727
git clone -b "{{< branch >}}" https://github.com/knative/docs knative-docs
28-
cd knative-docs/serving/samples/rest-api-go
28+
cd knative-docs
2929
```
3030

3131
## Setup
@@ -37,22 +37,17 @@ This sample uses Docker for both building and pushing.
3737

3838
To build and push to a container registry using Docker:
3939

40-
1. Move into the sample directory:
41-
42-
```shell
43-
cd $GOPATH/src/github.com/knative/docs
44-
```
45-
46-
2. Set your preferred container registry endpoint as an environment variable.
40+
1. From the `knative-docs` directory, run the following command to set your
41+
container registry endpoint as an environment variable.
42+
4743
This sample uses
4844
[Google Container Registry (GCR)](https://cloud.google.com/container-registry/):
49-
50-
45+
5146
```shell
5247
export REPO="gcr.io/<YOUR_PROJECT_ID>"
5348
```
5449

55-
3. Set up your container registry to make sure you are ready to push.
50+
1. Set up your container registry to make sure you are ready to push.
5651

5752
To push to GCR, you need to:
5853

@@ -67,21 +62,21 @@ To build and push to a container registry using Docker:
6762
If you are using a different container registry, you will want to follow the
6863
registry specific instructions for both setup and authorizing the image push.
6964

70-
4. Use Docker to build your application container:
65+
1. Use Docker to build your application container:
7166

7267
```shell
7368
docker build \
7469
--tag "${REPO}/rest-api-go" \
7570
--file docs/serving/samples/rest-api-go/Dockerfile .
7671
```
7772

78-
5. Push your container to a container registry:
73+
1. Push your container to a container registry:
7974

8075
```shell
8176
docker push "${REPO}/rest-api-go"
8277
```
8378

84-
6. Substitute the image reference path in the template with our published image
79+
1. Substitute the image reference path in the template with our published image
8580
path. The command below substitutes using the \${REPO} variable into a new
8681
file called `docs/serving/samples/rest-api-go/sample.yaml`.
8782

docs/serving/samples/rest-api-go/sample-template.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,3 +29,5 @@ spec:
2929
path: /
3030
initialDelaySeconds: 0
3131
periodSeconds: 3
32+
timeoutSeconds: 11
33+
failureThreshold: 3

0 commit comments

Comments
 (0)