Serving samples: add instructions to clone code (#1203)

* Serving Samples: add instructions to clone code

* added intro sentence, added space

* add specific branch for clone and fix codeblocks

* -b branchname and codeblocks

* point to branch + codeblocks

* -b branch + spacing

* branch and space

* branch and spaces

* forgot the -spring

* branch and spaces

* branch and spaces

* branch and spaces

* branch and spaces

* branch and spaces

* use a branch

* typo

* branch and space

* branch and spaces

* branch and spaces

* typo

* typo

* typo

* typo

* typo

* typo

* typo

* typo

* typo

* fix failing test

* try to fix error

* remove typo to fix build error

Author: mhamwala

docs/serving/samples/build-private-repo-go/README.md

@@ -8,8 +8,12 @@ This sample demonstrates:
 ## Before you begin
 
 - [Install Knative Serving](../../../install/README.md)
-- Create a local folder for this sample and download the files in this directory
-  into it.
+- Download a copy of the code:
+
+   ```shell
+   git clone -b "release-0.6" https://github.com/knative/docs knative-docs
+   cd knative-docs/serving/samples/build-private-repo-go
+   ```
 
 ## Setup
 
@@ -36,32 +40,32 @@ We are going to add to this an image pull Secret.
 1. Create your image pull Secret with the following command, replacing values as
    necessary:
 
-   ```shell
-   kubectl create secret docker-registry dockerhub-pull-secret \
-   --docker-server=https://index.docker.io/v1/ [email protected] \
-   --docker-username=<your-name> --docker-password=<your-pword>
-   ```
+    ```shell
+    kubectl create secret docker-registry dockerhub-pull-secret \
+    --docker-server=https://index.docker.io/v1/ [email protected] \
+    --docker-username=<your-name> --docker-password=<your-pword>
+    ```
 
    To learn more about Kubernetes pull Secrets, see
    [Creating a Secret in the cluster that holds your authorization token](https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/#create-a-secret-in-the-cluster-that-holds-your-authorization-token).
 
 2. Add the newly created `imagePullSecret` to your default service account by
    entering:
 
-   ```shell
-   kubectl edit serviceaccount default
-   ```
+    ```shell
+    kubectl edit serviceaccount default
+    ```
 
-   This will open the resource in your default text editor. Under `secrets:`,
-   add:
+    This will open the resource in your default text editor. Under `secrets:`,
+    add:
 
-   ```yaml
-   secrets:
-     - name: default-token-zd84v
-   # This is the secret we just created:
-   imagePullSecrets:
-     - name: dockerhub-pull-secret
-   ```
+    ```yaml
+    secrets:
+      - name: default-token-zd84v
+    # This is the secret we just created:
+    imagePullSecrets:
+      - name: dockerhub-pull-secret
+    ```
 
 ### 2. Configuring the build
 
@@ -147,9 +151,9 @@ kubectl create --filename build-bot.yaml
    [Kaniko build template](https://github.com/knative/build-templates/blob/master/kaniko/kaniko.yaml)
    by entering the following command:
 
-   ```shell
-   kubectl apply --filename https://raw.githubusercontent.com/knative/build-templates/master/kaniko/kaniko.yaml
-   ```
+    ```shell
+    kubectl apply --filename https://raw.githubusercontent.com/knative/build-templates/master/kaniko/kaniko.yaml
+    ```
 
 1. Open `manifest.yaml` and substitute your private DockerHub repository name
    for `REPLACE_ME`.
@@ -211,41 +215,41 @@ The sample code is in a private Github repository consisting of two files.
 
 1. `Dockerfile`
 
-   ```Dockerfile
-   # Use golang:alpine to optimize the image size.
-   # See https://hub.docker.com/_/golang/ for more information
-   # about the difference between golang and golang:alpine.
-   FROM golang:alpine
+    ```Dockerfile
+    # Use golang:alpine to optimize the image size.
+    # See https://hub.docker.com/_/golang/ for more information
+    # about the difference between golang and golang:alpine.
+    FROM golang:alpine
 
-   ENV GOPATH /go
+    ENV GOPATH /go
 
-   ADD . /go/src/github.com/dewitt/knative-build
+    ADD . /go/src/github.com/dewitt/knative-build
 
-   RUN CGO_ENABLED=0 go build github.com/dewitt/knative-build
+    RUN CGO_ENABLED=0 go build github.com/dewitt/knative-build
 
-   ENTRYPOINT ["knative-build"]
-   ```
+    ENTRYPOINT ["knative-build"]
+    ```
 
 1. `main.go`
 
-   ```go
-   package main
+    ```go
+    package main
 
-   import (
-   "
-   "
-   )
+    import (
+    "
+    "
+    )
 
-   const (
+    const (
    	   port = ":8080"
-   )
+    )
 
-   func helloWorld(w http.ResponseWriter, r *http.Request) {
-   )
-   }
+    func helloWorld(w http.ResponseWriter, r *http.Request) {
+    )
+    }
 
-   func main() {
-   )
-   )
-   }
-   ```
+    func main() {
+    )
+    )
+    }
+    ```

docs/serving/samples/gitwebhook-go/README.md

@@ -1,7 +1,7 @@
 A handler written in Go that demonstrates interacting with GitHub through a
 webhook.
 
-## Prerequisites
+## Before you begin
 
 - A Kubernetes cluster with Knative installed. Follow the
   [installation instructions](../../../install/README.md) if you need to create
@@ -13,18 +13,25 @@ webhook.
 
 ## Build the sample code
 
+1. Download a copy of the code:
+
+    ```shell
+    git clone -b "release-0.6" https://github.com/knative/docs knative-docs
+    cd knative-docs/serving/samples/gitwebhook-go
+    ```
+   
 1. Use Docker to build a container image for this service. Replace `username`
    with your Docker Hub username in the following commands.
 
-```shell
-export DOCKER_HUB_USERNAME=username
+    ```shell
+    export DOCKER_HUB_USERNAME=username
 
-# Build the container, run from the project folder
-docker build -t ${DOCKER_HUB_USERNAME}/gitwebhook-go .
+    # Build the container, run from the project folder
+    docker build -t ${DOCKER_HUB_USERNAME}/gitwebhook-go .
 
-# Push the container to the registry
-docker push ${DOCKER_HUB_USERNAME}/gitwebhook-go
-```
+    # Push the container to the registry
+    docker push ${DOCKER_HUB_USERNAME}/gitwebhook-go
+    ```
 
 1. Create a secret that holds two values from GitHub, a personal access token
    used to make API requests to GitHub, and a webhook secret, used to validate
@@ -36,38 +43,36 @@ docker push ${DOCKER_HUB_USERNAME}/gitwebhook-go
       personal access token.
    1. Base64 encode the access token:
 
-      ```shell
-      $ echo -n "45d382d4a9a93c453fb7c8adc109121e7c29fa3ca" | base64
-      NDVkMzgyZDRhOWE5M2M0NTNmYjdjOGFkYzEwOTEyMWU3YzI5ZmEzY2E=
-      ```
+       ```shell
+       $ echo -n "45d382d4a9a93c453fb7c8adc109121e7c29fa3ca" | base64
+       NDVkMzgyZDRhOWE5M2M0NTNmYjdjOGFkYzEwOTEyMWU3YzI5ZmEzY2E=
+       ```
 
    1. Copy the encoded access token into `github-secret.yaml` next to
       `personalAccessToken:`.
    1. Create a webhook secert value unique to this sample, base64 encode it, and
       copy it into `github-secret.yaml` next to `webhookSecret:`:
 
-      ```shell
-      $ echo -n "mygithubwebhooksecret" | base64
-      bXlnaXRodWJ3ZWJob29rc2VjcmV0
-      ```
+       ```shell
+       $ echo -n "mygithubwebhooksecret" | base64
+       bXlnaXRodWJ3ZWJob29rc2VjcmV0
+       ```
 
    1. Apply the secret to your cluster:
 
-      ```shell
-      kubectl apply --filename github-secret.yaml
-      ```
+       ```shell
+       kubectl apply --filename github-secret.yaml
+       ```
 
 1. Next, update the `service.yaml` file in the project to reference the tagged
    image from step 1.
 
-```yaml
-apiVersion: serving.knative.dev/v1alpha1
-kind: Service
-metadata:
-  name: gitwebhook
-  namespace: default
-spec:
-  template:
+    ```yaml
+    apiVersion: serving.knative.dev/v1alpha1
+    kind: Service
+    metadata:
+      name: gitwebhook
+      namespace: default
     spec:
       - containers:
           # Replace {DOCKER_HUB_USERNAME} with your actual docker hub username
@@ -83,14 +88,14 @@ spec:
                 secretKeyRef:
                   name: githubsecret
                   key: accessToken
-```
+    ```
 
 1. Use `kubectl` to apply the `service.yaml` file.
 
-```shell
-$ kubectl apply --filename service.yaml
-service "gitwebhook" created
-```
+    ```shell
+    $ kubectl apply --filename service.yaml
+    service "gitwebhook" created
+    ```
 
 1. Finally, once the service is running, create the webhook from your GitHub
    repo to the URL for this service. For this to work properly you will need to
@@ -99,12 +104,12 @@ service "gitwebhook" created
 
    1. Retrieve the hostname for this service, using the following command:
 
-      ```shell
-      $ kubectl get ksvc gitwebhook \
-         --output=custom-columns=NAME:.metadata.name,DOMAIN:.status.domain
-      NAME                DOMAIN
-      gitwebhook          gitwebhook.default.example.com
-      ```
+       ```shell
+       $ kubectl get ksvc gitwebhook \
+          --output=custom-columns=NAME:.metadata.name,DOMAIN:.status.domain
+       NAME                DOMAIN
+       gitwebhook          gitwebhook.default.example.com
+       ```
 
    1. Browse on GitHub to the repository where you want to create a webhook.
    1. Click **Settings**, then **Webhooks**, then **Add webhook**.

docs/serving/samples/grpc-ping-go/README.md

@@ -1,12 +1,17 @@
 A simple gRPC server written in Go that you can use for testing.
 
-This sample requires knative/serving 0.4 or later.
-
 ## Prerequisites
 
-1. [Install Knative](../../../install/README.md).
+- [Install the Knative Serving version 0.4 or later](../../../install/README.md).
+
+- Install [docker](https://www.docker.com/).
 
-1. Install [docker](https://www.docker.com/).
+- Download a copy of the code:
+
+   ```shell
+   git clone -b "release-0.6" https://github.com/knative/docs knative-docs
+   cd knative-docs/serving/samples/grpc-ping-go
+   ```
 
 ## Build and run the gRPC server
 
@@ -31,20 +36,20 @@ kubectl apply --filename docs/serving/samples/grpc-ping-go/sample.yaml
 
 1. Fetch the created ingress hostname and IP.
 
-```shell
-# Put the Host name into an environment variable.
-export SERVICE_HOST=`kubectl get route grpc-ping --output jsonpath="{.status.domain}"`
+    ```shell
+    # Put the Host name into an environment variable.
+    export SERVICE_HOST=`kubectl get route grpc-ping --output jsonpath="{.status.domain}"`
 
-# Put the ingress IP into an environment variable.
-export SERVICE_IP=`kubectl get svc istio-ingressgateway --namespace istio-system --output jsonpath="{.status.loadBalancer.ingress[*].ip}"`
-```
+    # Put the ingress IP into an environment variable.
+    export SERVICE_IP=`kubectl get svc istio-ingressgateway --namespace istio-system --output jsonpath="{.status.loadBalancer.ingress[*].ip}"`
+    ```
 
 1. Use the client to send message streams to the gRPC server (replacing
    `{username}`)
 
-```shell
-docker run -ti --entrypoint=/client docker.io/{username}/grpc-ping-go \
-  -server_addr="${SERVICE_IP}:80" \
-  -server_host_override="${SERVICE_HOST}" \
-  -insecure
-```
+   ```shell
+   docker run -ti --entrypoint=/client docker.io/{username}/grpc-ping-go \
+     -server_addr="${SERVICE_IP}:80" \
+     -server_host_override="${SERVICE_HOST}" \
+     -insecure
+   ```