Skip to content

Commit bbfbbad

Browse files
vmexalienaxsaucedomattmoormpetasongrantr
authored
Additional eventing sample edits (#2930)
* Added Python Knative Eventing Helloworld Example * Update docs/eventing/samples/helloworld/helloworld-python/Dockerfile Co-Authored-By: Matt Moore <[email protected]> * Update docs/eventing/samples/helloworld/helloworld-python/Dockerfile Co-Authored-By: Matt Moore <[email protected]> * Update docs/eventing/samples/helloworld/helloworld-python/README.md Co-Authored-By: Matt Moore <[email protected]> * Apply suggestions from code review Co-Authored-By: Matt Moore <[email protected]> * Update docs/eventing/samples/helloworld/helloworld-python/README.md Co-authored-by: Mike Petersen <[email protected]> * Update docs/eventing/samples/helloworld/helloworld-python/README.md Co-authored-by: Ashleigh Brennan <[email protected]> * Update docs/eventing/samples/helloworld/helloworld-python/README.md Co-authored-by: Ashleigh Brennan <[email protected]> * Update docs/eventing/samples/helloworld/helloworld-python/README.md Co-authored-by: Ashleigh Brennan <[email protected]> * Update docs/eventing/samples/helloworld/helloworld-python/README.md Co-authored-by: Ashleigh Brennan <[email protected]> Co-authored-by: Alejandro Saucedo <[email protected]> Co-authored-by: Matt Moore <[email protected]> Co-authored-by: Mike Petersen <[email protected]> Co-authored-by: Grant Rodgers <[email protected]> Co-authored-by: Ashleigh Brennan <[email protected]>
1 parent 1d4a918 commit bbfbbad

File tree

1 file changed

+5
-6
lines changed
  • docs/eventing/samples/helloworld/helloworld-python

1 file changed

+5
-6
lines changed

docs/eventing/samples/helloworld/helloworld-python/README.md

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ folder) you're ready to build and deploy the sample app.
159159
docker push {username}/helloworld-python
160160
```
161161

162-
1. After the build has completed and the container is pushed to docker hub, you
162+
1. After the build has completed and the container is pushed to Docker Hub, you
163163
can deploy the sample application into your cluster. Ensure that the container image value
164164
in `sample-app.yaml` matches the container you built in the previous step. Apply
165165
the configuration using `kubectl`:
@@ -181,11 +181,10 @@ folder) you're ready to build and deploy the sample app.
181181
kubectl --namespace knative-samples get trigger helloworld-python
182182
```
183183
## Send and verify CloudEvents
184-
Once you have deployed the application and verified that the namespace, sample application and trigger are ready, let's send a CloudEvent.
184+
After you have deployed the application, and have verified that the namespace, sample application and trigger are ready, you can send a CloudEvent.
185185

186186
### Send CloudEvent to the Broker
187-
188-
We can send an http request directly to the Broker with correct CloudEvent headers set.
187+
You can send an HTTP request directly to the Knative [broker](../../../broker-trigger.md) if the correct CloudEvent headers are set.
189188

190189
1. Deploy a curl pod and SSH into it
191190
```shell
@@ -235,10 +234,10 @@ Helloworld-python app logs the context and the msg of the above event, and repli
235234
{"msg":"Hi from Knative!"}
236235
237236
```
238-
Play around with the CloudEvent attributes in the curl command and the trigger specification to understand how Triggers work.
237+
Try the CloudEvent attributes in the curl command and the trigger specification to understand how [triggers](../../../broker-trigger.md#trigger) work.
239238

240239
## Verify reply from helloworld-python app
241-
`helloworld-python` app replies back with an event of `type= dev.knative.samples.hifromknative`, and `source=knative/eventing/samples/hello-world`. This event enters the eventing mesh via the Broker and can be delivered to other services using a Trigger
240+
The `helloworld-python` app replies with an event type `type= dev.knative.samples.hifromknative`, and source `source=knative/eventing/samples/hello-world`. The event enters the eventing mesh through the broker, and can be delivered to event sinks using a trigger
242241

243242
1. Deploy a pod that receives any CloudEvent and logs the event to its output.
244243
```shell

0 commit comments

Comments
 (0)