Skip to content

Commit e2d5db9

Browse files
authored
fix image workflows (#6508)
* update autoscaling README.md docs * update image workflow to continue even if failure occurs
1 parent 5719318 commit e2d5db9

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

.github/workflows/knative-docs-image.yaml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,13 +35,15 @@ jobs:
3535

3636
- name: Build mkdocs image
3737
uses: docker/build-push-action@v6
38+
continue-on-error: true
3839
with:
3940
push: true
4041
file: ./hack/docker/Dockerfile
4142
tags: ghcr.io/knative/knative-docs:latest
4243

4344
- name: Build helloworld-go image
4445
uses: docker/build-push-action@v6
46+
continue-on-error: true
4547
with:
4648
push: true
4749
platforms: linux/amd64,linux/arm64,linux/ppc64le,linux/s390x
@@ -50,14 +52,16 @@ jobs:
5052

5153
- name: Build autoscale-go image
5254
uses: docker/build-push-action@v6
55+
continue-on-error: true
5356
with:
5457
push: true
5558
platforms: linux/amd64,linux/arm64,linux/ppc64le,linux/s390x
56-
context: ./docs/serving/autoscaling/autoscale-go
59+
context: ./docs/versioned/serving/autoscaling/autoscale-go
5760
tags: ghcr.io/knative/autoscale-go:latest
5861

5962
- name: Build sample-app's frontend image
6063
uses: docker/build-push-action@v6
64+
continue-on-error: true
6165
with:
6266
push: true
6367
platforms: linux/amd64,linux/arm64
@@ -66,6 +70,7 @@ jobs:
6670

6771
- name: Build sample-app's node-server image
6872
uses: docker/build-push-action@v6
73+
continue-on-error: true
6974
with:
7075
push: true
7176
platforms: linux/amd64,linux/arm64

docs/versioned/serving/autoscaling/autoscale-go/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ A demonstration of the autoscaling capabilities of a Knative Serving Revision.
2626
1. Deploy the [sample](service.yaml) Knative Service:
2727

2828
```bash
29-
kubectl apply -f docs/serving/autoscaling/autoscale-go/service.yaml
29+
kubectl apply -f docs/versioned/serving/autoscaling/autoscale-go/service.yaml
3030
```
3131

3232
1. Obtain the URL of the service (once `Ready`):
@@ -255,7 +255,7 @@ customization (32 minutes).
255255
## Cleanup
256256

257257
```bash
258-
kubectl delete -f docs/serving/autoscaling/autoscale-go/service.yaml
258+
kubectl delete -f docs/versioned/serving/autoscaling/autoscale-go/service.yaml
259259
```
260260

261261
## Further reading

0 commit comments

Comments
 (0)