Skip to content

Commit 6c2fdec

Browse files
committed
fix unused linter error
Can be seen for example in: https://github.com/knative/eventing/actions/runs/21171606060/job/60889521311 ``` Error: pkg/requestreply/ingress_handler.go:352:6: func isResponseEvent is unused (unused) func isResponseEvent(event *cloudevents.Event, rr *v1alpha1.RequestReply) bool { ^ Error: test/conformance/helpers/tracing_test_helper.go:53:3: const recordEventsPodName is unused (unused) recordEventsPodName = "recordevents" ^ Error: test/conformance/helpers/tracing_test_helper.go:98:6: func getTraceIDHeader is unused (unused) func getTraceIDHeader(t *testing.T, evInfos []recordevents.EventInfo) string { ^ 3 issues: * unused: 3 ```
1 parent 45c284b commit 6c2fdec

File tree

2 files changed

+16
-25
lines changed

2 files changed

+16
-25
lines changed

pkg/requestreply/ingress_handler.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -348,8 +348,3 @@ func (h *IngressHandler) handleReplyEvent(responseWriter http.ResponseWriter, ev
348348
// send the reply event back to the original response writer
349349
pr.replyEvent <- event
350350
}
351-
352-
func isResponseEvent(event *cloudevents.Event, rr *v1alpha1.RequestReply) bool {
353-
_, ok := event.Extensions()[rr.Spec.ReplyAttribute]
354-
return ok
355-
}

test/conformance/helpers/tracing_test_helper.go

Lines changed: 16 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,9 @@ import (
2121
"testing"
2222

2323
cetest "github.com/cloudevents/sdk-go/v2/test"
24-
"go.opentelemetry.io/otel/propagation"
25-
"go.opentelemetry.io/otel/trace"
2624
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
27-
2825
tracinghelper "knative.dev/eventing/test/conformance/helpers/tracing"
2926
testlib "knative.dev/eventing/test/lib"
30-
"knative.dev/eventing/test/lib/recordevents"
3127
)
3228

3329
// SetupTracingTestInfrastructureFunc sets up the infrastructure for running tracing tests. It returns the
@@ -49,14 +45,14 @@ func tracingTest(
4945
setupInfrastructure SetupTracingTestInfrastructureFunc,
5046
channel metav1.TypeMeta,
5147
) {
52-
const (
53-
recordEventsPodName = "recordevents"
54-
)
55-
5648
client := testlib.Setup(t, true, setupClient)
5749
defer testlib.TearDown(client)
5850

5951
// TODO - redo with OTel
52+
// const (
53+
// recordEventsPodName = "recordevents"
54+
// )
55+
//
6056
// Start the event info store. Note this is done _before_ we setup the infrastructure, which
6157
// sends the event.
6258
// targetTracker, err := recordevents.NewEventInfoStore(client, recordEventsPodName, client.Namespace)
@@ -95,15 +91,15 @@ func tracingTest(
9591
// getTraceIDHeader gets the TraceID from the passed in events. It returns the header from the
9692
// first matching event, but registers a fatal error if more than one traceid header is seen
9793
// in that message.
98-
func getTraceIDHeader(t *testing.T, evInfos []recordevents.EventInfo) string {
99-
for i := range evInfos {
100-
if nil != evInfos[i].HTTPHeaders {
101-
sc := trace.SpanContextFromContext(propagation.TraceContext{}.Extract(context.TODO(), propagation.HeaderCarrier(evInfos[i].HTTPHeaders)))
102-
if sc.HasTraceID() {
103-
return sc.TraceID().String()
104-
}
105-
}
106-
}
107-
t.Fatalf("FAIL: No traceid in %d messages: (%v)", len(evInfos), evInfos)
108-
return ""
109-
}
94+
// func getTraceIDHeader(t *testing.T, evInfos []recordevents.EventInfo) string {
95+
// for i := range evInfos {
96+
// if nil != evInfos[i].HTTPHeaders {
97+
// sc := trace.SpanContextFromContext(propagation.TraceContext{}.Extract(context.TODO(), propagation.HeaderCarrier(evInfos[i].HTTPHeaders)))
98+
// if sc.HasTraceID() {
99+
// return sc.TraceID().String()
100+
// }
101+
// }
102+
// }
103+
// t.Fatalf("FAIL: No traceid in %d messages: (%v)", len(evInfos), evInfos)
104+
// return ""
105+
// }

0 commit comments

Comments
 (0)