make f.Root path absolute (#3465)

Author: gauron99

pkg/functions/client_test.go

@@ -556,8 +556,8 @@ func TestClient_New_ImageRegistryDefaults(t *testing.T) {
 // Deploy (and confirms expected fields calculated).
 func TestClient_New_Delegation(t *testing.T) {
 	var (
-		root          = "testdata/example.com/test-new-delegates" // .. in which to initialize
-		expectedName  = "test-new-delegates"                      // expected to be derived
+		root          = absPath("testdata/example.com/test-new-delegates") // .. in which to initialize
+		expectedName  = "test-new-delegates"                               // expected to be derived
 		expectedImage = "example.com/alice/test-new-delegates:latest"
 		builder       = mock.NewBuilder()
 		pusher        = mock.NewPusher()
@@ -642,7 +642,7 @@ func TestClient_New_Delegation(t *testing.T) {
 // See TestClient_Runner for the test of the default runner implementation.
 func TestClient_Run(t *testing.T) {
 	// Create the root function directory
-	root := "testdata/example.com/test-run"
+	root := absPath("testdata/example.com/test-run")
 	defer Using(t, root)()
 
 	// client with the mock runner and the new test function
@@ -2235,3 +2235,11 @@ func TestClient_BuildPopulatesRuntimeImage(t *testing.T) {
 		t.Fatalf("written image in ./.func/built-image '%s' does not match expected '%s'", got, expect)
 	}
 }
+
+func absPath(p string) string {
+	abs, err := filepath.Abs(p)
+	if err != nil {
+		panic(err)
+	}
+	return abs
+}

pkg/functions/function.go

@@ -56,7 +56,8 @@ type Function struct {
 	// For details see the .Migrated() and .Migrate() methods.
 	SpecVersion string `yaml:"specVersion"` // semver format
 
-	// Root on disk at which to find/create source and config files.
+	// Root is the absolute path on disk at which to find/create source and
+	// config files.
 	Root string `yaml:"-"`
 
 	// Name of the function.
@@ -271,6 +272,9 @@ func NewFunction(root string) (f Function, err error) {
 			return
 		}
 	}
+	if root, err = filepath.Abs(root); err != nil {
+		return
+	}
 	f.Root = root // path is not persisted, as this is the purview of the FS
 
 	// Path must exist and be a directory