fix: pipeline names easily exceed character limit

Author: lkingland

pkg/pipelines/tekton/gitlab_int_test.go

@@ -562,8 +562,9 @@ func awaitBuildCompletion(t *testing.T, name, ns string) <-chan struct{} {
 		t.Fatal(err)
 	}
 
+	// Watch for TaskRuns with the build task label and function name label
 	listOpts := metav1.ListOptions{
-		LabelSelector: "tekton.dev/pipelineTask=build",
+		LabelSelector: fmt.Sprintf("tekton.dev/pipelineTask=build,function.knative.dev/name=%s", name),
 		Watch:         true,
 	}
 	w, err := clis.Tekton.TektonV1().TaskRuns(ns).Watch(context.Background(), listOpts)
@@ -580,9 +581,7 @@ func awaitBuildCompletion(t *testing.T, name, ns string) <-chan struct{} {
 			if !ok {
 				continue
 			}
-			if !strings.HasPrefix(taskRun.Name, name) {
-				continue
-			}
+			// No longer need to check name prefix since we're filtering by label
 			for _, condition := range taskRun.Status.Conditions {
 				if condition.Type == apis.ConditionSucceeded && condition.IsTrue() {
 					ch <- struct{}{}

pkg/pipelines/tekton/resources.go

@@ -2,6 +2,8 @@ package tekton
 
 import (
 	"context"
+	"crypto/sha256"
+	"encoding/hex"
 	"errors"
 	"fmt"
 
@@ -57,7 +59,12 @@ func getPipelineName(f fn.Function) string {
 	} else {
 		source = "git"
 	}
-	return fmt.Sprintf("%s-%s-%s-pipeline", f.Name, f.Build.Builder, source)
+
+	// Kubernetes resource names must be <= 63 characters (RFC 1123)
+	fullIdentifier := fmt.Sprintf("%s-%s-%s", f.Name, f.Build.Builder, source)
+	hash := sha256.Sum256([]byte(fullIdentifier))
+	shortHash := hex.EncodeToString(hash[:4]) // Use first 8 characters
+	return fmt.Sprintf("func-%s-%s-%s", shortHash, f.Build.Builder, source)
 }
 
 func getPipelineRunGenerateName(f fn.Function) string {

test/oncluster/tekton.go

@@ -3,44 +3,43 @@ package oncluster
 import (
 	"context"
 	"fmt"
-	"strings"
 	"testing"
 
 	v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"knative.dev/func/pkg/k8s"
 	"knative.dev/func/pkg/pipelines/tekton"
 )
 
-// TektonPipelineExists verifies pipeline with a given prefix exists on cluster
-func TektonPipelineExists(t *testing.T, pipelinePrefix string) bool {
+// TektonPipelineExists verifies pipeline with a given function name exists on cluster
+func TektonPipelineExists(t *testing.T, functionName string) bool {
 	ns, _, _ := k8s.GetClientConfig().Namespace()
 	client, _ := tekton.NewTektonClient(ns)
-	pipelines, err := client.Pipelines(ns).List(context.Background(), v1.ListOptions{})
+	// Look for pipelines with the function.knative.dev/name label matching the function name
+	pipelines, err := client.Pipelines(ns).List(context.Background(), v1.ListOptions{
+		LabelSelector: "function.knative.dev/name=" + functionName,
+	})
 	if err != nil {
 		t.Error(err.Error())
+		return false
 	}
-	for _, pipeline := range pipelines.Items {
-		if strings.HasPrefix(pipeline.Name, pipelinePrefix) && strings.HasSuffix(pipeline.Name, "-pipeline") {
-			return true
-		}
-	}
-	return false
+	// If any pipeline exists with this label, it means the pipeline was created for this function
+	return len(pipelines.Items) > 0
 }
 
-// TektonPipelineRunExists verifies pipelinerun with a given prefix exists on cluster
-func TektonPipelineRunExists(t *testing.T, pipelineRunPrefix string) bool {
+// TektonPipelineRunExists verifies pipelinerun with a given function name exists on cluster
+func TektonPipelineRunExists(t *testing.T, functionName string) bool {
 	ns, _, _ := k8s.GetClientConfig().Namespace()
 	client, _ := tekton.NewTektonClient(ns)
-	pipelineRuns, err := client.PipelineRuns(ns).List(context.Background(), v1.ListOptions{})
+	// Look for pipeline runs with the function.knative.dev/name label matching the function name
+	pipelineRuns, err := client.PipelineRuns(ns).List(context.Background(), v1.ListOptions{
+		LabelSelector: "function.knative.dev/name=" + functionName,
+	})
 	if err != nil {
 		t.Error(err.Error())
+		return false
 	}
-	for _, run := range pipelineRuns.Items {
-		if strings.HasPrefix(run.Name, pipelineRunPrefix) {
-			return true
-		}
-	}
-	return false
+	// If any pipeline run exists with this label, it means a pipeline run was created for this function
+	return len(pipelineRuns.Items) > 0
 }
 
 type PipelineRunSummary struct {
@@ -67,33 +66,39 @@ func (p *PipelineRunSummary) IsSucceed() bool {
 
 // TektonPipelineLastRunSummary gather information about a pipeline run such as
 // list of tasks executed and status of each task execution. It is meant to be used on assertions
-func TektonPipelineLastRunSummary(t *testing.T, pipelinePrefix string) *PipelineRunSummary {
+func TektonPipelineLastRunSummary(t *testing.T, functionName string) *PipelineRunSummary {
 	ns, _, _ := k8s.GetClientConfig().Namespace()
 	client, _ := tekton.NewTektonClient(ns)
-	pipelineRuns, err := client.PipelineRuns(ns).List(context.Background(), v1.ListOptions{})
+	// Look for pipeline runs with the function.knative.dev/name label matching the function name
+	pipelineRuns, err := client.PipelineRuns(ns).List(context.Background(), v1.ListOptions{
+		LabelSelector: "function.knative.dev/name=" + functionName,
+	})
 	if err != nil {
 		t.Error(err.Error())
+		return &PipelineRunSummary{}
 	}
+
 	lr := PipelineRunSummary{}
-	for _, run := range pipelineRuns.Items {
-		if strings.HasPrefix(run.Name, pipelinePrefix) {
-			lr.PipelineRunName = run.Name
-			if len(run.Status.Conditions) > 0 {
-				lr.PipelineRunStatus = run.Status.Conditions[0].Reason
+	// Get the most recent pipeline run (they're sorted by creation time)
+	if len(pipelineRuns.Items) > 0 {
+		// Take the first one (most recent) from the filtered list
+		run := pipelineRuns.Items[0]
+		lr.PipelineRunName = run.Name
+		if len(run.Status.Conditions) > 0 {
+			lr.PipelineRunStatus = run.Status.Conditions[0].Reason
+		}
+		lr.TasksRunSummary = []PipelineTaskRunSummary{}
+		for _, ref := range run.Status.ChildReferences {
+			r := PipelineTaskRunSummary{}
+			r.TaskName = ref.PipelineTaskName
+			taskRun, err := client.TaskRuns(ns).Get(context.Background(), ref.Name, v1.GetOptions{})
+			if err != nil {
+				t.Error(err.Error())
 			}
-			lr.TasksRunSummary = []PipelineTaskRunSummary{}
-			for _, ref := range run.Status.ChildReferences {
-				r := PipelineTaskRunSummary{}
-				r.TaskName = ref.PipelineTaskName
-				taskRun, err := client.TaskRuns(ns).Get(context.Background(), ref.Name, v1.GetOptions{})
-				if err != nil {
-					t.Error(err.Error())
-				}
-				if len(taskRun.Status.Conditions) > 0 {
-					r.TaskStatus = taskRun.Status.Conditions[0].Reason
-				}
-				lr.TasksRunSummary = append(lr.TasksRunSummary, r)
+			if len(taskRun.Status.Conditions) > 0 {
+				r.TaskStatus = taskRun.Status.Conditions[0].Reason
 			}
+			lr.TasksRunSummary = append(lr.TasksRunSummary, r)
 		}
 	}
 	return &lr