Fix detection of host resolution failure

matejvasek · matejvasek · commit e2b7b678bce4 · 2025-01-20T16:25:59.000+01:00
Signed-off-by: Matej Vašek &lt;mvasek@redhat.com&gt;
diff --git a/pkg/docker/pusher.go b/pkg/docker/pusher.go
@@ -201,7 +201,8 @@ func (n *Pusher) pushImage(ctx context.Context, f fn.Function, credentials Crede
 	if err == nil {
 		return digest, nil
 	}
-	if strings.Contains(err.Error(), "no such host") {
+	errStr := err.Error()
+	if strings.Contains(errStr, "no such host") || strings.Contains(errStr, "failure in name resolution") {
 		// push with custom transport to be able to push into cluster private registries
 		return n.push(ctx, f, credentials, output)
 	}

Original file line number	Diff line number	Diff line change
`@@ -201,7 +201,8 @@ func (n *Pusher) pushImage(ctx context.Context, f fn.Function, credentials Crede`
`201`	`201`	`if err == nil {`
`202`	`202`	`return digest, nil`
`203`	`203`	`}`
`204`		`- if strings.Contains(err.Error(), "no such host") {`
	`204`	`+ errStr := err.Error()`
	`205`	`+ if strings.Contains(errStr, "no such host") \|\| strings.Contains(errStr, "failure in name resolution") {`
`205`	`206`	`// push with custom transport to be able to push into cluster private registries`
`206`	`207`	`return n.push(ctx, f, credentials, output)`
`207`	`208`	`}`