Skip to content

Commit c2014e3

Browse files
author
Vincent Hou
committed
Added verify test
1 parent b23f7d1 commit c2014e3

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

test/resources/knativeresources.go

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,8 @@ func IsKnativeDeploymentReady(dpList *v1.DeploymentList, expectedDeployments []s
9393
}
9494

9595
isReady := func(d *v1.Deployment) bool {
96+
fmt.Println("the deployment is")
97+
fmt.Println(d.Name)
9698
for key, val := range d.GetObjectMeta().GetLabels() {
9799
// Check if the version matches. As long as we find a value equals to the version, we can determine
98100
// the deployment is for the specific version. The key "networking.knative.dev/ingress-provider" is
@@ -111,12 +113,17 @@ func IsKnativeDeploymentReady(dpList *v1.DeploymentList, expectedDeployments []s
111113
}
112114

113115
if key == "app.kubernetes.io/version" || key == "serving.knative.dev/release" || key == "eventing.knative.dev/release" {
116+
fmt.Println("check the val")
117+
fmt.Println(val)
118+
fmt.Println("check the version")
119+
fmt.Println(version)
114120
if val == fmt.Sprintf("v%s", version) || val == version {
115121
// When on of the following conditions is met:
116122
// * spec.version is set to latest, but operator returns an actual semantic version
117123
// * spec.version is set to a valid semantic version
118124
// we need to verify the value of the key serving.knative.dev/release or eventing.knative.dev/release
119125
// matches the version.
126+
fmt.Println("go to check status")
120127
return isStatusReady(d.Status)
121128
} else if version == common.LATEST_VERSION && version != existingVersion {
122129
// If spec.version is set to latest and operator bundles a directory called latest, it is possible that the
@@ -198,7 +205,7 @@ func removeDuplications(slice []string) []string {
198205
// WaitForKnativeResourceState returns the status of whether all obsolete resources are removed
199206
func WaitForKnativeResourceState(clients *test.Clients, namespace string,
200207
obsResources []unstructured.Unstructured, logf logging.FormatLogger, inState func(clients *test.Clients,
201-
namespace string, obsResources []unstructured.Unstructured, logf logging.FormatLogger) (bool, error)) error {
208+
namespace string, obsResources []unstructured.Unstructured, logf logging.FormatLogger) (bool, error)) error {
202209
span := logging.GetEmitableSpan(context.Background(), fmt.Sprintf("WaitForKnativeResourceState/%s/%s", obsResources, "KnativeObsoleteResourceIsGone"))
203210
defer span.End()
204211

0 commit comments

Comments
 (0)