Skip to content

Commit e209eef

Browse files
upgrade to latest dependencies (#2199)
bumping knative.dev/reconciler-test 1e6de0a...c77185e: > c77185e upgrade to latest dependencies (# 842) bumping knative.dev/serving 090b6ae...0fcf762: > 0fcf762 Update net-contour nightly (# 16245) > 8f27914 bump min-scale timeout (# 16244) > 6b8cc01 upgrade to latest dependencies (# 16243) bumping knative.dev/pkg 7459906...ab67eb7: > ab67eb7 Reduce noisy "object has been modified" logs/events (# 3289) bumping knative.dev/eventing 7c37b14...7c78c5a: > 7c78c5a [main] Upgrade to latest dependencies (# 8795) bumping knative.dev/caching 60da975...9d5745d: > 9d5745d upgrade to latest dependencies (# 976) Signed-off-by: Knative Automation <[email protected]>
1 parent e0d5785 commit e209eef

File tree

7 files changed

+68
-37
lines changed

7 files changed

+68
-37
lines changed

go.mod

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,12 @@ require (
2020
k8s.io/apimachinery v0.34.2
2121
k8s.io/client-go v0.34.2
2222
k8s.io/code-generator v0.34.2
23-
knative.dev/caching v0.0.0-20251117013858-60da9753c6da
24-
knative.dev/eventing v0.47.1-0.20251118120514-7c37b1462d6e
23+
knative.dev/caching v0.0.0-20251119014714-9d5745d71f75
24+
knative.dev/eventing v0.47.1-0.20251119024914-7c78c5aaa012
2525
knative.dev/hack v0.0.0-20251117013754-67a5b048bc27
26-
knative.dev/pkg v0.0.0-20251118173915-745990698d3c
27-
knative.dev/reconciler-test v0.0.0-20251117013655-1e6de0a87d9a
28-
knative.dev/serving v0.47.1-0.20251118201414-090b6ae3ac3a
26+
knative.dev/pkg v0.0.0-20251119125415-ab67eb7f8660
27+
knative.dev/reconciler-test v0.0.0-20251119021616-c77185e753a3
28+
knative.dev/serving v0.47.1-0.20251119122515-0fcf7624a4ff
2929
sigs.k8s.io/yaml v1.6.0
3030
)
3131

go.sum

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1703,20 +1703,20 @@ k8s.io/utils v0.0.0-20210819203725-bdf08cb9a70a/go.mod h1:jPW/WVKK9YHAvNhRxK0md/
17031703
k8s.io/utils v0.0.0-20230209194617-a36077c30491/go.mod h1:OLgZIPagt7ERELqWJFomSt595RzquPNLL48iOWgYOg0=
17041704
k8s.io/utils v0.0.0-20250604170112-4c0f3b243397 h1:hwvWFiBzdWw1FhfY1FooPn3kzWuJ8tmbZBHi4zVsl1Y=
17051705
k8s.io/utils v0.0.0-20250604170112-4c0f3b243397/go.mod h1:OLgZIPagt7ERELqWJFomSt595RzquPNLL48iOWgYOg0=
1706-
knative.dev/caching v0.0.0-20251117013858-60da9753c6da h1:Cq7FHFesNZ823UiqkDmVVz07pUTmPWkVilrBQmiO4es=
1707-
knative.dev/caching v0.0.0-20251117013858-60da9753c6da/go.mod h1:nZhi8uwzKUUFSKBCAxEihwFm2LdrRotufqJj6NYaIPE=
1708-
knative.dev/eventing v0.47.1-0.20251118120514-7c37b1462d6e h1:nanBZhKdKxVXrsvtKkIXmFMHVWduNST76uOX/aN/0tQ=
1709-
knative.dev/eventing v0.47.1-0.20251118120514-7c37b1462d6e/go.mod h1:y2ah9JhILLaQDOeh4IQcLd2uYaVBU6ErGe5b53BLV1s=
1706+
knative.dev/caching v0.0.0-20251119014714-9d5745d71f75 h1:ta0r2Tlcruo4T2sNSzWQTBw3VnzbcuCOeSEnFjIiUQ4=
1707+
knative.dev/caching v0.0.0-20251119014714-9d5745d71f75/go.mod h1:bDsraD7o+RkT0ncnSXDwuJjQP90YF9r5wuFsaRyp/Gk=
1708+
knative.dev/eventing v0.47.1-0.20251119024914-7c78c5aaa012 h1:CNVrGoBVuejgz4abu3PaaSF0wiDvjWrMmM/ISX+EH7c=
1709+
knative.dev/eventing v0.47.1-0.20251119024914-7c78c5aaa012/go.mod h1:dIgwvtgR8LG3IsVw7CbORLi9LeYElNf3zJm4ZPyKFuI=
17101710
knative.dev/hack v0.0.0-20251117013754-67a5b048bc27 h1:yPzDTKOFtSYHxgXB2N7+nWT/3doNqPNCbCf7Bf9PeAE=
17111711
knative.dev/hack v0.0.0-20251117013754-67a5b048bc27/go.mod h1:L5RzHgbvam0u8QFHfzCX6MKxu/a/gIGEdaRBqNiVbl0=
17121712
knative.dev/networking v0.0.0-20251117014740-e8506646d57f h1:EcibemIof19GqPPdtRLKcboOd2lwReiaB1xQLBVwuRc=
17131713
knative.dev/networking v0.0.0-20251117014740-e8506646d57f/go.mod h1:bE6vGaXAX9J5hbll4fg99EVv4ke9AGzzJk0Pr0pdT8c=
1714-
knative.dev/pkg v0.0.0-20251118173915-745990698d3c h1:khjCe035kZgoJqE9HwQTEjS/WZCKRpNPlNkbh6Yr+Gc=
1715-
knative.dev/pkg v0.0.0-20251118173915-745990698d3c/go.mod h1:iVOYfi7BiB0jQEEiW3NUfBHVOjc0QIbdOqdNs47YEoI=
1716-
knative.dev/reconciler-test v0.0.0-20251117013655-1e6de0a87d9a h1:F7BVAA4jO1WoMufJJzrpzxMp+ZP6llJCGcO0M40RhYk=
1717-
knative.dev/reconciler-test v0.0.0-20251117013655-1e6de0a87d9a/go.mod h1:F5QJ23fZUKPctfsIwtXVjNz8C33vEdh04cbQNe8WzX8=
1718-
knative.dev/serving v0.47.1-0.20251118201414-090b6ae3ac3a h1:VuNfbR6vMFx5irFotnjtA56xuXLqQN6q0GNFz5j+00c=
1719-
knative.dev/serving v0.47.1-0.20251118201414-090b6ae3ac3a/go.mod h1:5kffRM3AN6+jTKRFX+aYo7GCCpEk/cY0RrlSw0LkQz4=
1714+
knative.dev/pkg v0.0.0-20251119125415-ab67eb7f8660 h1:4lJPD8CTsOZ6cXFYkm3LtZ8bruSY9OQpyIFS6S5NPGQ=
1715+
knative.dev/pkg v0.0.0-20251119125415-ab67eb7f8660/go.mod h1:iVOYfi7BiB0jQEEiW3NUfBHVOjc0QIbdOqdNs47YEoI=
1716+
knative.dev/reconciler-test v0.0.0-20251119021616-c77185e753a3 h1:dRYvtAZ3x4J90yDRcPNdffhtWyNCetKzooGH2qf5GME=
1717+
knative.dev/reconciler-test v0.0.0-20251119021616-c77185e753a3/go.mod h1:ipzxgpWoZ2MjUMdxiRnsUm4FnQrVeq+w/k2cNv3OXNk=
1718+
knative.dev/serving v0.47.1-0.20251119122515-0fcf7624a4ff h1:2Jmtd3K2sW+07yaNAtKcCoggldUtp0BXFIv9bYk75GE=
1719+
knative.dev/serving v0.47.1-0.20251119122515-0fcf7624a4ff/go.mod h1:eamzrgi+6LSfkKJSv2tFze8zE4VClo2O2BsFPFJlFCY=
17201720
nhooyr.io/websocket v1.8.6/go.mod h1:B70DZP8IakI65RVQ51MsWP/8jndNma26DVA/nFSCgW0=
17211721
pgregory.net/rapid v1.1.0 h1:CMa0sjHSru3puNx+J0MIAuiiEV4N0qj8/cMWGBBCsjw=
17221722
pgregory.net/rapid v1.1.0/go.mod h1:PY5XlDGj0+V1FCq0o192FdRhpKHGTRIWBgqjDBTrq04=

pkg/client/injection/reconciler/operator/v1beta1/knativeeventing/reconciler.go

Lines changed: 10 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/client/injection/reconciler/operator/v1beta1/knativeserving/reconciler.go

Lines changed: 10 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/knative.dev/pkg/codegen/cmd/injection-gen/generators/reconciler/reconciler_reconciler.go

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,10 @@ func (g *reconcilerReconcilerGenerator) GenerateType(c *generator.Context, t *ty
134134
Package: "k8s.io/apimachinery/pkg/api/errors",
135135
Name: "IsNotFound",
136136
}),
137+
"apierrsIsConflict": c.Universe.Function(types.Name{
138+
Package: "k8s.io/apimachinery/pkg/api/errors",
139+
Name: "IsConflict",
140+
}),
137141
"metav1GetOptions": c.Universe.Function(types.Name{
138142
Package: "k8s.io/apimachinery/pkg/apis/meta/v1",
139143
Name: "GetOptions",
@@ -573,6 +577,8 @@ func (r *reconcilerImpl) Reconcile(ctx {{.contextContext|raw}}, key string) erro
573577
// This is a wrapped error, don't emit an event.
574578
} else if ok, _ := {{ .controllerIsRequeueKey|raw }}(reconcileEvent); ok {
575579
// This is a wrapped error, don't emit an event.
580+
} else if {{ .apierrsIsConflict|raw }}(reconcileEvent) {
581+
// Conflict errors are expected, don't emit an event.
576582
} else {
577583
logger.Errorw("Returned an error", zap.Error(reconcileEvent))
578584
r.Recorder.Event(resource, {{.corev1EventTypeWarning|raw}}, "InternalError", reconcileEvent.Error())
@@ -698,8 +704,10 @@ func (r *reconcilerImpl) updateFinalizersFilteredServerSideApply(ctx {{.contextC
698704
699705
updated, err := patcher.Patch(ctx, resource.Name, {{.typesApplyPatchType|raw}}, patch, patchOpts)
700706
if err != nil {
701-
r.Recorder.Eventf(resource, {{.corev1EventTypeWarning|raw}}, "FinalizerUpdateFailed",
702-
"Failed to update finalizers for %q via server-side apply: %v", resource.Name, err)
707+
if !{{ .apierrsIsConflict|raw }}(err) {
708+
r.Recorder.Eventf(resource, {{.corev1EventTypeWarning|raw}}, "FinalizerUpdateFailed",
709+
"Failed to update finalizers for %q via server-side apply: %v", resource.Name, err)
710+
}
703711
} else {
704712
r.Recorder.Eventf(updated, {{.corev1EventTypeNormal|raw}}, "FinalizerUpdate",
705713
"Updated finalizers for %q via server-side apply", resource.GetName())
@@ -754,8 +762,10 @@ func (r *reconcilerImpl) updateFinalizersFilteredMergePatch(ctx {{.contextContex
754762
resourceName := resource.Name
755763
updated, err := patcher.Patch(ctx, resourceName, {{.typesMergePatchType|raw}}, patch, {{.metav1PatchOptions|raw}}{})
756764
if err != nil {
757-
r.Recorder.Eventf(existing, {{.corev1EventTypeWarning|raw}}, "FinalizerUpdateFailed",
758-
"Failed to update finalizers for %q: %v", resourceName, err)
765+
if !{{ .apierrsIsConflict|raw }}(err) {
766+
r.Recorder.Eventf(existing, {{.corev1EventTypeWarning|raw}}, "FinalizerUpdateFailed",
767+
"Failed to update finalizers for %q: %v", resourceName, err)
768+
}
759769
} else {
760770
r.Recorder.Eventf(updated, {{.corev1EventTypeNormal|raw}}, "FinalizerUpdate",
761771
"Updated %q finalizers", resource.GetName())

vendor/knative.dev/pkg/controller/controller.go

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ import (
2828

2929
"go.uber.org/zap"
3030
"go.uber.org/zap/zapcore"
31+
apierrors "k8s.io/apimachinery/pkg/api/errors"
3132
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
3233
"k8s.io/apimachinery/pkg/runtime/schema"
3334
"k8s.io/apimachinery/pkg/types"
@@ -532,23 +533,31 @@ func (c *Impl) processNextWorkItem() bool {
532533
}
533534

534535
func (c *Impl) handleErr(logger *zap.SugaredLogger, err error, key types.NamespacedName, startTime time.Time) {
535-
if IsSkipKey(err) {
536+
// Check if we should skip this key or if the queue is shutting down.
537+
// We check shutdown here since controller Run might have exited by now
538+
// (since while this item was being processed, queue.Len==0).
539+
if IsSkipKey(err) || c.workQueue.ShuttingDown() {
536540
c.workQueue.Forget(key)
537541
return
538542
}
543+
539544
if ok, delay := IsRequeueKey(err); ok {
540545
c.workQueue.AddAfter(key, delay)
541546
logger.Debugf("Requeuing key %s (by request) after %v (depth: %d)", safeKey(key), delay, c.workQueue.Len())
542547
return
543548
}
544549

550+
// Conflict errors are expected, requeue to retry
551+
if apierrors.IsConflict(err) {
552+
logger.Debugw("Reconcile conflict", zap.Duration("duration", time.Since(startTime)))
553+
c.workQueue.AddRateLimited(key)
554+
return
555+
}
556+
545557
logger.Errorw("Reconcile error", zap.Duration("duration", time.Since(startTime)), zap.Error(err))
546558

547559
// Re-queue the key if it's a transient error.
548-
// We want to check that the queue is shutting down here
549-
// since controller Run might have exited by now (since while this item was
550-
// being processed, queue.Len==0).
551-
if !IsPermanentError(err) && !c.workQueue.ShuttingDown() {
560+
if !IsPermanentError(err) {
552561
c.workQueue.AddRateLimited(key)
553562
logger.Debugf("Requeuing key %s due to non-permanent error (depth: %d)", safeKey(key), c.workQueue.Len())
554563
return

vendor/modules.txt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1489,11 +1489,11 @@ k8s.io/utils/net
14891489
k8s.io/utils/pointer
14901490
k8s.io/utils/ptr
14911491
k8s.io/utils/trace
1492-
# knative.dev/caching v0.0.0-20251117013858-60da9753c6da
1492+
# knative.dev/caching v0.0.0-20251119014714-9d5745d71f75
14931493
## explicit; go 1.24.0
14941494
knative.dev/caching/pkg/apis/caching
14951495
knative.dev/caching/pkg/apis/caching/v1alpha1
1496-
# knative.dev/eventing v0.47.1-0.20251118120514-7c37b1462d6e
1496+
# knative.dev/eventing v0.47.1-0.20251119024914-7c78c5aaa012
14971497
## explicit; go 1.24.0
14981498
knative.dev/eventing/cmd/heartbeats
14991499
knative.dev/eventing/pkg/apis
@@ -1606,7 +1606,7 @@ knative.dev/networking/pkg/http/proxy
16061606
knative.dev/networking/pkg/http/stats
16071607
knative.dev/networking/pkg/ingress
16081608
knative.dev/networking/pkg/k8s
1609-
# knative.dev/pkg v0.0.0-20251118173915-745990698d3c
1609+
# knative.dev/pkg v0.0.0-20251119125415-ab67eb7f8660
16101610
## explicit; go 1.24.0
16111611
knative.dev/pkg/apiextensions/storageversion
16121612
knative.dev/pkg/apiextensions/storageversion/cmd/migrate
@@ -1697,7 +1697,7 @@ knative.dev/pkg/webhook
16971697
knative.dev/pkg/webhook/certificates
16981698
knative.dev/pkg/webhook/certificates/resources
16991699
knative.dev/pkg/webhook/resourcesemantics/conversion
1700-
# knative.dev/reconciler-test v0.0.0-20251117013655-1e6de0a87d9a
1700+
# knative.dev/reconciler-test v0.0.0-20251119021616-c77185e753a3
17011701
## explicit; go 1.24.0
17021702
knative.dev/reconciler-test/cmd/eventshub
17031703
knative.dev/reconciler-test/pkg/environment
@@ -1726,7 +1726,7 @@ knative.dev/reconciler-test/pkg/resources/service
17261726
knative.dev/reconciler-test/pkg/resources/serviceaccount
17271727
knative.dev/reconciler-test/pkg/state
17281728
knative.dev/reconciler-test/resources/certificate
1729-
# knative.dev/serving v0.47.1-0.20251118201414-090b6ae3ac3a
1729+
# knative.dev/serving v0.47.1-0.20251119122515-0fcf7624a4ff
17301730
## explicit; go 1.24.0
17311731
knative.dev/serving/pkg/apis/autoscaling
17321732
knative.dev/serving/pkg/apis/autoscaling/v1alpha1

0 commit comments

Comments
 (0)