[wip] debug stale webhook config map #11650
knative-verify.yaml
on: pull_request
verify
/
Verify Deps and Codegen
3m 36s
Annotations
3 errors and 1 warning
|
verify / Verify Deps and Codegen
Process completed with exit code 1.
|
|
verify / Verify Deps and Codegen:
vendor/knative.dev/pkg/injection/sharedmain/main.go#L0
Please run ./hack/update-codegen.sh.
diff --git a/vendor/knative.dev/pkg/injection/sharedmain/main.go b/vendor/knative.dev/pkg/injection/sharedmain/main.go
index 4af2c08..50d5f4c 100644
--- a/vendor/knative.dev/pkg/injection/sharedmain/main.go
+++ b/vendor/knative.dev/pkg/injection/sharedmain/main.go
@@ -479,9 +479,7 @@ func SetupConfigMapWatchOrDie(ctx context.Context, logger *zap.SugaredLogger) *c
cmLabelReqs = append(cmLabelReqs, *req)
}
// TODO(mattmoor): This should itself take a context and be injection-based.
- cmw := cminformer.NewInformedWatcher(kc, system.Namespace(), cmLabelReqs...)
- cmw.Logger = logger.Named("cmw")
- return cmw
+ return cminformer.NewInformedWatcher(kc, system.Namespace(), cmLabelReqs...)
}
// WatchLoggingConfigOrDie establishes a watch of the logging config or dies by
|
|
verify / Verify Deps and Codegen:
vendor/knative.dev/pkg/configmap/informer/informed_watcher.go#L0
Please run ./hack/update-codegen.sh.
diff --git a/vendor/knative.dev/pkg/configmap/informer/informed_watcher.go b/vendor/knative.dev/pkg/configmap/informer/informed_watcher.go
index 963cce5..c9f33bf 100644
--- a/vendor/knative.dev/pkg/configmap/informer/informed_watcher.go
+++ b/vendor/knative.dev/pkg/configmap/informer/informed_watcher.go
@@ -20,7 +20,6 @@ import (
"errors"
"fmt"
- "go.uber.org/zap"
corev1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/equality"
k8serrors "k8s.io/apimachinery/pkg/api/errors"
@@ -100,8 +99,6 @@ type InformedWatcher struct {
// of registering and notifying observers. This simplifies the
// InformedWatcher to just setting up the Kubernetes informer.
configmap.ManualWatcher
-
- Logger *zap.SugaredLogger
}
// Asserts that InformedWatcher implements Watcher.
@@ -221,27 +218,15 @@ func (i *InformedWatcher) checkObservedResourcesExist() error {
func (i *InformedWatcher) addConfigMapEvent(obj interface{}) {
configMap := obj.(*corev1.ConfigMap)
i.OnChange(configMap)
-
- if i.Logger != nil {
- i.Logger.Warnf("config map %q added: %#v", configMap)
- }
}
func (i *InformedWatcher) updateConfigMapEvent(o, n interface{}) {
- configMap := n.(*corev1.ConfigMap)
-
// Ignore updates that are idempotent. We are seeing those
// periodically.
if equality.Semantic.DeepEqual(o, n) {
- if i.Logger != nil {
- i.Logger.Warnf("config map update ignored %s", configMap.Name)
- }
return
}
-
- if i.Logger != nil {
- i.Logger.Warnf("config map %q updated: %#v", configMap)
- }
+ configMap := n.(*corev1.ConfigMap)
i.OnChange(configMap)
}
@@ -261,10 +246,6 @@ func (i *InformedWatcher) deleteConfigMapEvent(obj interface{}) {
return
}
- if i.Logger != nil {
- i.Logger.Warnf("config map %q deleted: %#v", configMap)
- }
-
if def, ok := i.defaults[configMap.Name]; ok {
i.OnChange(def)
}
|
|
verify / Verify Deps and Codegen
Restore cache failed: Dependencies file is not found in /home/runner/work/serving/serving. Supported file pattern: go.mod
|