Skip to content

Closes #94#127

Draft
ozziest wants to merge 5 commits intoknex:masterfrom
ozziest:master
Draft

Closes #94#127
ozziest wants to merge 5 commits intoknex:masterfrom
ozziest:master

Conversation

@ozziest
Copy link

@ozziest ozziest commented Sep 9, 2022 •
edited
Loading

Hello everyone,

I intend to solve this issue (#94) while I have some free time. But I am gonna need some help.
I rebased the latest version of knex-schema-inspector. But in the pipeline, I see the following errors;

1) sqlite
       .columnInfo
         returns information for all columns in all tables:
     SqliteError: select `name` from `sqlite_master` where sql LIKE "%AUTOINCREMENT%" - no such column: %AUTOINCREMENT%
      at Database.prepare (node_modules/better-sqlite3/lib/methods/wrappers.js:5:21)
      at Client_BetterSQLite3._query (node_modules/knex/lib/dialects/better-sqlite3/index.js:30:34)
      at executeQuery (node_modules/knex/lib/execution/internal/query-executioner.js:37:17)
      at Client_BetterSQLite3.query (node_modules/knex/lib/client.js:146:12)
      at Runner.query (node_modules/knex/lib/execution/runner.js:130:36)
      at ensureConnectionCallback (node_modules/knex/lib/execution/internal/ensure-connection-callback.js:13:17)
      at Runner.ensureConnection (node_modules/knex/lib/execution/runner.js:307:20)
      at Runner.run (node_modules/knex/lib/execution/runner.js:30:19)

https://github.com/knex/knex-schema-inspector/runs/8266354215?check_suite_focus=true#step:10:197

At this point, what should I do?

  1. Should I extend dialects/sqlite.ts file?
  2. Should I work on the dialects/sqlite.ts file, and implement the changes for Client_SQLite3?

Also, should I use the same test file or create a new one for the better-sqlite?

@ozziest
Copy link
Author

ozziest commented Sep 10, 2022

@kibertoad, can you review this, please?

kibertoad
kibertoad reviewed Sep 10, 2022
View reviewed changes
kibertoad
kibertoad reviewed Sep 11, 2022
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kibertoad kibertoad kibertoad left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ozziest @kibertoad