Skip to content

Code optimization suggestions #428

@noobyu6

Description

@noobyu6

Hi,

I find that the private field factory at Line 17 in the file 'disconf/disconf-client/src/main/java/com/baidu/disconf/client/scan/inner/statically/strategy/impl/SpringScanStatic.java' on the master branch is only assigned and used in the method scan. Therefore, this field can be removed from the class, and become a local variable in the method scan. This transformation will normally reduce memory usage and improve readability of your code.

 private DefaultListableBeanFactory factory; // line 17 this field can be replaced by local variable ​  public ScanStaticModel scan(List<String> packNameList) {         // DefaultListableBeanFactory factory = (DefaultListableBeanFactory) context.getAutowireCapableBeanFactory();         factory = (DefaultListableBeanFactory) context.getAutowireCapableBeanFactory();         return null;     }

Besides, there are other fields like this.I sorted them out and put them in the table below.I will be happy if this transformation is helpful.

Location Field
com.baidu.disconf.core.common.zookeeper.ZookeeperMgr curHost
com.baidu.disconf.core.common.zookeeper.ZookeeperMgr curDefaultPrefixString
com.baidu.disconf.client.addons.properties.ReloadablePropertiesFactoryBean applicationContext

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions