Skip to content

Commit 091ad7b

Browse files
committed
UIEXT-3150: Remove misleading warning
* This warning was visible when legacy credentials were migrated upon showing the password widget. However, it is not useful to the user. UIEXT-3150 (WebUI-Migration Excel Reader)
1 parent 2ef52eb commit 091ad7b

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

org.knime.core.ui.tests/src/eclipse/org/knime/core/webui/node/dialog/defaultdialog/DefaultNodeDialogTest.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -774,11 +774,9 @@ void testApplyDataWithInvalidSettingsButValidFlowVariables() throws IOException,
774774
b -> b.withControllingFlowVariableName(validFlowVariable.getName()).build())//
775775
.build();
776776

777-
final var response = callApplyData(applyData);
777+
callApplyData(applyData);
778778

779779
assertFalse(m_nnc.getNodeContainerState().isExecuted()); // i.e. applied
780-
assertThatJson(response).inPath("$.warningMessages[0]").isString()
781-
.contains("settings overridden by flow variables have been saved as underlying manual settings");
782780
}
783781

784782
@Test

org.knime.core.ui/src/eclipse/org/knime/core/webui/node/dialog/internal/SettingsApplier.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -304,9 +304,6 @@ private static void overwriteSettingsToMakeThemValid(final SettingsType settings
304304
"The %s could not be applied since both underlying manual and overwritten flow variable settings are invalid: %s",
305305
settingsDescription, ex.getMessage()), ex);
306306
}
307-
DataServiceContext.get()
308-
.addWarningMessage("The settings overridden by flow variables have been saved as underlying manual settings"
309-
+ " to prevent an invalid settings exception if flow variables are unset.");
310307
}
311308

312309
private static Object getSettingsDescription(final SettingsType settingsType) {

0 commit comments

Comments
 (0)