Conversation
tcrundall-tng
requested review from
Copilot and
knime-ghub-bot
and removed request for
a team
There was a problem hiding this comment.
Pull request overview
This PR advances the WebUI migration effort by moving nodes/settings away from legacy “binary object / flow-variable string” representations toward structured WebUI parameters (including credentials widgets) and programmatic node descriptions.
Changes:
- Migrates Binary Objects to Strings to WebUI
NodeParameters, programmaticNodeDescription, and snapshot-based dialog/settings tests. - Updates Box Authenticator app credentials from a credentials-flow-variable string to a
LegacyCredentialswidget with validation/migration wiring. - Bumps plugin/test bundle versions to 5.12.0 and updates related snapshots/manifests.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| org.knime.ext.box.authenticator/src-deprecated/org/knime/ext/box/authenticator/node/BoxAuthenticatorSettings.java | Adds @ValueReference for nested Box app settings to enable validator referencing. |
| org.knime.ext.box.authenticator/src-deprecated/org/knime/ext/box/authenticator/node/BoxAppSettings.java | Replaces flow-variable string with LegacyCredentials + migration + custom validation hook. |
| org.knime.ext.box.authenticator/META-INF/MANIFEST.MF | Updates bundle version to 5.12.0. |
| org.knime.ext.box.authenticator.tests/pom.xml | Updates test artifact revision to 5.12.0. |
| org.knime.ext.box.authenticator.tests/files/test_snapshots/org.knime.ext.box.authenticator.node.BoxAuthenticatorSettingsTest.snap | Updates snapshots for new credentials widget schema/state. |
| org.knime.ext.box.authenticator.tests/META-INF/MANIFEST.MF | Updates fragment version and host range to align with 5.12.0. |
| org.knime.base.filehandling/src/org/knime/base/filehandling/binaryobjectstostrings/BinaryObjectsToStringsNodeParameters.java | Introduces WebUI parameters, persistence, migration annotations, and effect logic. |
| org.knime.base.filehandling/src/org/knime/base/filehandling/binaryobjectstostrings/BinaryObjectsToStringsNodeModel.java | Adds configure-time auto-guessing of the selected binary-object column when unset. |
| org.knime.base.filehandling/src/org/knime/base/filehandling/binaryobjectstostrings/BinaryObjectsToStringsNodeFactory.xml | Removes legacy XML node description in favor of programmatic description. |
| org.knime.base.filehandling/src/org/knime/base/filehandling/binaryobjectstostrings/BinaryObjectsToStringsNodeFactory.java | Implements WebUI dialog factory + KAI interface + programmatic node description. |
| org.knime.base.filehandling.tests/src/org/knime/base/filehandling/binaryobjectstostrings/BinaryObjectsToStringsNodeParametersTest.java | Replaces legacy dialog test with snapshot test for NodeParameters and settings structure. |
| org.knime.base.filehandling.tests/files/test_snapshots/org.knime.base.filehandling.binaryobjectstostrings.BinaryObjectsToStringsNodeParametersTest1.snap | Adds snapshot for loading a concrete settings instance. |
| org.knime.base.filehandling.tests/files/test_snapshots/org.knime.base.filehandling.binaryobjectstostrings.BinaryObjectsToStringsNodeParametersTest0.settings.xml.snap | Adds snapshot for persisted settings XML structure. |
| org.knime.base.filehandling.tests/files/test_snapshots/org.knime.base.filehandling.binaryobjectstostrings.BinaryObjectsToStringsNodeParametersTest.snap | Adds snapshot for default model/schema/UI schema/persist metadata. |
| org.knime.base.filehandling.tests/files/node_settings/BinaryObjectsToStringsNodeParameters.xml | Adds settings fixture used by snapshot tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...xt.box.authenticator/src-deprecated/org/knime/ext/box/authenticator/node/BoxAppSettings.java
Show resolved
Hide resolved
...org/knime/base/filehandling/binaryobjectstostrings/BinaryObjectsToStringsNodeParameters.java
Show resolved
Hide resolved
...org/knime/base/filehandling/binaryobjectstostrings/BinaryObjectsToStringsNodeParameters.java
Show resolved
Hide resolved
tcrundall-tng
force-pushed
the
enh/UIEXT-3491-webui-migration-binary-objects-to-strings
branch
2 times, most recently
from
8091e7a to
9f5cc7f
Compare
reissinj
reviewed
Mar 26, 2026
...rc/org/knime/base/filehandling/binaryobjectstostrings/BinaryObjectsToStringsNodeFactory.java
Outdated
Show resolved
Hide resolved
reissinj
reviewed
Mar 26, 2026
...rc/org/knime/base/filehandling/binaryobjectstostrings/BinaryObjectsToStringsNodeFactory.java
Show resolved
Hide resolved
reissinj
reviewed
Mar 26, 2026
.../src/org/knime/base/filehandling/binaryobjectstostrings/BinaryObjectsToStringsNodeModel.java
Show resolved
Hide resolved
reissinj
reviewed
Mar 26, 2026
...org/knime/base/filehandling/binaryobjectstostrings/BinaryObjectsToStringsNodeParameters.java
Outdated
Show resolved
Hide resolved
reissinj
reviewed
Mar 26, 2026
...org/knime/base/filehandling/binaryobjectstostrings/BinaryObjectsToStringsNodeParameters.java
Show resolved
Hide resolved
reissinj
reviewed
Mar 26, 2026
...org/knime/base/filehandling/binaryobjectstostrings/BinaryObjectsToStringsNodeParameters.java
Show resolved
Hide resolved
reissinj
reviewed
Mar 26, 2026
...org/knime/base/filehandling/binaryobjectstostrings/BinaryObjectsToStringsNodeParameters.java
Show resolved
Hide resolved
Contributor
|
The BinaryObjectsToStringsNodeDialog class can be deleted now. |
reissinj
requested changes
Mar 26, 2026
tcrundall-tng
force-pushed
the
enh/UIEXT-3491-webui-migration-binary-objects-to-strings
branch
2 times, most recently
from
6e7989d to
5f06b3f
Compare
reissinj
approved these changes
Mar 26, 2026
tcrundall-tng
force-pushed
the
enh/UIEXT-3491-webui-migration-binary-objects-to-strings
branch
from
5f06b3f to
2376172
Compare
|
tcrundall-tng
force-pushed
the
enh/UIEXT-3491-webui-migration-binary-objects-to-strings
branch
from
2376172 to
836397e
Compare
marcbux
force-pushed
the
enh/UIEXT-3491-webui-migration-binary-objects-to-strings
branch
from
836397e to
ce48700
Compare
UIEXT-3491 (WebUI Migration Binary Objects to Strings)
marcbux
force-pushed
the
enh/UIEXT-3491-webui-migration-binary-objects-to-strings
branch
from
ce48700 to
a299aee
Compare
marcbux
approved these changes
Mar 31, 2026
marcbux
deleted the
enh/UIEXT-3491-webui-migration-binary-objects-to-strings
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.