Rename validated_hidden to validated_members and clarify test comment

Co-authored-by: AtR1an <[email protected]>

Author: 2 people

org.knime.python3.nodes.tests/src/test/python/unittest/test_knime_parameter.py

@@ -1866,7 +1866,8 @@ class TestObj:
         self.assertIn("invalid members", warning_msg.lower())
         self.assertIn("Valid options", warning_msg)
 
-        # Schema should hide only the valid member (LINEAR)
+        # Schema should hide only LINEAR (which is valid, but the only valid member in the hidden list)
+        # The invalid members in the list are filtered out
         s = schema["properties"]["model"]["properties"]["invalid_param"]
         values = {entry["const"] for entry in s["oneOf"]}
         # LINEAR is hidden, others remain visible

org.knime.python3.nodes/src/main/python/knime/extension/parameter.py

@@ -1757,12 +1757,12 @@ def _get_visible_options(self, dialog_creation_context):
 
         # Validate that all returned members exist in the enum
         valid_names = set(self._enum._member_names_)
-        validated_hidden = []
+        validated_members = []
         invalid_members = []
 
         for member in hidden_members:
             if hasattr(member, "name") and member.name in valid_names:
-                validated_hidden.append(member)
+                validated_members.append(member)
             else:
                 invalid_members.append(member)
 
@@ -1776,15 +1776,15 @@ def _get_visible_options(self, dialog_creation_context):
 
         # If all members are hidden or all returned members were invalid, show empty
         all_members = list(self._enum)
-        if len(validated_hidden) >= len(all_members):
+        if len(validated_members) >= len(all_members):
             LOGGER.warning(
                 f"hidden_choices for parameter '{self._label}' would hide all options. "
                 f"Showing empty options."
             )
             return []
 
         # Return members that are not in the hidden list
-        hidden_names = {member.name for member in validated_hidden}
+        hidden_names = {member.name for member in validated_members}
         visible_members = [member for member in all_members if member.name not in hidden_names]
 
         return visible_members