Skip to content

Commit 84473a0

Browse files
AtR1anCopilot
andauthored
AP-25288: Fix behavior for filters that contain only invalid members
Co-authored-by: Copilot <[email protected]>
1 parent 5036960 commit 84473a0

File tree

1 file changed

+3
-3
lines changed
  • org.knime.python3.nodes/src/main/python/knime/extension

1 file changed

+3
-3
lines changed

org.knime.python3.nodes/src/main/python/knime/extension/parameter.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1774,14 +1774,14 @@ def _get_visible_options(self, dialog_creation_context):
17741774
f"{invalid_members}. Valid options are: {valid_options}"
17751775
)
17761776

1777-
# If all members are hidden or all returned members were invalid, show empty
1777+
# If all members would be hidden or all returned members were invalid, fall back to showing all
17781778
all_members = list(self._enum)
17791779
if len(validated_members) >= len(all_members):
17801780
LOGGER.warning(
17811781
f"hidden_choices for parameter '{self._label}' would hide all options. "
1782-
f"Showing empty options."
1782+
f"Showing all options instead."
17831783
)
1784-
return []
1784+
return all_members
17851785

17861786
# Return members that are not in the hidden list
17871787
hidden_names = {member.name for member in validated_members}

0 commit comments

Comments
 (0)