NXT-4224: Code style changes

NXT-4224 (Automatically / Manually sync when editing workflows in the browser)

Author: kaifranze

org.knime.ui.java/src/eclipse/org/knime/ui/java/api/DesktopAPI.java

@@ -62,7 +62,6 @@
 import org.eclipse.swt.widgets.Display;
 import org.knime.core.node.NodeLogger;
 import org.knime.gateway.api.service.GatewayException;
-import org.knime.ui.java.util.ProgressReporter;
 import org.knime.gateway.api.webui.entity.GatewayProblemDescriptionEnt;
 import org.knime.gateway.api.webui.service.util.MutableServiceCallException;
 import org.knime.gateway.api.webui.service.util.ServiceExceptions.LoggedOutException;
@@ -86,6 +85,7 @@
 import org.knime.ui.java.profile.UserProfile;
 import org.knime.ui.java.util.ExampleProjects;
 import org.knime.ui.java.util.MostRecentlyUsedProjects;
+import org.knime.ui.java.util.ProgressReporter;
 
 import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.ObjectMapper;
@@ -268,7 +268,7 @@ private static Object invokeMethod(final Method m, final Object[] args) throws T
      * @param progressReporter
      * @throws IllegalStateException if the dependencies have been already injected
      */
-    @SuppressWarnings({"java:S107", "JavadocDeclaration", "javadoc"}) // Parameter count
+    @SuppressWarnings({"java:S107", "JavadocDeclaration"}) // Parameter count
     public static void injectDependencies( //
         final ProjectManager projectManager, //
         final WorkflowMiddleware workflowMiddleware, //
@@ -309,65 +309,30 @@ static void injectDependency(final UserProfile userProfile) {
         DEPENDENCIES.put(UserProfile.class, userProfile);
     }
 
-    /**
-     * Add individual dependency for testing purposes.
-     *
-     * @param eventConsumer
-     */
     static void injectDependency(final EventConsumer eventConsumer) {
         DEPENDENCIES.put(EventConsumer.class, eventConsumer);
     }
 
-    /**
-     * Add individual dependency for testing purposes.
-     *
-     * @param localSpace
-     */
     static void injectDependency(final LocalSpace localSpace) {
         DEPENDENCIES.put(LocalSpace.class, localSpace);
     }
 
-    /**
-     * Add individual dependency for testing purposes.
-     *
-     * @param projectManager
-     */
     static void injectDependency(final ProjectManager projectManager) {
         DEPENDENCIES.put(ProjectManager.class, projectManager);
     }
 
-    /**
-     * Add individual dependency for testing purposes.
-     *
-     * @param appStateUpdater
-     */
     static void injectDependency(final AppStateUpdater appStateUpdater) {
         DEPENDENCIES.put(AppStateUpdater.class, appStateUpdater);
     }
 
-    /**
-     * Add individual dependency for testing purposes.
-     *
-     * @param spaceProvidersManager
-     */
     static void injectDependency(final SpaceProvidersManager spaceProvidersManager) {
         DEPENDENCIES.put(SpaceProvidersManager.class, spaceProvidersManager);
     }
 
-    /**
-     * Add individual dependency for testing purposes.
-     *
-     * @param mruProjects
-     */
     static void injectDependency(final MostRecentlyUsedProjects mruProjects) {
         DEPENDENCIES.put(MostRecentlyUsedProjects.class, mruProjects);
     }
 
-    /**
-     * Add individual dependency for testing purposes.
-     *
-     * @param exampleProjects
-     */
     static void injectDependency(final ExampleProjects exampleProjects) {
         DEPENDENCIES.put(ExampleProjects.class, exampleProjects);
     }

org.knime.ui.java/src/eclipse/org/knime/ui/java/api/OpenProject.java

@@ -58,7 +58,6 @@
 import org.knime.core.node.workflow.contextv2.HubSpaceLocationInfo;
 import org.knime.core.util.Pair;
 import org.knime.core.util.hub.NamedItemVersion;
-import org.knime.ui.java.util.ProgressReporter;
 import org.knime.gateway.api.util.VersionId;
 import org.knime.gateway.api.webui.entity.SpaceItemReferenceEnt.ProjectTypeEnum;
 import org.knime.gateway.api.webui.entity.SpaceItemVersionEnt;
@@ -75,6 +74,7 @@
 import org.knime.ui.java.util.CreateProject;
 import org.knime.ui.java.util.DesktopAPUtil;
 import org.knime.ui.java.util.MostRecentlyUsedProjects;
+import org.knime.ui.java.util.ProgressReporter;
 import org.knime.workbench.core.imports.RepoObjectImport;
 
 /**
@@ -136,7 +136,8 @@ static void openProject(final String spaceId, final String itemId, final String
             project = optProject.get();
         } else {
             final var origin = new Origin(spaceProviderId, spaceId, itemId, projectType);
-            project = CreateProject.createProjectFromOrigin(origin, DesktopAPI.getDeps(ProgressReporter.class), space);
+            final var progressReporter = DesktopAPI.getDeps(ProgressReporter.class);
+            project = CreateProject.createProjectFromOrigin(origin, progressReporter, space);
         }
 
         // already trigger loading of wfm here because we want to abort and not register the project if this fails

org.knime.ui.java/src/eclipse/org/knime/ui/java/util/CreateProject.java

@@ -103,17 +103,7 @@ public static Project createProjectFromOrigin(final Origin origin, final Progres
         return createProjectFromOrigin(projectId, name, origin, progressReporter, space);
     }
 
-    /**
-     * Create a {@link Project} instance that corresponds to an {@link Origin}, i.e. an item in a {@link Space}.
-     *
-     * @param projectId -
-     * @param name -
-     * @param origin -
-     * @param progressReporter -
-     * @param space -
-     * @return -
-     */
-    public static Project createProjectFromOrigin(final String projectId, final String name, final Origin origin,
+    private static Project createProjectFromOrigin(final String projectId, final String name, final Origin origin,
         final ProgressReporter progressReporter, final Space space) {
         return Project.builder() //
             .setWfmLoader(fromOriginWithProgressReporter(origin, progressReporter, space)) //