NXT-4436: Add error handling to exportSpaceItem

NXT-4436 (Workflow export fails silently if LOCAL mountpoint is deleted or deactivated)

Author: LeoWoerteler

org.knime.ui.java/src/eclipse/org/knime/ui/java/api/ExportAPI.java

@@ -48,12 +48,17 @@
  */
 package org.knime.ui.java.api;
 
+import java.util.Objects;
+
+import org.apache.commons.lang3.exception.ExceptionUtils;
 import org.eclipse.jface.viewers.StructuredSelection;
 import org.eclipse.jface.window.Window;
 import org.eclipse.jface.wizard.WizardDialog;
 import org.eclipse.ui.PlatformUI;
 import org.knime.core.node.workflow.NodeTimer;
+import org.knime.core.workbench.preferences.MountPointsPreferencesUtil;
 import org.knime.gateway.api.service.GatewayException;
+import org.knime.gateway.api.webui.service.util.ServiceExceptions.ServiceCallException;
 import org.knime.gateway.impl.webui.spaces.Space;
 import org.knime.workbench.explorer.localworkspace.LocalWorkspaceFileStore;
 import org.knime.workbench.explorer.view.ContentObject;
@@ -92,15 +97,31 @@ static boolean exportSpaceItem(final String spaceProviderId, final String spaceI
      * @param itemId id of the item to export
      *
      * @return true if the legacy workbench dialog has not been exited via "Cancel"
+     * @throws ServiceCallException if the export fails
      */
-    static boolean openExportWizard(final Space space, final String itemId) {
+    static boolean openExportWizard(final Space space, final String itemId) throws ServiceCallException {
         final var workbench = PlatformUI.getWorkbench();
         final var shell = workbench.getModalDialogShellProvider().getShell();
         final var itemUri = space.toKnimeUrl(itemId);
         return workbench.getDisplay().syncCall(() -> {
             final var exportWizard = new WorkflowExportWizard();
-            final var fileStore = new LocalWorkspaceFileStore(itemUri.getHost(), itemUri.getPath());
+            final var mountId = itemUri.getHost();
+            final var fileStore = new LocalWorkspaceFileStore(mountId, itemUri.getPath());
             final var item = ContentObject.forFile(fileStore);
+            if (item == null) {
+                final var mountPointPrefs = MountPointsPreferencesUtil.loadSortedMountSettingsFromPreferences(false);
+                final var isDeactivated =
+                    mountPointPrefs.stream().anyMatch(p -> Objects.equals(mountId, p.mountID()) && !p.isActive());
+                final var serviceCallEx = ServiceCallException.builder() //
+                    .withTitle("The LOCAL mountpoint has been " + (isDeactivated ? "deactivated" : "deleted")
+                        + ", disabling the export.") //
+                    .withDetails( //
+                        (isDeactivated ? "Reactivate it" : "Readd the 'Local Workspace'") + " in the preferences.", //
+                            "The setting can be found under Preferences → KNIME → KNIME Explorer.") //
+                    .canCopy(false) //
+                    .build();
+                throw ExceptionUtils.asRuntimeException(serviceCallEx); // thrown out of the `syncCall()` invocation
+            }
             exportWizard.init(workbench, new StructuredSelection(item));
             final var dialog = new WizardDialog(shell, exportWizard);
             dialog.create();

org.knime.ui.js/src/composables/useSpaceExplorerActions/useSpaceExplorerActions.ts

@@ -192,11 +192,15 @@ export const useSpaceExplorerActions = (
         disabled: doesSelectionContainFile.value || isSelectionMultiple.value,
         metadata: {
           id: "export",
-          handler: () => {
-            exportSpaceItem({
-              projectId: projectId.value,
-              itemId: selectedItemIds.value[0],
-            });
+          handler: async () => {
+            try {
+              await exportSpaceItem({
+                projectId: projectId.value,
+                itemId: selectedItemIds.value[0],
+              });
+            } catch (error) {
+              toastPresets.spaces.crud.exportItemFailed({ error });
+            }
           },
         },
       }) satisfies MenuItemWithHandler,

org.knime.ui.js/src/shortcuts/__tests__/workflowShortcuts.test.ts

@@ -163,6 +163,7 @@ describe("workflowShortcuts", () => {
     it("executes export action", () => {
       const { spaceOperationsStore, applicationStore } = createStore();
 
+      spaceOperationsStore.exportSpaceItem.mockResolvedValue(undefined);
       workflowShortcuts.export.execute(mockShortcutContext());
       expect(spaceOperationsStore.exportSpaceItem).toHaveBeenCalledWith({
         projectId: applicationStore.activeProjectId,

org.knime.ui.js/src/shortcuts/workflowShortcuts/generalShortcuts.ts

@@ -20,6 +20,7 @@ import { useClipboardInteractionsStore } from "@/store/workflow/clipboardInterac
 import { useDesktopInteractionsStore } from "@/store/workflow/desktopInteractions";
 import { useMovingStore } from "@/store/workflow/moving";
 import { useWorkflowStore } from "@/store/workflow/workflow";
+import { getToastPresets } from "@/toastPresets";
 import { getKanvasDomElement } from "@/util/getKanvasDomElement";
 import type { UnionToShortcutRegistry } from "../types";
 
@@ -244,10 +245,15 @@ const generalWorkflowShortcuts: GeneralNodeWorkflowShortcuts = {
     execute: () => {
       const { activeProjectId, activeProjectOrigin } = useApplicationStore();
 
-      useSpaceOperationsStore().exportSpaceItem({
-        projectId: activeProjectId!,
-        itemId: activeProjectOrigin!.itemId,
-      });
+      useSpaceOperationsStore()
+        .exportSpaceItem({
+          projectId: activeProjectId!,
+          itemId: activeProjectOrigin!.itemId,
+        })
+        .catch((error) => {
+          const { toastPresets } = getToastPresets();
+          toastPresets.spaces.crud.exportItemFailed({ error });
+        });
     },
     condition: () => {
       const { activeProjectId, activeProjectOrigin } = useApplicationStore();

org.knime.ui.js/src/toastPresets/spaces.ts

@@ -37,6 +37,7 @@ type SpacesCrudToastPresets = {
   renameItemFailed: ToastPresetErrorHandler<{ newName: string }>;
 
   createFolderFailed: ToastPresetErrorHandler;
+  exportItemFailed: ToastPresetErrorHandler;
 };
 
 type SpacesRevealToastPresets = {
@@ -125,6 +126,12 @@ export const getPresets = (
           headline: "Create folder failed",
           message: "Error while creating folder.",
         }),
+      exportItemFailed: ({ error }) =>
+        defaultAPIErrorHandler($toast, error, {
+          type: "error",
+          headline: "Export failed",
+          message: "Error while exporting item.",
+        }),
       moveItemsFailed: ({ error }) =>
         defaultAPIErrorHandler($toast, error, {
           type: "error",