Fix: Incorrect property access causing indexing failures (#200)

* Fixes a critical error where DiscoveredFile.file_hash was incorrectly called as a method, when it is a property. This stemmed from the use of `computed_field` without a property decorator, which the type checker interpreted as a method. Added property decorator to clarify property status.

* Added rich markup escapes for error messages referencing codeweaver optional packages.

* Minor type improvements in connection pooling modules.

---------

Signed-off-by: Adam Poulemanos <[email protected]>
Co-authored-by: Claude <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: copilot-swe-agent[bot] <[email protected]>

Author: 4 people

.github/actionlint.yml

@@ -6,4 +6,4 @@
 paths:
   .github/actions/setup-uv-env/action.yml:
     ignore:
-      - '.*is not defined in object type.*'
+      - .*is not defined in object type.*

.github/actions/setup-mise-env/action.yml

@@ -5,24 +5,23 @@
 
 name: Setup Mise Environment
 description: Complete Python development environment setup with mise and UV caching
-
 inputs:
   python-version:
     description: Python version to install
     required: false
-    default: '3.12'
+    default: "3.12"
   fetch-depth:
     description: Git fetch depth for checkout
     required: false
-    default: '1'
+    default: "1"
   skip-checkout:
     description: Skip checkout step (if already checked out by calling workflow)
     required: false
-    default: 'false'
+    default: "false"
   github-token:
     description: GitHub token for mise installation (to avoid rate limits)
     required: false
-    default: ''
+    default: ""
   profile:
     description: Task profile to use for mise setup one of 'minimal', 'reviewer', 'dev'
     required: true

.github/actions/setup-python-env/action.yml

@@ -5,20 +5,19 @@
 
 name: Setup Python Environment
 description: Minimal Python environment setup
-
 inputs:
   python-version:
     description: Python version to install
     required: false
-    default: '3.12'
+    default: "3.12"
   fetch-depth:
     description: Git fetch depth for checkout
     required: false
-    default: '0'
+    default: "0"
   skip-checkout:
     description: Skip checkout step (if already checked out by calling workflow)
     required: false
-    default: 'false'
+    default: "false"
   github-token:
     description: GitHub token for mise installation (to avoid rate limits)
     required: false
@@ -40,11 +39,9 @@ runs:
       uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8
       with:
         fetch-depth: ${{ inputs.fetch-depth }}
-
     - name: Free up disk space
       shell: bash
       run: ./scripts/dev-env/ci-free-disk-space.sh
-
     - name: Set up Python ${{ inputs.python-version }}
       uses: actions/setup-python@9b03c627221f32cb88b299427119da30671cf9cc # v5
       with:

.github/actions/setup-uv-env/action.yml

@@ -5,24 +5,23 @@
 
 name: Setup UV Environment
 description: Minimal UV environment setup with caching
-
 inputs:
   fetch-depth:
     description: Git fetch depth for checkout
     required: false
-    default: '1'
+    default: "1"
   skip-checkout:
     description: Skip checkout step (if already checked out by calling workflow)
     required: false
-    default: 'false'
+    default: "false"
   github-token:
     description: GitHub token for mise installation (to avoid rate limits)
     required: false
-    default: ''
+    default: ""
   python-version:
     description: Python version to install
     required: false
-    default: '3.12'
+    default: "3.12"
   activate-venv:
     description: Whether to activate the Python virtual environment
     required: false
@@ -44,19 +43,18 @@ runs:
       uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8
       with:
         fetch-depth: ${{ inputs.fetch-depth }}
-
     - name: Setup UV and build
       uses: astral-sh/setup-uv@9c12baee9699f1b4f4318d7175fab8635c2b8e45
       with:
-        resolution-strategy: "highest"
+        resolution-strategy: highest
         python-version: ${{ inputs.python-version }}
         activate-environment: ${{ inputs.activate-venv }}
         github-token: ${{ inputs.github-token }}
         enable-cache: "true"
         cache-dependency-glob: |
           **/pyproject.toml
           **/uv.lock
-        cache-suffix: "highest"
+        cache-suffix: highest
         restore-cache: "true"
         save-cache: "true"
         prune-cache: "true"

.github/workflows/_reusable-build.yml

@@ -4,31 +4,29 @@
 # SPDX-License-Identifier: MIT OR Apache-2.0
 
 name: Reusable Build Workflow
-
 on:
   workflow_call:
     inputs:
       artifact-name:
-        description: "Name for the build artifacts"
+        description: Name for the build artifacts
         required: false
         type: string
-        default: "python-package-distributions"
+        default: python-package-distributions
       python-version:
-        description: "Python version for building"
+        description: Python version for building
         required: false
         type: string
         default: "3.12"
       upload-artifacts:
-        description: "Upload build artifacts"
+        description: Upload build artifacts
         required: false
         type: boolean
         default: true
       clean-build:
-        description: "Run clean build (uv build --clear)"
+        description: Run clean build (uv build --clear)
         required: false
         type: boolean
         default: false
-
 jobs:
   build:
     name: Build Package
@@ -62,21 +60,13 @@ jobs:
           else
             "$UV_PATH" build
           fi
-
       - name: Check build artifacts
-        run: |
-          ls -la dist/
-          echo "Built packages:"
-          for file in dist/*; do
-            echo "📦 $(basename "$file")"
-          done
-
+        run: "ls -la dist/\necho \"Built packages:\"\nfor file in dist/*; do\n  echo \"\U0001F4E6 $(basename \"$file\")\"\ndone\n"
       - name: Verify package integrity with twine
         env:
           UVX_PATH: ${{ steps.setup-uv.outputs.uvx-path }}
         run: |
           "$UVX_PATH" twine check dist/*
-
       - name: Upload build artifacts
         if: inputs.upload-artifacts
         uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02

.github/workflows/_reusable-lint.yml

@@ -6,17 +6,16 @@
 name: Reusable Lint Workflow
 permissions:
   contents: read
-
 on:
   workflow_call:
     inputs:
       python-version:
-        description: "Python version for linting"
+        description: Python version for linting
         required: false
         type: string
         default: "3.12"
       run-format-check:
-        description: "Run format/license checks"
+        description: Run format/license checks
         required: false
         type: boolean
         default: true
@@ -31,7 +30,6 @@ jobs:
     permissions:
       contents: read
     name: Lint and Format
-    runs-on: ubuntu-latest
     env:
       MISE_PYTHON_VERSION: ${{ inputs.python-version }}
       UV_PYTHON: ${{ inputs.python-version }}
@@ -40,11 +38,10 @@ jobs:
         uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8
         with:
           fetch-depth: 1
-
       - name: Setup Python environment
         uses: ./.github/actions/setup-mise-env
         with:
-          python-version: ${{ inputs.python-version }}
+          python-version: ${{ env.python-version }}
           github-token: ${{ secrets.GITHUB_TOKEN }}
           profile: "${{ env.PROFILE }}"
           skip-checkout: true
@@ -55,7 +52,6 @@ jobs:
           MISE_PYTHON_VERSION: ${{ steps.mise-setup.outputs.MISE_PYTHON_VERSION }}
         run: mise run lint || echo "::warning::Lint checks failed but allowing workflow to continue"
         continue-on-error: true
-
       - name: Check formatting and licenses
         if: inputs.run-format-check
         env:

.github/workflows/_reusable-test.yml

@@ -6,27 +6,26 @@
 name: Reusable Test Workflow
 permissions:
   contents: read
-
 on:
   workflow_call:
     inputs:
       python-versions:
-        description: 'JSON array of Python versions to test (e.g., ["3.12", "3.13"]). Experimental versions (3.13t, 3.14t) are always included via matrix.include.'
+        description: JSON array of Python versions to test (e.g., ["3.12", "3.13"]). Experimental versions (3.13t, 3.14t) are always included via matrix.include.
         required: false
         type: string
         default: '["3.12", "3.13", "3.14"]'
       test-markers:
-        description: "Pytest markers for test filtering"
+        description: Pytest markers for test filtering
         required: false
         type: string
-        default: "not docker and not qdrant and not dev_only and not skip_ci and not network and not external_api"
+        default: not docker and not qdrant and not dev_only and not skip_ci and not network and not external_api
       upload-coverage:
-        description: "Upload coverage to Codecov"
+        description: Upload coverage to Codecov
         required: false
         type: boolean
         default: true
       run-quality-checks:
-        description: "Run quality checks before tests"
+        description: Run quality checks before tests
         required: false
         type: boolean
         default: true
@@ -61,12 +60,13 @@ jobs:
       fail-fast: false
       matrix:
         python-version: ${{ fromJSON(inputs.python-versions) }}
-        experimental: [false]
+        experimental:
+          - false
         include:
           # Experimental free-threaded Python versions (no-GIL)
-          - python-version: "3.13t"
+          - python-version: 3.13t
             experimental: true
-          - python-version: "3.14t"
+          - python-version: 3.14t
             experimental: true
     env:
       MISE_PYTHON_VERSION: ${{ matrix.python-version }}
@@ -82,7 +82,7 @@ jobs:
         with:
           python-version: ${{ matrix.python-version }}
           github-token: ${{ secrets.GITHUB_TOKEN }}
-          profile: "dev"
+          profile: dev
           skip-checkout: true
           mise-debug: true
         id: setup-mise
@@ -107,7 +107,6 @@ jobs:
           files: ./coverage.xml
           fail_ci_if_error: false
           token: ${{ secrets.CODECOV_TOKEN }}
-
       - name: Upload test results
         uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02
         if: always()

.github/workflows/changelog.yml

@@ -4,23 +4,20 @@
 # SPDX-License-Identifier: MIT OR Apache-2.0
 
 name: Generate Changelog
-
 on:
   workflow_dispatch:
     inputs:
       tag:
-        description: "Generate changelog for specific tag (e.g., v0.1.0). Leave empty for unreleased changes."
+        description: Generate changelog for specific tag (e.g., v0.1.0). Leave empty for unreleased changes.
         required: false
         type: string
       commit:
-        description: "Commit and push the generated CHANGELOG.md"
+        description: Commit and push the generated CHANGELOG.md
         required: false
         type: boolean
         default: false
-
 permissions:
   contents: write
-
 jobs:
   generate-changelog:
     name: Generate Changelog
@@ -30,12 +27,10 @@ jobs:
         uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8
         with:
           fetch-depth: 0 # Fetch all history for changelog generation
-
       - name: Install git-cliff
         uses: taiki-e/install-action@331a600f1b10a3fed8dc56f925012bede91ae51f
         with:
           tool: [email protected]
-
       - name: Generate changelog
         id: changelog
         run: |
@@ -49,12 +44,10 @@ jobs:
             echo "Generating changelog for unreleased changes"
             git-cliff --unreleased --prepend --output CHANGELOG.md
           fi
-
       - name: Display changelog
         run: |
           echo "Generated CHANGELOG.md:"
           cat CHANGELOG.md
-
       - name: Commit and push
         if: github.event.inputs.commit == 'true'
         run: |
@@ -71,7 +64,6 @@ jobs:
             fi
             git push
           fi
-
       - name: Upload changelog artifact
         uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4
         with: