-
Notifications
You must be signed in to change notification settings - Fork 1
feat: default to stdio transport, background daemon mode, and service persistence #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
9f42101
aebc546
fe3677c
0327dec
6de88d2
7c84dcc
337ac63
5213f86
7228180
df4a823
d3d9f86
31bc272
d55b1d4
c083fff
8c0accd
b789ccd
cfd9a22
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -101,14 +101,15 @@ RUN mkdir -p /app/data /app/config /app/.codeweaver && \ | |||||
| # Switch to non-root user | ||||||
| USER codeweaver | ||||||
|
|
||||||
| # Health check to ensure service is running | ||||||
| # Health check via management server | ||||||
| HEALTHCHECK --interval=30s --timeout=10s --start-period=40s --retries=3 \ | ||||||
| CMD curl -f http://localhost:9328/health/ || exit 1 | ||||||
| CMD curl -f http://localhost:9329/health || exit 1 | ||||||
|
|
||||||
| # Expose the MCP server port | ||||||
| EXPOSE 9328 | ||||||
| # Expose the MCP HTTP server port (9328) and management server port (9329) | ||||||
| EXPOSE 9328 9329 | ||||||
|
|
||||||
| # Default command: start the CodeWeaver MCP server | ||||||
| # Users can override this with custom config via docker-compose or docker run | ||||||
| # Default command: start the CodeWeaver daemon in foreground mode | ||||||
| # This runs both management server (9329) and MCP HTTP server (9328) | ||||||
| # For stdio-only mode (MCP clients), use: codeweaver server | ||||||
| ENTRYPOINT ["/entrypoint.sh"] | ||||||
| CMD ["codeweaver", "server", "--host", "0.0.0.0", "--port", "9328"] | ||||||
| CMD ["codeweaver", "start", "--foreground"] | ||||||
|
||||||
| CMD ["codeweaver", "start", "--foreground"] | |
| CMD ["codeweaver", "start", "--foreground", "--transport", "streamable-http"] |
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -42,6 +42,8 @@ services: | |||||||
| context: . | ||||||||
| dockerfile: Dockerfile | ||||||||
| container_name: codeweaver-server | ||||||||
| # Use HTTP transport for persistent service mode (daemon not needed in Docker) | ||||||||
|
||||||||
| # Use HTTP transport for persistent service mode (daemon not needed in Docker) | |
| # Use HTTP transport in docker-compose for direct HTTP connections | |
| # The daemon runs in foreground mode, providing both management and MCP HTTP servers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This diagram shows "STDIO proxy to HTTP" running in a Docker container, which then connects to a "CodeWeaver Daemon (running on host)". This architecture is problematic:
127.0.0.1inside the container refers to the container's localhost, not the hostThe diagram should clarify that this mode is for when the stdio proxy is NOT in Docker, or the documentation should explain the network configuration needed (e.g., using
host.docker.internalon Docker Desktop).