Skip to content

Commit e6d99e5

Browse files
chore(tests): simplify get_platform test
`nest_asyncio` is archived and broken on some platforms so it's not worth keeping in our test suite.
1 parent 1cdaf26 commit e6d99e5

File tree

3 files changed

+6
-49
lines changed

3 files changed

+6
-49
lines changed

pyproject.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ dev-dependencies = [
5656
"dirty-equals>=0.6.0",
5757
"importlib-metadata>=6.7.0",
5858
"rich>=13.7.1",
59-
"nest_asyncio==1.6.0",
6059
"pytest-xdist>=3.6.1",
6160
]
6261

requirements-dev.lock

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@ multidict==6.4.4
7575
mypy==1.14.1
7676
mypy-extensions==1.0.0
7777
# via mypy
78-
nest-asyncio==1.6.0
7978
nodeenv==1.8.0
8079
# via pyright
8180
nox==2023.4.22

tests/test_client.py

Lines changed: 6 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,10 @@
66
import os
77
import sys
88
import json
9-
import time
109
import asyncio
1110
import inspect
12-
import subprocess
1311
import tracemalloc
1412
from typing import Any, Union, cast
15-
from textwrap import dedent
1613
from unittest import mock
1714
from typing_extensions import Literal
1815

@@ -23,14 +20,17 @@
2320

2421
from knockapi import Knock, AsyncKnock, APIResponseValidationError
2522
from knockapi._types import Omit
23+
from knockapi._utils import asyncify
2624
from knockapi._models import BaseModel, FinalRequestOptions
2725
from knockapi._exceptions import KnockError, APIStatusError, APITimeoutError, APIResponseValidationError
2826
from knockapi._base_client import (
2927
DEFAULT_TIMEOUT,
3028
HTTPX_DEFAULT_TIMEOUT,
3129
BaseClient,
30+
OtherPlatform,
3231
DefaultHttpxClient,
3332
DefaultAsyncHttpxClient,
33+
get_platform,
3434
make_request_options,
3535
)
3636

@@ -1621,50 +1621,9 @@ def retry_handler(_request: httpx.Request) -> httpx.Response:
16211621

16221622
assert response.http_request.headers.get("x-stainless-retry-count") == "42"
16231623

1624-
def test_get_platform(self) -> None:
1625-
# A previous implementation of asyncify could leave threads unterminated when
1626-
# used with nest_asyncio.
1627-
#
1628-
# Since nest_asyncio.apply() is global and cannot be un-applied, this
1629-
# test is run in a separate process to avoid affecting other tests.
1630-
test_code = dedent("""
1631-
import asyncio
1632-
import nest_asyncio
1633-
import threading
1634-
1635-
from knockapi._utils import asyncify
1636-
from knockapi._base_client import get_platform
1637-
1638-
async def test_main() -> None:
1639-
result = await asyncify(get_platform)()
1640-
print(result)
1641-
for thread in threading.enumerate():
1642-
print(thread.name)
1643-
1644-
nest_asyncio.apply()
1645-
asyncio.run(test_main())
1646-
""")
1647-
with subprocess.Popen(
1648-
[sys.executable, "-c", test_code],
1649-
text=True,
1650-
) as process:
1651-
timeout = 10 # seconds
1652-
1653-
start_time = time.monotonic()
1654-
while True:
1655-
return_code = process.poll()
1656-
if return_code is not None:
1657-
if return_code != 0:
1658-
raise AssertionError("calling get_platform using asyncify resulted in a non-zero exit code")
1659-
1660-
# success
1661-
break
1662-
1663-
if time.monotonic() - start_time > timeout:
1664-
process.kill()
1665-
raise AssertionError("calling get_platform using asyncify resulted in a hung process")
1666-
1667-
time.sleep(0.1)
1624+
async def test_get_platform(self) -> None:
1625+
platform = await asyncify(get_platform)()
1626+
assert isinstance(platform, (str, OtherPlatform))
16681627

16691628
async def test_proxy_environment_variables(self, monkeypatch: pytest.MonkeyPatch) -> None:
16701629
# Test that the proxy environment variables are set correctly

0 commit comments

Comments
 (0)