Merge pull request #218 from Auge19/code_quality

phillipc · web-flow · commit 2079ca011477 · 2025-12-14T14:31:52.000+01:00
eslint) some manuell fixes
diff --git a/eslint.config.js b/eslint.config.js
@@ -16,6 +16,8 @@ export default [
       "prefer-const": "off",
       "no-useless-escape": "off",
       "no-array-constructor": "off",
+      "no-misleading-character-class": "off",
+      "@typescript-eslint/no-this-alias": "off",
       "@typescript-eslint/no-array-constructor": "off",
       "@typescript-eslint/no-explicit-any": "off",
       "@typescript-eslint/no-require-imports": "off",
diff --git a/packages/bind/src/applyBindings.ts b/packages/bind/src/applyBindings.ts
@@ -361,7 +361,7 @@ function applyBindingsToNodeInternal<T>(node: Node, sourceBindings: Record<strin
  * @param {Object} bindings
  * @param {[Promise]} nodeAsyncBindingPromises
  */
-function triggerDescendantsComplete (node : Node, bindings : Object, nodeAsyncBindingPromises : Set<Promise<any>>) {
+function triggerDescendantsComplete (node : Node, bindings : object, nodeAsyncBindingPromises : Set<Promise<any>>) {
   /** descendantsComplete ought to be an instance of the descendantsComplete
     *  binding handler. */
   const hasBindingHandler = bindingEvent.descendantsComplete in bindings
diff --git a/packages/binding.core/spec/hasfocusBehaviors.ts b/packages/binding.core/spec/hasfocusBehaviors.ts
@@ -72,7 +72,7 @@ const legacyCustomBinding = {
       var value = !!unwrap(valueAccessor());
 
       if (!element[hasfocusUpdatingProperty] && element[hasfocusLastValue] !== value) {
-          value ? element.focus() : element.blur();
+          if(value) { element.focus() } else { element.blur() }
 
           // In IE, the blur method doesn't always cause the element to lose focus (for example, if the window is not in focus).
           // Setting focus to the body element does seem to be reliable in IE, but should only be used if we know that the current
diff --git a/packages/binding.core/src/hasfocus.ts b/packages/binding.core/src/hasfocus.ts
@@ -60,7 +60,7 @@ export var hasfocus = {
     var value = !!unwrap(valueAccessor())
 
     if (!element[hasfocusUpdatingProperty] && element[hasfocusLastValue] !== value) {
-      value ? element.focus() : element.blur()
+      if(value) { element.focus() } else { element.blur() }
 
             // In IE, the blur method doesn't always cause the element to lose focus (for example, if the window is not in focus).
             // Setting focus to the body element does seem to be reliable in IE, but should only be used if we know that the current
diff --git a/packages/binding.template/spec/nativeTemplateEngineBehaviors.ts b/packages/binding.template/spec/nativeTemplateEngineBehaviors.ts
@@ -49,7 +49,7 @@ describe('Native template engine', function () {
 
   describe('Named templates', function () {
     function testRenderTemplate (templateElem, templateElemId?, templateElementProp?) {
-      templateElementProp || (templateElementProp = 'innerHTML')
+      templateElementProp = templateElementProp || 'innerHTML'
       templateElem[templateElementProp] = "name: <div data-bind='text: name'></div>"
 
       renderTemplate(templateElemId, {
diff --git a/packages/computed/spec/computedObservableBehaviors.ts b/packages/computed/spec/computedObservableBehaviors.ts
@@ -380,9 +380,9 @@ describe('Dependent Observable', function () {
   })
 
   it('Should describe itself as inactive if subsequent runs of the evaluator result in there being no dependencies', function () {
-    var someObservable = observable('initial'),
-      shouldHaveDependency = true,
-      computedInstance = computed(function () { shouldHaveDependency && someObservable() })
+    const someObservable = observable('initial')
+    let shouldHaveDependency = true    
+    const computedInstance = computed(function () { if(shouldHaveDependency) someObservable() })
     expect(computedInstance.isActive()).toEqual(true)
 
         // Trigger a refresh
@@ -392,10 +392,10 @@ describe('Dependent Observable', function () {
   })
 
   it('Should be inactive if it depends on an inactive computed', function () {
-    var someObservable = observable('initial'),
-      shouldHaveDependency = true,
-      computed1 = computed(function () { shouldHaveDependency && someObservable() }),
-      computed2 = computed(computed1)
+    const someObservable = observable('initial')
+    let shouldHaveDependency = true
+    const computed1 = computed(function () { if(shouldHaveDependency) someObservable() })
+    const computed2 = computed(computed1)
     expect(computed2.isActive()).toEqual(true)
 
         // Trigger a refresh
diff --git a/packages/computed/src/computed.ts b/packages/computed/src/computed.ts
@@ -58,6 +58,7 @@ export interface ComputedFunctions<T = any> extends Subscribable<T> {
 }
 
 // used in computed, but empty interface is pointless. Check if it's needed
+// eslint-disable-next-line @typescript-eslint/no-empty-object-type
 export interface PureComputed<T = any> extends Computed<T> { }
 
 export type ComputedReadFunction<T = any, TTarget = void> = Subscribable<T> | Observable<T> | Computed<T> | ((this: TTarget) => T);
diff --git a/packages/provider.mustache/src/AttributeMustacheProvider.ts b/packages/provider.mustache/src/AttributeMustacheProvider.ts
@@ -92,7 +92,8 @@ export default class AttributeMustacheProvider extends Provider {
     }
   }
 
-  getBindingAccessors (node: Element, context?: {}) {
+  getBindingAccessors (node: Element, context?) {
+    if(context === undefined) context = {}
     return Object.assign({}, ...this.bindingObjects(node, context))
   }
 }
diff --git a/packages/utils.parser/spec/preparserBehavior.ts b/packages/utils.parser/spec/preparserBehavior.ts
@@ -122,7 +122,7 @@ describe('Expression Rewriting', function () {
 
     var model = { firstName, lastName, boss, getAssistant }
 
-    const parsed = eval('({' + rewritten + '})')   // eslint-disable-line
+    const parsed = eval('({' + rewritten + '})')    
           // test values of property
     expect(parsed.a).to.equal(1)
     expect(parsed.b).to.equal('bob')
@@ -139,13 +139,13 @@ describe('Expression Rewriting', function () {
   it('Should be able to eval rewritten literals that contain unquoted keywords as keys', function () {
     var rewritten = preProcessBindings('if: true')
     expect(rewritten).to.equal("'if':true")
-    var evaluated = eval('({' + rewritten + '})')   // eslint-disable-line
+    var evaluated = eval('({' + rewritten + '})')    
     expect(evaluated['if']).to.equal(true)
   })
 
   it('Should eval keys without a value as if the value is undefined', function () {
     var rewritten = preProcessBindings('a: 1, b')
-    var parsedRewritten = eval('({' + rewritten + '})')  // eslint-disable-line
+    var parsedRewritten = eval('({' + rewritten + '})')   
     expect(parsedRewritten.a).to.equal(1)
     expect('b' in parsedRewritten).to.be.ok // eslint-disable-line
     expect(parsedRewritten.b).to.be.undefined // eslint-disable-line
@@ -155,7 +155,7 @@ describe('Expression Rewriting', function () {
     // Deprecated
     var rewritten = preProcessBindings('a: 1', {valueAccessors: true})
     expect(rewritten).to.equal("'a':function(){return 1 }")
-    var evaluated = eval('({' + rewritten + '})')   // eslint-disable-line
+    var evaluated = eval('({' + rewritten + '})')    
     expect(evaluated['a']()).to.equal(1)
   })
 
@@ -170,7 +170,7 @@ describe('Expression Rewriting', function () {
       {key: 'd', value: '\'2\'/2'},
       {key: 'r', value: '/a regex/'}])
     var rewritten = preProcessBindings(result)
-    var evaluated = eval('({' + rewritten + '})')   // eslint-disable-line
+    var evaluated = eval('({' + rewritten + '})')    
     expect(evaluated.a).to.equal(0)
     expect(evaluated.b).to.equal(2)
     expect(evaluated.c).to.equal(3)
diff --git a/packages/utils.parser/spec/preprocessingBehavior.ts b/packages/utils.parser/spec/preprocessingBehavior.ts
@@ -48,7 +48,7 @@ describe('Binding preprocessing', function () {
     expect(parsedRewritten.a).to.equal(1)
     expect(parsedRewritten.a2).to.equal(1)
 
-    expect(parsedRewritten.b).to.be.undefined
+    expect(parsedRewritten.b).to.equal(undefined)
     expect(parsedRewritten.b2).to.equal(2)
   })
 
@@ -67,7 +67,7 @@ describe('Binding preprocessing', function () {
     }
     var rewritten = preProcessBindings('a: 2')
     var parsedRewritten = eval('({' + rewritten + '})')
-    expect(parsedRewritten.a).to.be.undefined
+    expect(parsedRewritten.a).to.equal(undefined)
     expect(parsedRewritten.b).to.equal(3)
   })
 
diff --git a/packages/utils/helpers/jasmine-13-helper.ts b/packages/utils/helpers/jasmine-13-helper.ts
@@ -1,5 +1,4 @@
 /// <reference types="jasmine" />
-/// <reference types="jquery" />
 
 import jQuery from "jquery";
 window.jQuery = jQuery;
@@ -72,7 +71,11 @@ jasmine.browserSupportsProtoAssignment = { __proto__: [] } instanceof Array;
 jasmine.ieVersion = ieVersion;
 
 jasmine.setNodeText = function(node, text:string) {
-    'textContent' in node ? node.textContent = text : node.innerText = text;
+    if('textContent' in node) {
+        node.textContent = text 
+     } else { 
+        node.innerText = text
+     }
 };
 
 
diff --git a/packages/utils/src/array.ts b/packages/utils/src/array.ts
@@ -86,6 +86,7 @@ export function findMovesInArrayComparison (left, right, limitFailedCompares?: n
   if (left.length && right.length) {
     var failedCompares, l, r, leftItem, rightItem
     for (failedCompares = l = 0; (!limitFailedCompares || failedCompares < limitFailedCompares) && (leftItem = left[l]); ++l) {
+      // eslint-disable-next-line no-cond-assign
       for (r = 0; rightItem = right[r]; ++r) {
         if (leftItem.value === rightItem.value) {
           leftItem.moved = rightItem.index
diff --git a/packages/utils/src/dom/data.ts b/packages/utils/src/dom/data.ts
@@ -78,7 +78,9 @@ function get (node: Node, key: string) {
 function set (node : Node, key : string, value : any) {
   // Make sure we don't actually create a new domData key if we are actually deleting a value
   var dataForNode = getDataForNode(node, value !== undefined /* createIfNotFound */)
-  dataForNode && (dataForNode[key] = value)
+  if (dataForNode) {
+    dataForNode[key] = value
+  }
 }
 
 function getOrSet (node : Node, key : string, value : any) {
diff --git a/packages/utils/src/dom/fixes.ts b/packages/utils/src/dom/fixes.ts
@@ -55,6 +55,7 @@ export function forceRefresh (node) {
   if ((ieVersion as any) >= 9) {
         // For text nodes and comment nodes (most likely virtual elements), we will have to refresh the container
     var elem = node.nodeType == 1 ? node : node.parentNode
+    // eslint-disable-next-line no-self-assign
     if (elem.style) { elem.style.zoom = elem.style.zoom }
   }
 }
diff --git a/packages/utils/src/dom/html.ts b/packages/utils/src/dom/html.ts
@@ -43,7 +43,7 @@ function getWrap (tags) {
 }
 
 function simpleHtmlParse (html: string, documentContext? : Document) : Node[] {
-  documentContext || (documentContext = document)
+  if (!documentContext) { documentContext = document }
   var windowContext = documentContext['parentWindow'] || documentContext['defaultView'] || window
 
     // Based on jQuery's "clean" function, but only accounting for table-related elements.
diff --git a/packages/utils/src/dom/selectExtensions.ts b/packages/utils/src/dom/selectExtensions.ts
@@ -13,11 +13,15 @@ export var selectExtensions = {
   readValue: function (element : HTMLElement) {
     switch (tagNameLower(element)) {
       case 'option':
-        if (element[hasDomDataExpandoProperty] === true) { return domData.get(element, selectExtensions.optionValueDomDataKey) }
-        return (element as HTMLOptionElement).value
+        {
+          if (element[hasDomDataExpandoProperty] === true) { return domData.get(element, selectExtensions.optionValueDomDataKey) }
+          return (element as HTMLOptionElement).value
+        }
       case 'select':
-        const selectElement = element as HTMLSelectElement
-        return selectElement.selectedIndex >= 0 ? selectExtensions.readValue(selectElement.options[selectElement.selectedIndex]) : undefined
+        {
+          const selectElement = element as HTMLSelectElement
+          return selectElement.selectedIndex >= 0 ? selectExtensions.readValue(selectElement.options[selectElement.selectedIndex]) : undefined
+        }
       default:
         return (element as HTMLInputElement).value
     }
@@ -43,28 +47,30 @@ export var selectExtensions = {
 
         break
       case 'select':
-        if (value === '' || value === null) {
-          // A blank string or null value will select the caption
-          value = undefined
-        }
-        var selection = -1
+        {
+          if (value === '' || value === null) {
+            // A blank string or null value will select the caption
+            value = undefined
+          }
+          var selection = -1
 
-        const selectElement = element as HTMLSelectElement
+          const selectElement = element as HTMLSelectElement
 
-        for (let i = 0, n = selectElement.options.length, optionValue; i < n; ++i) {
-          optionValue = selectExtensions.readValue(selectElement.options[i])
-          // Include special check to handle selecting a caption with a blank string value
-          // Note that the looser == check here is intentional so that integer model values will match string element values.
-          const strictEqual = optionValue === value
-          const blankEqual = optionValue === '' && value === undefined
-          const numericEqual = typeof value === 'number' && Number(optionValue) === value
-          if (strictEqual || blankEqual || numericEqual) {
-            selection = i
-            break
+          for (let i = 0, n = selectElement.options.length, optionValue; i < n; ++i) {
+            optionValue = selectExtensions.readValue(selectElement.options[i])
+            // Include special check to handle selecting a caption with a blank string value
+            // Note that the looser == check here is intentional so that integer model values will match string element values.
+            const strictEqual = optionValue === value
+            const blankEqual = optionValue === '' && value === undefined
+            const numericEqual = typeof value === 'number' && Number(optionValue) === value
+            if (strictEqual || blankEqual || numericEqual) {
+              selection = i
+              break
+            }
+          }
+          if (allowUnset || selection >= 0 || (value === undefined && selectElement.size > 1)) {
+            selectElement.selectedIndex = selection
           }
-        }
-        if (allowUnset || selection >= 0 || (value === undefined && selectElement.size > 1)) {
-          selectElement.selectedIndex = selection
         }
         break
       default:
diff --git a/packages/utils/src/options.ts b/packages/utils/src/options.ts
@@ -36,7 +36,7 @@ export class Options {
   allowVirtualElements: boolean = true
 
   // Global variables that can be accessed from bindings.
-  bindingGlobals: Object & CustomBindingGlobalProperties = Object.create(null)
+  bindingGlobals: object & CustomBindingGlobalProperties = Object.create(null)
 
   // An instance of the binding provider.
   bindingProviderInstance: Provider

Original file line number	Diff line number	Diff line change
`@@ -58,6 +58,7 @@ export interface ComputedFunctions<T = any> extends Subscribable<T> {`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`// used in computed, but empty interface is pointless. Check if it's needed`
	`61`	`+// eslint-disable-next-line @typescript-eslint/no-empty-object-type`
`61`	`62`	`export interface PureComputed<T = any> extends Computed<T> { }`
`62`	`63`
`63`	`64`	`export type ComputedReadFunction<T = any, TTarget = void> = Subscribable<T> \| Observable<T> \| Computed<T> \| ((this: TTarget) => T);`
Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,8 @@ export default class AttributeMustacheProvider extends Provider {`
`92`	`92`	`}`
`93`	`93`	`}`
`94`	`94`
`95`		`- getBindingAccessors (node: Element, context?: {}) {`
	`95`	`+ getBindingAccessors (node: Element, context?) {`
	`96`	`+ if(context === undefined) context = {}`
`96`	`97`	`return Object.assign({}, ...this.bindingObjects(node, context))`
`97`	`98`	`}`
`98`	`99`	`}`