Skip to content

Commit 7b56798

Browse files
committed
ie) change test description / update changelog
1 parent f229599 commit 7b56798

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,12 @@ For TODO between alpha and release, see https://github.com/knockout/tko/issues/1
55
- #194 fix userAgent typo in IE check @phillipc
66
- #196 fix `**` operator precedence @mcselle
77
- #195 add docker container for headless tests, upgrade packages, README fixes @Auge19
8+
- #222 & #255 enable noImplicitOverride, noImplicitReturns, strictBindCallApply and strictFunctionTypes for stricter typescript validation @phillipc
9+
- #219 Make some security fixes and add an HTML sanitization hook to `options` @phillipc
10+
- #216 & #217 adds eslint and prettier @phillipc
11+
- #214 convert several classes to typescript @phillipc
12+
- #215 make jquery disablable and fix the loader mechanism @phillipc
13+
- #233 remove IE9 switches from TKO @phillipc
814

915
## Beta 1.7
1016

packages/binding.core/spec/valueBehaviors.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -286,10 +286,9 @@ describe('Binding: Value', function () {
286286
expect(myObservable()).toEqual('some value from the server')
287287
})
288288

289-
it('Should handle autofill selection by treating "propertychange" followed by "blur" as a change event', function () {
290-
// This spec !no longer! describes the awkward choreography of events needed to detect changes to text boxes on IE < 10,
291-
// because it doesn't fire regular "change" events when the user selects an autofill entry. It isn't applicable
292-
// on IE 10+ or other browsers, because they don't have that problem with autofill. We have change the test case, so it runs on modern browsers.
289+
it('Should handle autofill selection by treating "focus", "blur" and "change" event', function () {
290+
// We have change the test case, so it runs on modern browsers. Originally, this spec describes was a awkward choreography of events needed to detect changes to text boxes on IE < 10,
291+
// because it doesn't fire regular "change" events when the user selects an autofill entry.
293292

294293
const myObservable = observable(123).extend({ notify: 'always' })
295294
let numUpdates = 0

0 commit comments

Comments
 (0)