large backlog of pull requests

[douggie]

Hi,

we seem to have a large backlog of PR's?

Any thoughts on how we can get through them and get them merged?

Happy to help out any way I can

[bigscoop]

I was thinking of creating the fork where the PR's can be approved (or at least reviewed). Plenty of PR's are still pending from me as well.

Would someone support the idea?

[douggie]

What is your thinking around needing a fork. I think the first thing, is to somehow poriortise them, I guess people will start reviewing stuff that is important to them, for me would be the bybit v5 for example, then once it is reviewed by some contributors, then the core team can be tagged to look at it. but if no review by other contributors, then no merging, as I guess it is not that important. Douggie

…

On Thu, Nov 2, 2023 at 11:28 AM Dmitri Karpovich ***@***.***> wrote: I was thinking of creating the fork where the PR's can be approved (or at least reviewed). Plenty of PR's are still pending from me as well. Would someone support the idea? — Reply to this email directly, view it on GitHub <#4783 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBUO2REXMBCJHL7FZSG4PTYCN7U7AVCNFSM6AAAAAA6WBLGJ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJQGU2TANJVGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[bigscoop]

Unfortunately there is no activity from core team since couple of months. That makes me think of creating the fork

[douggie]

ahhhh!!!!!! i see.

…

On Thu, Nov 2, 2023 at 11:42 AM Dmitri Karpovich ***@***.***> wrote: Unfortunately there is no activity from core team since couple of months. That makes me think of creating the fork — Reply to this email directly, view it on GitHub <#4783 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBUO2RQT6XFEEFB74XUZVLYCOBJLAVCNFSM6AAAAAA6WBLGJ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJQGU3DQNJZGU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[douggie]

So options

Option 1 - Create a fork with new approvers, this seems a bit nuts, just add more approvers to existing project.
Option 2 - Ensure that a PR has to be reviewed by a contributer before it is reviwed by an approver, this kinda ensures the prioity is self selecting.
Option 3 - Add more approvers to the existing project.

I kinda thinking a combination of 2 and 3.
@timmolter @makarid @npomfret @mmazi what do you guys think?

[rizer1980]

Hello.

I agree that PR is viewed poorly.
Also, important!, somebody need to clear up a huge number of old error reports.
Option 1 - IMHO, bad. Project stratification, unclear prospects.
I vote for 2 and 3

[douggie]

ping @walec51 @timmolter @makarid thougths?

[makarid]

Hello everyone. I guess the best solution is everyone to fork his/her own version of the project and if one is willingly to fork the whole project and maintained it for the long term we can just use his/her fork. @tim Molter ***@***.***> had said in the past that he had no time to give to the project, totally understood, I will respect that.

…

On Tue, Nov 7, 2023, 2:03 PM douggie ***@***.***> wrote: ping @walec51 <https://github.com/walec51> @timmolter <https://github.com/timmolter> @makarid <https://github.com/makarid> thougths? — Reply to this email directly, view it on GitHub <#4783 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHIWQ7YAT36LFXQXRHOTUBTYDIPSVAVCNFSM6AAAAAA6WBLGJ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJYGM3TANBYGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[bigscoop]

@makarid another option would be to extend the list of maintainers. what do you think about it?

[douggie]

Given everything is set up ci etc , can we not just add maintainers, I am happy to maintain it and take over from tim.

…

On Tue, Nov 7, 2023, 12:11 PM Makarid ***@***.***> wrote: Hello everyone. I guess the best solution is everyone to fork his/her own version of the project and if one is willingly to fork the whole project and maintained it for the long term we can just use his/her fork. @tim Molter ***@***.***> had said in the past that he had no time to give to the project, totally understood, I will respect that. On Tue, Nov 7, 2023, 2:03 PM douggie ***@***.***> wrote: > ping @walec51 <https://github.com/walec51> @timmolter > <https://github.com/timmolter> @makarid <https://github.com/makarid> > thougths? > > — > Reply to this email directly, view it on GitHub > <#4783 (comment)>, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AHIWQ7YAT36LFXQXRHOTUBTYDIPSVAVCNFSM6AAAAAA6WBLGJ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJYGM3TANBYGI> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > — Reply to this email directly, view it on GitHub <#4783 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBUO2UUVVMIG5CIEKV6KTLYDIQQ5AVCNFSM6AAAAAA6WBLGJ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJYGM4DEMJQGI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[rizer1980]

fork is the last thing.
We need a person who will carry the project so that the majority of users start using its version.
Otherwise, there will be a bunch of forks, which over time will lose any ability to merge them with the main branch.
This will definitely not benefit the project.

I really don't understand why not give a few more people the opportunity to service the project?
yes, the quality may suffer a little, but the project will remain a single whole and will continue to develop...

[douggie]

I am happy to take on Tim's role

…

On Tue, Nov 7, 2023, 2:06 PM Ilya Smirnov ***@***.***> wrote: fork is the last thing. We need a person who will carry the project so that the majority of users start using its version. Otherwise, there will be a bunch of forks, which over time will lose any ability to merge them with the main branch. This will definitely not benefit the project. I really don't understand why not give a few more people the opportunity to service the project? yes, the quality may suffer a little, but the project will remain a single whole and will continue to develop... — Reply to this email directly, view it on GitHub <#4783 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBUO2UH6NVYBZKY3WI4PQTYDI55FAVCNFSM6AAAAAA6WBLGJ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJYGU4TCNJSGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[douggie]

@makarid are you able to add mainters? May be add me, @bigscoop @rizer1980 as a start? Any others we think?

My start would be

1. People have to get their PR's reviewed by another contributor
2. the maintainers do the final reivew and merge.

[makarid]

I totally agree to add more maintainers but I don't have access to do it. @tim Molter ***@***.***> and I think @badgerwithagun can

…

On Wed, Nov 8, 2023, 9:17 AM douggie ***@***.***> wrote: @makarid <https://github.com/makarid> are you able to add mainters? May be add me, @ bigscoop @rizer1980 <https://github.com/rizer1980> as a start? My start would be 1. People have to get their PR's reviewed by another contributor 2. the maintainers do the final reivew and merge. — Reply to this email directly, view it on GitHub <#4783 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHIWQ7Z6C4QDMNCSRHSVAA3YDMWZTAVCNFSM6AAAAAA6WBLGJ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBRGIZDENJXHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[timmolter]

I'm happy to add more maintainers. Who should I add?