Add named InvalidOAuth2ClientException (#457)

Author: kbond

src/Client/ClientRegistry.php

@@ -10,6 +10,7 @@
 
 namespace KnpU\OAuth2ClientBundle\Client;
 
+use KnpU\OAuth2ClientBundle\DependencyInjection\InvalidOAuth2ClientException;
 use Symfony\Component\DependencyInjection\ContainerInterface;
 
 class ClientRegistry
@@ -33,19 +34,21 @@ public function __construct(ContainerInterface $container, array $serviceMap)
      * @param string $key
      *
      * @return OAuth2ClientInterface
+     *
+     * @throws InvalidOAuth2ClientException
      */
     public function getClient($key)
     {
         if (isset($this->serviceMap[$key])) {
             $client = $this->container->get($this->serviceMap[$key]);
             if (!$client instanceof OAuth2ClientInterface) {
-                throw new \InvalidArgumentException(\sprintf('Somehow the "%s" client is not an instance of OAuth2ClientInterface.', $key));
+                throw new InvalidOAuth2ClientException(\sprintf('Somehow the "%s" client is not an instance of OAuth2ClientInterface.', $key));
             }
 
             return $client;
         }
 
-        throw new \InvalidArgumentException(\sprintf('There is no OAuth2 client called "%s". Available are: %s', $key, implode(', ', array_keys($this->serviceMap))));
+        throw new InvalidOAuth2ClientException(\sprintf('There is no OAuth2 client called "%s". Available are: %s', $key, implode(', ', array_keys($this->serviceMap))));
     }
 
     /**

src/DependencyInjection/InvalidOAuth2ClientException.php

@@ -0,0 +1,17 @@
+<?php
+
+/*
+ * OAuth2 Client Bundle
+ * Copyright (c) KnpUniversity <http://knpuniversity.com/>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace KnpU\OAuth2ClientBundle\DependencyInjection;
+
+use KnpU\OAuth2ClientBundle\Exception\OAuth2ClientException;
+
+class InvalidOAuth2ClientException extends \InvalidArgumentException implements OAuth2ClientException
+{
+}

tests/Client/ClientRegistryTest.php

@@ -12,6 +12,7 @@
 
 use KnpU\OAuth2ClientBundle\Client\ClientRegistry;
 use KnpU\OAuth2ClientBundle\Client\OAuth2ClientInterface;
+use KnpU\OAuth2ClientBundle\DependencyInjection\InvalidOAuth2ClientException;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\DependencyInjection\ContainerInterface;
 
@@ -51,7 +52,7 @@ public function testShouldThrowExceptionIfClientDoesNotExist()
 
         $testClientRegistry = new ClientRegistry($mockContainer, $mockServiceMap);
 
-        $this->expectException(\InvalidArgumentException::class);
+        $this->expectException(InvalidOAuth2ClientException::class);
 
         $testClientRegistry->getClient("unknownClient");
     }
@@ -69,7 +70,7 @@ public function testShouldThrowExceptionIfClientExistsButNotOAuth2Client()
 
         $testClientRegistry = new ClientRegistry($mockContainer, $mockServiceMap);
 
-        $this->expectException(\InvalidArgumentException::class);
+        $this->expectException(InvalidOAuth2ClientException::class);
 
         $testClientRegistry->getClient("invalid");
     }