Skip to content

Commit 1cd0a2a

Browse files
committed
pgrepl: use new tests packages
Release note: None
1 parent 6e622ea commit 1cd0a2a

File tree

3 files changed

+8
-12
lines changed

3 files changed

+8
-12
lines changed

pkg/sql/pgrepl/BUILD.bazel

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ go_test(
1717
"//pkg/security/username",
1818
"//pkg/server",
1919
"//pkg/sql/pgwire/pgcode",
20-
"//pkg/sql/tests",
2120
"//pkg/testutils/datapathutils",
2221
"//pkg/testutils/serverutils",
2322
"//pkg/testutils/sqlutils",

pkg/sql/pgrepl/extended_protocol_test.go

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@ import (
1515
"net/url"
1616
"testing"
1717

18+
"github.com/cockroachdb/cockroach/pkg/base"
1819
"github.com/cockroachdb/cockroach/pkg/security/username"
1920
"github.com/cockroachdb/cockroach/pkg/sql/pgwire/pgcode"
20-
"github.com/cockroachdb/cockroach/pkg/sql/tests"
2121
"github.com/cockroachdb/cockroach/pkg/testutils/serverutils"
2222
"github.com/cockroachdb/cockroach/pkg/testutils/sqlutils"
2323
"github.com/cockroachdb/cockroach/pkg/util/leaktest"
@@ -33,15 +33,14 @@ func TestExtendedProtocolDisabled(t *testing.T) {
3333
defer leaktest.AfterTest(t)()
3434
defer log.Scope(t).Close(t)
3535

36-
params, _ := tests.CreateTestServerParams()
37-
38-
s, db, _ := serverutils.StartServer(t, params)
39-
defer s.Stopper().Stop(context.Background())
36+
srv, db, _ := serverutils.StartServer(t, base.TestServerArgs{})
37+
defer srv.Stopper().Stop(context.Background())
38+
s := srv.ApplicationLayer()
4039

4140
sqlDB := sqlutils.MakeSQLRunner(db)
4241
sqlDB.Exec(t, `CREATE USER testuser LOGIN REPLICATION`)
4342

44-
pgURL, cleanup := sqlutils.PGUrl(t, s.ServingSQLAddr(), "pgrepl_conn_test", url.User(username.TestUser))
43+
pgURL, cleanup := sqlutils.PGUrl(t, s.AdvSQLAddr(), "pgrepl_extended_protocol_test", url.User(username.TestUser))
4544
defer cleanup()
4645

4746
cfg, err := pgconn.ParseConfig(pgURL.String())

pkg/sql/pgrepl/main_test.go

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@ import (
1818
"strings"
1919
"testing"
2020

21+
"github.com/cockroachdb/cockroach/pkg/base"
2122
"github.com/cockroachdb/cockroach/pkg/ccl"
2223
"github.com/cockroachdb/cockroach/pkg/security/securityassets"
2324
"github.com/cockroachdb/cockroach/pkg/security/securitytest"
2425
"github.com/cockroachdb/cockroach/pkg/security/username"
2526
"github.com/cockroachdb/cockroach/pkg/server"
26-
"github.com/cockroachdb/cockroach/pkg/sql/tests"
2727
"github.com/cockroachdb/cockroach/pkg/testutils/datapathutils"
2828
"github.com/cockroachdb/cockroach/pkg/testutils/serverutils"
2929
"github.com/cockroachdb/cockroach/pkg/testutils/sqlutils"
@@ -47,12 +47,10 @@ func TestDataDriven(t *testing.T) {
4747
defer leaktest.AfterTest(t)()
4848
defer log.Scope(t).Close(t)
4949

50-
params, _ := tests.CreateTestServerParams()
51-
52-
s, _, _ := serverutils.StartServer(t, params)
50+
s := serverutils.StartServerOnly(t, base.TestServerArgs{})
5351
defer s.Stopper().Stop(context.Background())
5452

55-
pgURL, cleanup := sqlutils.PGUrl(t, s.ServingSQLAddr(), "pgrepl_datadriven_test", url.User(username.RootUser))
53+
pgURL, cleanup := sqlutils.PGUrl(t, s.AdvSQLAddr(), "pgrepl_datadriven_test", url.User(username.RootUser))
5654
defer cleanup()
5755

5856
cfg, err := pgx.ParseConfig(pgURL.String())

0 commit comments

Comments
 (0)