Skip to content

Commit 21163ac

Browse files
committed
persistedsqlstats: specify background qos for compaction job
The compaction job can be an expensive operation so we should de-prioritize it with the `UserLow` qos setting. Fixes: cockroachdb#99949 Release note: None
1 parent 3bbf620 commit 21163ac

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

pkg/sql/sqlstats/persistedsqlstats/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ go_library(
3636
"//pkg/sql/isql",
3737
"//pkg/sql/sem/tree",
3838
"//pkg/sql/sessiondata",
39+
"//pkg/sql/sessiondatapb",
3940
"//pkg/sql/sqlstats",
4041
"//pkg/sql/sqlstats/persistedsqlstats/sqlstatsutil",
4142
"//pkg/sql/sqlstats/sslocal",

pkg/sql/sqlstats/persistedsqlstats/compaction_exec.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import (
2020
"github.com/cockroachdb/cockroach/pkg/sql/isql"
2121
"github.com/cockroachdb/cockroach/pkg/sql/sem/tree"
2222
"github.com/cockroachdb/cockroach/pkg/sql/sessiondata"
23+
"github.com/cockroachdb/cockroach/pkg/sql/sessiondatapb"
2324
"github.com/cockroachdb/cockroach/pkg/sql/sqlstats"
2425
"github.com/cockroachdb/cockroach/pkg/util/metric"
2526
"github.com/cockroachdb/cockroach/pkg/util/timeutil"
@@ -207,10 +208,14 @@ func (c *StatsCompactor) removeStaleRowsForShard(
207208
func (c *StatsCompactor) executeDeleteStmt(
208209
ctx context.Context, delStmt string, qargs []interface{},
209210
) (lastRow tree.Datums, rowsDeleted int64, err error) {
211+
qosLevel := sessiondatapb.UserLow
210212
it, err := c.db.Executor().QueryIteratorEx(ctx,
211213
"delete-old-sql-stats",
212214
nil, /* txn */
213-
sessiondata.NodeUserSessionDataOverride,
215+
sessiondata.InternalExecutorOverride{
216+
User: sessiondata.NodeUserSessionDataOverride.User,
217+
QualityOfService: &qosLevel,
218+
},
214219
delStmt,
215220
qargs...,
216221
)

0 commit comments

Comments
 (0)