Skip to content

Commit 27e36a0

Browse files
craig[bot]kvoliannrpom
committed
106514: kvserver: skip promote non voter under race r=erikgrinaker a=kvoli TestPromoteNonVoterInAddVoter requires that the initial range count of each store is balanced. Under stress/race builds this takes much longer and may time out before achieved. TestPromoteNonVoterInAddVoter was already skipped under stress, also skip the test under race. Resolves: cockroachdb#105883 Release note: None 106615: authors: add Annie Pompa to authors r=<andyyang890> a=annrpom Release note: None Epic: None Co-authored-by: Austen McClernon <[email protected]> Co-authored-by: Annie Pompa <[email protected]>
3 parents cc97c06 + 077db91 + 7c570d0 commit 27e36a0

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

AUTHORS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ Angela Dietz <[email protected]>
7777
Angela Wen <[email protected]> angelapwen <[email protected]>
7878
Angela Xu <[email protected]> angelazxu <[email protected]>
7979
80-
Annie Pompa <annie.pompa@cockroachlabs.com> <[email protected]>
80+
8181
Antoine Grondin <[email protected]>
8282
8383

pkg/kv/kvserver/replicate_queue_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2211,10 +2211,11 @@ func TestPromoteNonVoterInAddVoter(t *testing.T) {
22112211
defer leaktest.AfterTest(t)()
22122212
defer log.Scope(t).Close(t)
22132213

2214-
// This test is slow under stress and can time out when upreplicating /
2214+
// This test is slow under stress/race and can time out when upreplicating /
22152215
// rebalancing to ensure all stores have the same range count initially, due
22162216
// to slow heartbeats.
22172217
skip.UnderStress(t)
2218+
skip.UnderRace(t)
22182219

22192220
ctx := context.Background()
22202221

0 commit comments

Comments
 (0)