Skip to content

Commit 2aa1e61

Browse files
committed
asim: skip TestAllocatorSimulatorDeterministic and example_fulldisk
We found some non-deterministic behavior in the allocator simulator (see cockroachdb#105904 for more details). For now, we are skipping these potentially flaky tests. Release Note: None Epic: None
1 parent 400105c commit 2aa1e61

File tree

4 files changed

+8
-1
lines changed

4 files changed

+8
-1
lines changed

pkg/kv/kvserver/asim/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ go_test(
2929
"//pkg/kv/kvserver/asim/metrics",
3030
"//pkg/kv/kvserver/asim/state",
3131
"//pkg/kv/kvserver/asim/workload",
32+
"//pkg/testutils/skip",
3233
"@com_github_stretchr_testify//require",
3334
],
3435
)

pkg/kv/kvserver/asim/asim_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import (
2121
"github.com/cockroachdb/cockroach/pkg/kv/kvserver/asim/metrics"
2222
"github.com/cockroachdb/cockroach/pkg/kv/kvserver/asim/state"
2323
"github.com/cockroachdb/cockroach/pkg/kv/kvserver/asim/workload"
24+
"github.com/cockroachdb/cockroach/pkg/testutils/skip"
2425
"github.com/stretchr/testify/require"
2526
)
2627

@@ -39,7 +40,7 @@ func TestRunAllocatorSimulator(t *testing.T) {
3940
}
4041

4142
func TestAllocatorSimulatorDeterministic(t *testing.T) {
42-
43+
skip.WithIssue(t, 105904, "asim is non-deterministic")
4344
settings := config.DefaultSimulationSettings()
4445

4546
runs := 3

pkg/kv/kvserver/asim/tests/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ go_test(
2222
"//pkg/roachpb",
2323
"//pkg/spanconfig/spanconfigtestutils",
2424
"//pkg/testutils/datapathutils",
25+
"//pkg/testutils/skip",
2526
"//pkg/util/log",
2627
"@com_github_cockroachdb_datadriven//:datadriven",
2728
"@com_github_guptarohit_asciigraph//:asciigraph",

pkg/kv/kvserver/asim/tests/datadriven_simulation_test.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ import (
2929
"github.com/cockroachdb/cockroach/pkg/roachpb"
3030
"github.com/cockroachdb/cockroach/pkg/spanconfig/spanconfigtestutils"
3131
"github.com/cockroachdb/cockroach/pkg/testutils/datapathutils"
32+
"github.com/cockroachdb/cockroach/pkg/testutils/skip"
3233
"github.com/cockroachdb/cockroach/pkg/util/log"
3334
"github.com/cockroachdb/datadriven"
3435
"github.com/guptarohit/asciigraph"
@@ -158,6 +159,9 @@ func TestDataDriven(t *testing.T) {
158159
ctx := context.Background()
159160
dir := datapathutils.TestDataPath(t, ".")
160161
datadriven.Walk(t, dir, func(t *testing.T, path string) {
162+
if strings.Contains(path, "example_fulldisk") {
163+
skip.WithIssue(t, 105904, "asim is non-deterministic")
164+
}
161165
const defaultKeyspace = 10000
162166
loadGen := gen.BasicLoad{}
163167
var clusterGen gen.ClusterGen

0 commit comments

Comments
 (0)