Skip to content

Commit 2d508b2

Browse files
craig[bot]AlexTalks
andcommitted
107323: kvcoord: add test for transaction unexpectedly committed r=AlexTalks a=AlexTalks This adds a unit test to reproduce the behavior described in cockroachdb#103817 and seen in cockroachdb#67765, which currently is a bug in our implementation of the parallel commit protocol that results in the assertion failure known as `transaction unexpectedly committed`. The test currently validates the incorrect behavior of the known issue, though it is inded to be used to validate the potential fixes as proposed in cockroachdb#103817. Release note: None Part of: cockroachdb#103817 Co-authored-by: Alex Sarkesian <[email protected]>
2 parents 482192e + 3b2e4c8 commit 2d508b2

File tree

5 files changed

+649
-20
lines changed

5 files changed

+649
-20
lines changed

pkg/kv/kvclient/kvcoord/BUILD.bazel

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@ go_test(
120120
srcs = [
121121
"batch_test.go",
122122
"condensable_span_set_test.go",
123+
"dist_sender_ambiguous_test.go",
123124
"dist_sender_rangefeed_canceler_test.go",
124125
"dist_sender_rangefeed_mock_test.go",
125126
"dist_sender_rangefeed_test.go",
@@ -185,6 +186,7 @@ go_test(
185186
"//pkg/security/securitytest",
186187
"//pkg/server",
187188
"//pkg/settings/cluster",
189+
"//pkg/sql/catalog/bootstrap",
188190
"//pkg/sql/catalog/desctestutils",
189191
"//pkg/sql/pgwire/pgcode",
190192
"//pkg/sql/pgwire/pgerror",
@@ -202,6 +204,7 @@ go_test(
202204
"//pkg/util",
203205
"//pkg/util/caller",
204206
"//pkg/util/ctxgroup",
207+
"//pkg/util/encoding",
205208
"//pkg/util/errorutil",
206209
"//pkg/util/grpcutil",
207210
"//pkg/util/hlc",

0 commit comments

Comments
 (0)