Skip to content

Commit 2fb9cbb

Browse files
committed
sql: rename filteredStatementsData to filterStatementsData
This function is better suited to begin with a verb. Epic: none Release note: None
1 parent 3bbf620 commit 2fb9cbb

File tree

4 files changed

+8
-13
lines changed

4 files changed

+8
-13
lines changed

pkg/ui/workspaces/cluster-ui/src/indexDetailsPage/indexDetailsPage.tsx

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ import { commonStyles } from "../common";
7575
import { Loading, Timestamp } from "src";
7676
import LoadingError from "../sqlActivity/errorComponent";
7777
import { INTERNAL_APP_NAME_PREFIX } from "src/util/constants";
78-
import { filteredStatementsData } from "../sqlActivity/util";
78+
import { filterStatementsData } from "../sqlActivity/util";
7979

8080
const cx = classNames.bind(styles);
8181
const stmtCx = classNames.bind(statementsStyles);
@@ -438,12 +438,7 @@ export class IndexDetailsPage extends React.Component<
438438
criteria.includes(statement.applicationName),
439439
);
440440
}
441-
return filteredStatementsData(
442-
filters,
443-
search,
444-
filteredStatements,
445-
isTenant,
446-
);
441+
return filterStatementsData(filters, search, filteredStatements, isTenant);
447442
};
448443

449444
render(): React.ReactElement {

pkg/ui/workspaces/cluster-ui/src/sqlActivity/util.spec.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,15 @@
1010

1111
import {
1212
convertRawStmtsToAggregateStatistics,
13-
filteredStatementsData,
13+
filterStatementsData,
1414
getAppsFromStmtsResponse,
1515
} from "src/sqlActivity/util";
1616
import { mockStmtStats, Stmt } from "src/api/testUtils";
1717
import { Filters } from "src/queryFilter/filter";
1818
import Long from "long";
1919
import { cockroach } from "@cockroachlabs/crdb-protobuf-client";
2020

21-
describe("filteredStatementsData", () => {
21+
describe("filterStatementsData", () => {
2222
function filterAndCheckStmts(
2323
stmtsRaw: Stmt[],
2424
filters: Filters,
@@ -27,7 +27,7 @@ describe("filteredStatementsData", () => {
2727
) {
2828
const statements = convertRawStmtsToAggregateStatistics(stmtsRaw);
2929

30-
const filteredStmts = filteredStatementsData(
30+
const filteredStmts = filterStatementsData(
3131
filters,
3232
searchString,
3333
statements,

pkg/ui/workspaces/cluster-ui/src/sqlActivity/util.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ export function filterBySearchQuery(
4343
);
4444
}
4545

46-
export function filteredStatementsData(
46+
export function filterStatementsData(
4747
filters: Filters,
4848
search: string,
4949
statements: AggregateStatistics[],

pkg/ui/workspaces/cluster-ui/src/statementsPage/statementsPage.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ import {
8181
StatementDiagnosticsResponse,
8282
} from "../api";
8383
import {
84-
filteredStatementsData,
84+
filterStatementsData,
8585
convertRawStmtsToAggregateStatisticsMemoized,
8686
getAppsFromStmtsResponseMemoized,
8787
} from "../sqlActivity/util";
@@ -529,7 +529,7 @@ export class StatementsPage extends React.Component<
529529
databases,
530530
hasAdminRole,
531531
} = this.props;
532-
const data = filteredStatementsData(filters, search, statements, isTenant);
532+
const data = filterStatementsData(filters, search, statements, isTenant);
533533

534534
const apps = getAppsFromStmtsResponseMemoized(
535535
this.props.statementsResponse?.data,

0 commit comments

Comments
 (0)