Merge cockroachdb#106743 cockroachdb#107272 cockroachdb#107443

106743: sctest: refactor cumulative tests r=postamar a=postamar

This commit comprehensively refactors the cumulative test definitions for the declarative schema changer.

Fixes cockroachdb#106920.

Release note: None

107272: roachtest: set max lifetime for connections in local runs r=srosenberg,herkolategan a=renatolabs

This change fixes an issue observed when running roachtests that restart nodes locally. This was primarily observed on M1s, but we apply the same change regardless of platform for consistency.

Epic: none

Release note: None

107443: rangefeed: remove `Config.CheckStreamsInterval` r=erikgrinaker a=erikgrinaker

This parameter is unused.

Epic: none
Release note: None

Co-authored-by: Marius Posta <[email protected]>
Co-authored-by: Renato Costa <[email protected]>
Co-authored-by: Erik Grinaker <[email protected]>

Author: 4 people

pkg/ccl/schemachangerccl/BUILD.bazel

@@ -21,8 +21,6 @@ go_test(
         "main_test.go",
         "schemachanger_ccl_test.go",
         ":test_gen_backup_base",  # keep
-        ":test_gen_backup_mixed_base",  # keep
-        ":test_gen_backup_mixed_ccl",  # keep
         ":test_gen_ccl",  # keep
     ],
     args = select({
@@ -63,26 +61,16 @@ sctest_gen(
     name = "test_gen_backup_base",
     out = "backup_base_generated_test.go",
     ccl = True,
-    new_cluster_func = "sctest.SingleNodeCluster",
+    new_cluster_factory = "sctest.SingleNodeTestClusterFactory{}",
     package = "schemachangerccl",
     suffix = "_base",
     test_data = ["//pkg/sql/schemachanger:end_to_end_testdata_definitions"],
-    tests = ["Backup"],
-    visibility = [
-        ":__pkg__",
-        "//pkg/gen:__pkg__",
+    tests = [
+        "BackupRollbacks",
+        "BackupRollbacksMixedVersion",
+        "BackupSuccess",
+        "BackupSuccessMixedVersion",
     ],
-)
-
-sctest_gen(
-    name = "test_gen_backup_mixed_base",
-    out = "backup_base_mixed_generated_test.go",
-    ccl = True,
-    new_cluster_func = "sctest.SingleNodeMixedCluster",
-    package = "schemachangerccl",
-    suffix = "_base",
-    test_data = ["//pkg/sql/schemachanger:end_to_end_testdata_definitions"],
-    tests = ["BackupMixedVersionElements"],
     visibility = [
         ":__pkg__",
         "//pkg/gen:__pkg__",
@@ -93,34 +81,24 @@ sctest_gen(
     name = "test_gen_ccl",
     out = "ccl_generated_test.go",
     ccl = True,
-    new_cluster_func = "newMultiRegionCluster",
+    new_cluster_factory = "MultiRegionTestClusterFactory{}",
     package = "schemachangerccl",
     suffix = "_ccl",
     test_data = [":end_to_end_ccl_testdata_definitions"],
     tests = [
-        "Backup",
+        "BackupRollbacks",
+        "BackupRollbacksMixedVersion",
+        "BackupSuccess",
+        "BackupSuccessMixedVersion",
         "EndToEndSideEffects",
+        "ExecuteWithDMLInjection",
         "GenerateSchemaChangeCorpus",
         "Pause",
+        "PauseMixedVersion",
         "Rollback",
     ],
     visibility = [
         ":__pkg__",
         "//pkg/gen:__pkg__",
     ],
 )
-
-sctest_gen(
-    name = "test_gen_backup_mixed_ccl",
-    out = "backup_ccl_mixed_generated_test.go",
-    ccl = True,
-    new_cluster_func = "newMultiRegionMixedCluster",
-    package = "schemachangerccl",
-    suffix = "_ccl",
-    test_data = [":end_to_end_ccl_testdata_definitions"],
-    tests = ["BackupMixedVersionElements"],
-    visibility = [
-        ":__pkg__",
-        "//pkg/gen:__pkg__",
-    ],
-)