Skip to content

Commit 4ffc54c

Browse files
committed
logcrash: add ReportTypeAssertionFailure
Epic: none Release note: None
1 parent 5f384b3 commit 4ffc54c

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

pkg/util/log/logcrash/crash_reporting.go

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -317,6 +317,9 @@ const (
317317
// ReportTypeLogFatal signifies that this is an error report that
318318
// was generated via a log.Fatal call.
319319
ReportTypeLogFatal
320+
// ReportTypeAssertionFailure signifies that an assertion was violated (see
321+
// expect package).
322+
ReportTypeAssertionFailure
320323
)
321324

322325
// sendCrashReport posts to sentry.
@@ -376,6 +379,8 @@ func SendReport(
376379
event.Tags["report_type"] = "error"
377380
case ReportTypeLogFatal:
378381
event.Tags["report_type"] = "log_fatal"
382+
case ReportTypeAssertionFailure:
383+
event.Tags["report_type"] = "assertion"
379384
}
380385

381386
for _, f := range tagFns {
@@ -437,13 +442,15 @@ func RegisterTagFn(key string, value func(context.Context) string) {
437442
tagFns = append(tagFns, tagFn{key, value})
438443
}
439444

440-
func maybeSendCrashReport(ctx context.Context, err error) {
445+
func maybeSendCrashReport(ctx context.Context, err error, reportType ReportType) {
441446
// We load the ReportingSettings from global singleton in this call path.
442447
if sv := getGlobalSettings(); sv != nil {
443-
sendCrashReport(ctx, sv, err, ReportTypeLogFatal)
448+
sendCrashReport(ctx, sv, err, reportType)
444449
}
445450
}
446451

447452
func init() {
448-
log.MaybeSendCrashReport = maybeSendCrashReport
453+
log.MaybeSendCrashReport = func(ctx context.Context, err error) {
454+
maybeSendCrashReport(ctx, err, ReportTypeLogFatal)
455+
}
449456
}

0 commit comments

Comments
 (0)