Merge cockroachdb#107893

107893: cluster-ui: fix replicas and regions query for the database details API r=THardy98 a=THardy98

Epic: None

A change in cockroachdb#105582 caused the regions/replicas query to return incorrect, unexpected results (instead of reducing the returned rows from the CTE to a single row, the cross join caused the number of rows to square, resulting in x^2 rows)  causing the endpoint to never resolve properly, which in turn, caused an infinite loading state. This change fixes the regions/replicas query for the database details API.

Release note (ui change): fix a broken query for the database details page that was causing an infinite loading state.

Co-authored-by: Thomas Hardy <[email protected]>

Author: craig[bot]

pkg/ui/workspaces/cluster-ui/src/api/databaseDetailsApi.ts

@@ -347,19 +347,19 @@ const getDatabaseReplicasAndRegions: DatabaseDetailsQuery<DatabaseReplicasRegion
     createStmt: dbName => {
       return {
         sql: Format(
-          `WITH
-          replicasAndRegions AS (
-              SELECT
-                r.replicas,
-                ARRAY(SELECT DISTINCT split_part(split_part(unnest(replica_localities),',',1),'=',2)) AS regions
-              FROM crdb_internal.tables AS t
-              JOIN %1.crdb_internal.table_spans AS s ON s.descriptor_id = t.table_id
-              JOIN crdb_internal.ranges_no_leases AS r ON s.start_key < r.end_key AND s.end_key > r.start_key
-           WHERE t.database_name = $1
-          ),
-          unique_replicas AS (SELECT (SELECT array_agg(distinct unnested) FROM unnest(replicas) AS unnested) AS regions FROM replicasAndRegions),
-          unique_regions AS (SELECT (SELECT array_agg(distinct unnested) FROM unnest(regions) AS unnested) AS replicas FROM replicasAndRegions)
-          SELECT replicas, regions FROM unique_replicas CROSS JOIN unique_regions`,
+          `WITH replicasAndRegionsPerDbRange AS (
+            SELECT
+              r.replicas,
+              ARRAY(SELECT DISTINCT split_part(split_part(unnest(replica_localities), ',', 1), '=', 2)) AS regions
+            FROM crdb_internal.tables AS t
+                   JOIN %1.crdb_internal.table_spans AS s ON s.descriptor_id = t.table_id
+                   JOIN crdb_internal.ranges_no_leases AS r ON s.start_key < r.end_key AND s.end_key > r.start_key
+            WHERE t.database_name = $1
+          )
+           SELECT
+             array_agg(DISTINCT replica_val) AS replicas,
+             array_agg(DISTINCT region_val) AS regions
+           FROM replicasAndRegionsPerDbRange, unnest(replicas) AS replica_val, unnest(regions) AS region_val`,
           [new Identifier(dbName)],
         ),
         arguments: [dbName],