Skip to content

Commit 566b9bc

Browse files
committed
dev: clear all known node_modules/ tree with dev ui clean --all
'dev ui clean --all' previously missed a few node_modules/ directories, which caused that command to be less effective at fixing issues. Remove all known node_modules/ trees. Release note: None Epic: none
1 parent 451d761 commit 566b9bc

File tree

2 files changed

+6
-0
lines changed
  • pkg/cmd/dev

2 files changed

+6
-0
lines changed

pkg/cmd/dev/testdata/datadriven/ui

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,10 @@ rm -rf crdb-checkout/pkg/ui/workspaces/eslint-plugin-crdb/dist
146146
rm -rf crdb-checkout/pkg/ui/node_modules
147147
rm -rf crdb-checkout/pkg/ui/workspaces/db-console/node_modules
148148
rm -rf crdb-checkout/pkg/ui/workspaces/db-console/src/js/node_modules
149+
rm -rf crdb-checkout/pkg/ui/workspaces/db-console/ccl/src/js/node_modules
149150
rm -rf crdb-checkout/pkg/ui/workspaces/cluster-ui/node_modules
151+
rm -rf crdb-checkout/pkg/ui/workspaces/e2e-tests/node_modules
152+
rm -rf crdb-checkout/pkg/ui/workspaces/eslint-plugin-crdb/node_modules
150153

151154
exec
152155
dev ui e2e

pkg/cmd/dev/ui.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -591,7 +591,10 @@ func makeUICleanCmd(d *dev) *cobra.Command {
591591
filepath.Join(workspace, "pkg", "ui", "node_modules"),
592592
filepath.Join(uiDirs.dbConsole, "node_modules"),
593593
filepath.Join(uiDirs.dbConsole, "src", "js", "node_modules"),
594+
filepath.Join(uiDirs.dbConsole, "ccl", "src", "js", "node_modules"),
594595
filepath.Join(uiDirs.clusterUI, "node_modules"),
596+
filepath.Join(uiDirs.e2eTests, "node_modules"),
597+
filepath.Join(uiDirs.eslintPlugin, "node_modules"),
595598
)
596599
}
597600

0 commit comments

Comments
 (0)